3:35 a.m.
Workers ThreadPools breaks ThreadLocals
---------------------------------------
Key: HSEARCH-329
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.0.GA
Reporter: Grégoire Rolland
When Implementing multi-domains (multi-databases) FSDirectory based on thread local (to
get the thread environment, database name, etc...), the threadpool used by workers
"forgot" the thread local variables on the second call (for searching,
indexing). Works great with 3.0.1 release, but not with 3.1.0.GA.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-329) Workers ThreadPools breaks ThreadLocals
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329?pag...
]
Sanne Grinovero commented on HSEARCH-329:
-----------------------------------------
The threadlocals is quite a hack. Could you elaborate on what your use case is? We could
find a better alternative.
Workers ThreadPools breaks ThreadLocals
---------------------------------------
Key: HSEARCH-329
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.0.GA
Reporter: Grégoire Rolland
When Implementing multi-domains (multi-databases) FSDirectory based on thread local (to
get the thread environment, database name, etc...), the threadpool used by workers
"forgot" the thread local variables on the second call (for searching,
indexing). Works great with 3.0.1 release, but not with 3.1.0.GA.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-329) Workers ThreadPools breaks ThreadLocals
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329?pag...
]
Grégoire Rolland commented on HSEARCH-329:
------------------------------------------
Hello,
I implements a webapp for multiple clients. Each customer must have his database. I use
Hibernate Search to search my domain object.
I can deal with the databases, I implements a custom connection provider, based on
ThreadLocal pattern. I want to do the same thing with HSearch.
The client request take this path :
1/ RequestFilter
- Get Entity Manager Factory and get or reuse Entity Manager (reuse if there is
no new conversation), bind this to the ThreadLocal.
2/ Pass-through client layer
3/ Pass-through business layer
4/ On the integration layer, inject the entity manager, founded in the thread local and do
the work. Here the connection provider can choose the correct datasource, and the custom
FSDirectory, the correct directory for index reading/writing.
The limitation is I can't use shared index reader and i can't upgrade Hibernate
Search to 3.1.0.GA, which provide bugs fixes I need too.
I try to use multiple Entity Manager Factory, but due to huge memory footprint (about
50Mbytes each), it was not an option (or I don't know how to reduce it !!). But
it's a problem for scalability.
I hope it's quite clear for you !
thanks ...
Workers ThreadPools breaks ThreadLocals
---------------------------------------
Key: HSEARCH-329
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.0.GA
Reporter: Grégoire Rolland
When Implementing multi-domains (multi-databases) FSDirectory based on thread local (to
get the thread environment, database name, etc...), the threadpool used by workers
"forgot" the thread local variables on the second call (for searching,
indexing). Works great with 3.0.1 release, but not with 3.1.0.GA.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 p.m.
New subject: [Hibernate-JIRA] Commented: (HSEARCH-329) Workers ThreadPools breaks ThreadLocals
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329?pag...
]
Sanne Grinovero commented on HSEARCH-329:
-----------------------------------------
I think you should make your own backend, asking to stop Search from using additional
threads is a huge limitation on scalability, and for sure it's not a bug.
You could copy the code from Search 3.0.1 default's backend and port only the patches
you need; or it might just work as is.
Really I think the design should be to have one persistence context per database; If you
are giving each client it's own database then 50mb is not much.
Another option is to use filters.. much better idea IMHO, and you'll have to mantain
and manage only one index for your application.
If it gets too big or if you have "law" regulations, you can then use sharding
to split the index and store them separately.
"Hibernate Search in Action" has quite some tips about this situations.
Workers ThreadPools breaks ThreadLocals
---------------------------------------
Key: HSEARCH-329
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.0.GA
Reporter: Grégoire Rolland
When Implementing multi-domains (multi-databases) FSDirectory based on thread local (to
get the thread environment, database name, etc...), the threadpool used by workers
"forgot" the thread local variables on the second call (for searching,
indexing). Works great with 3.0.1 release, but not with 3.1.0.GA.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:08 a.m.
New subject: [Hibernate-JIRA] Closed: (HSEARCH-329) Workers ThreadPools breaks ThreadLocals
[
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329?pag...
]
Sanne Grinovero closed HSEARCH-329.
-----------------------------------
Resolution: Rejected
I'm sorry we can't change this.
Workers ThreadPools breaks ThreadLocals
---------------------------------------
Key: HSEARCH-329
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-329
Project: Hibernate Search
Issue Type: Bug
Components: directory provider
Affects Versions: 3.1.0.GA
Reporter: Grégoire Rolland
When Implementing multi-domains (multi-databases) FSDirectory based on thread local (to
get the thread environment, database name, etc...), the threadpool used by workers
"forgot" the thread local variables on the second call (for searching,
indexing). Works great with 3.0.1 release, but not with 3.1.0.GA.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5798
days inactive
5916
days old
hibernate-issues@lists.jboss.org
4 comments
2 participants
participants (2)
-
Grégoire Rolland (JIRA) -
Sanne Grinovero (JIRA)