[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2835?page=c... ] Jeremy Grodberg commented on HHH-2835: -------------------------------------- I've figured out what's going on. This is the Hibernate team's choice as to whether this is an implementation issue or a documentation issue, but I guess it is the latter. It appears that at least since Hibernate3 was first officially released (probably in Hibernate2 as well, I didn't check) the "org.hibernate.type" logging was done not at the "debug" level but rather at the "trace" level. However, prior to log4j 1.2.12 log4j did not support a trace level and treated "trace" as synonymous with "debug". Hibernate still ships with log4j 1.2.11 (perhaps because of this very issue?). I was confused because we switched over to log4j 1.2.13 (from 1.2.9) at the same time we switched over to annotations. The documentation around table 3.9 doesn't actually specify what level of logging to set for org.hibernate.type, but rather points the reader to the example log4j.properties file in the Hibernate src/ directory (in the Hibernate distribution). That file is no longer in src/ but now is in etc/ and in that file the log level for "type" is set to info, with a debug (not trace) setting commented out. Likewise the FAQ answer for "how do I configure logging" at http://www.hibernate.org/119.html#A17 says "Just change INFO to DEBUG to see more messages" which of course works fine if you also follow the suggestion to use the version of log4j shipped with Hibernate, but not if you use a later version (note that log4j 1.2.12 was relased over 2 years ago). Last but not least, the Hibernate3 JBoss and XDoclet tips page at http://www.hibernate.org/282.html says "Turn on DEBUG logging for org.hibernate.type to get a better idea of what the problem really is." My request is that you update the documentation in 3 places: (1) Section 3.5 of the Hibernate Reference Documentation (2) The configuration FAQ answer under Miscellaneous FAQs at http://www.hibernate.org/119.html#A17 (3) The log4j.properties file in etc/ in the source distribution I've already updated the Hibernate3 JBoss and XDoclet tips at http://www.hibernate.org/282.html In the Reference Documentation, I request you correct the location of the log4j.properties file and add something like this: "Hibernate uses both TRACE level and DEBUG level logging. Some logging libraries treat TRACE and DEBUG as the same (notably log4j prior to version 1.2.12) while others honor the difference. Set the logging level to TRACE if you want to be sure to get everything possible. " Update the FAQ with something like "Just change INFO to DEBUG or even TRACE to see more messages" instead of "Just change INFO to DEBUG." FYI, Hibenrate 3.2.5.ga calls log.trace() in 287 places according to Eclipse. OR, ALTERNATELY, just change the logging in org.hibernate.type.NullableType to be at the debug rather than the trace level. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2835?page=c... ] Diego Plentz reassigned HHH-2835: --------------------------------- Assignee: Diego Plentz -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2835?page=c... ] Steve Ebersole commented on HHH-2835: ------------------------------------- This is controlled by the org.hibernate.type.NullableType class. rev 10614 does not effect this class wing... I assume if anything it is rev 11046: http://viewvc.jboss.org/cgi-bin/viewvc.cgi/hibernate/core/branches/Branch... That is the only change to how the logging is done in this timeframe. The change was the introduction of caching the Log to use, whereas previously it was looked up each and everytime. Probably if you revert those calls to invoke LogManager.getLog(...) everytime again it will work again. Perhaps one of y'all can verify that? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2835?page=c... ] Evan M commented on HHH-2835: ----------------------------- The likely problem is that the code Steve refers to above is executed only when the NullableType class is initialized (which happens as soon as Hibernate is configured). If the application hasn't configured its log by the time that happens, there are no further opportunities to do so, and NullableType will ignore any changes to log configuration after that. I am most interested in bind parameters when debugging unit test failures. I was able to have them logged by putting this in the base test case class: static { // initialize log4j with the test params PropertyConfigurator.configure("/path/to/log4j.properties"); } This isn't a great user experience. I think the Hibernate maintainers should: 1. Put something into the debug log at the time this decision is made, perhaps: "DEBUG [main] org.hibernate.type (NullableType.java:59) - Tracing of bind parameters and selected values will be DISABLED based on the current value of getLogger("org.hibernate.type").isTraceEnabled()." 2. Consider delaying this read until it is actually needed... perhaps the first time a session is opened, or something like that. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2835?page=c... ] Razan Abbass commented on HHH-2835: ----------------------------------- [cheap airline tickets|http://getflightsto.com] [Parenting|http://childcareforums.com] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira