[Hibernate-JIRA] Created: (HHH-7160) Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap when NaturalId values changed
4:49 a.m.
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed
----------------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see attached
Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:01 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-7160) Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Steve Ebersole closed HHH-7160.
-------------------------------
Resolution: Out of Date
This was already addressed as part of another issue
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry
in naturalIdToPkMap when NaturalId values changed
----------------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Labels: naturalId
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-7160) Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Steve Ebersole reopened HHH-7160:
---------------------------------
Suitable for new contributors: [Yes, likely]
Assignee: Steve Ebersole
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry
in naturalIdToPkMap when NaturalId values changed
----------------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-7160) NaturalIdXrefDelegate#cache() needs to remove obsolete entries in shared cache when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Steve Ebersole updated HHH-7160:
--------------------------------
Fix Version/s: 4.1.2
Summary: NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed (was: Method NaturalIdXrefDelegate#cache()
misses to remove obsolete entry in naturalIdToPkMap when NaturalId values changed)
NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed
------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Fix For: 4.1.2
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7160) NaturalIdXrefDelegate#cache() needs to remove obsolete entries in shared cache when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Guenther Demetz commented on HHH-7160:
--------------------------------------
Following the instructions how to fix this issue:
1. Modify NaturalIdResolutionCache#cache by adding session as third parameter and adding
the block after 'if ( persister.hasNaturalIdCache()':
{code:title=NaturalIdResolutionCache.java|borderStyle=solid}
public boolean cache(Serializable pk, Object[] naturalIdValues, SessionImplementor
session) {
final CachedNaturalId initial = pkToNaturalIdMap.get( pk );
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues() ) ) {
return false;
}
naturalIdToPkMap.remove( initial );
if ( persister.hasNaturalIdCache() ) {
final NaturalIdCacheKey naturalIdCacheKey = new NaturalIdCacheKey(
initial.getValues(), persister, session );
persister.getNaturalIdCacheAccessStrategy().evict( naturalIdCacheKey );
}
}
final CachedNaturalId cachedNaturalId = new CachedNaturalId( persister, naturalIdValues
);
pkToNaturalIdMap.put( pk, cachedNaturalId );
naturalIdToPkMap.put( cachedNaturalId, pk );
return true;
}
{code}
2. Add session as 3hrd parameter (around line 81 in NaturalIdXrefDelegate.java)
{code:title=NaturalIdXrefDelegate.java|borderStyle=solid}
final boolean justAddedToLocalCache = entityNaturalIdResolutionCache.cache( pk,
naturalIdValues, persistenceContext.getSession() );
{code}
NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed
------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Fix For: 4.1.2
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:50 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-7160) NaturalIdXrefDelegate#cache() needs to remove obsolete entries in shared cache when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Guenther Demetz commented on HHH-7160:
--------------------------------------
The according test-method to add in
org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest
{code:title=org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest.java|borderStyle=solid}
@Test
@TestForIssue( jiraKey = "HHH-7160" )
public void testHHH7160() {
NaturalIdOnManyToOne singleManyToOne = new NaturalIdOnManyToOne();
Citizen c1 = new Citizen();
c1.setFirstname( "Emmanuel" );
c1.setLastname( "Bernard" );
c1.setSsn( "1234" );
State france = new State();
france.setName( "Ile de France" );
State italy = new State();
italy.setName( "Italia" );
c1.setState( france );
singleManyToOne.setCitizen( c1 );
Session s = openSession();
Transaction tx = s.beginTransaction();
s.persist( france );
s.persist( italy );
s.persist( c1 );
s.persist( singleManyToOne );
c1.setState( italy );
s.flush(); // due fix HHH-7160, now the obsolete entry should get evicted
from shared cache
assertNull(s.byNaturalId(Citizen.class).using("state",
france).using("ssn","1234" ).load());
}
{code}
NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed
------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Fix For: 4.1.2
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:06 p.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HHH-7160) NaturalIdXrefDelegate#cache() needs to remove obsolete entries in shared cache when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Guenther Demetz edited comment on HHH-7160 at 3/16/12 12:06 PM:
----------------------------------------------------------------
The according test-method to add in
org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest
{code:title=org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest.java|borderStyle=solid}
@Test
@TestForIssue( jiraKey = "HHH-7160" )
public void testHHH7160() {
NaturalIdOnManyToOne singleManyToOne = new NaturalIdOnManyToOne();
Citizen c1 = new Citizen();
c1.setFirstname( "Emmanuel" );
c1.setLastname( "Bernard" );
c1.setSsn( "1234" );
State france = new State();
france.setName( "Ile de France" );
State italy = new State();
italy.setName( "Italia" );
c1.setState( france );
singleManyToOne.setCitizen( c1 );
Session s = openSession();
Transaction tx = s.beginTransaction();
s.persist( france );
s.persist( italy );
s.persist( c1 );
s.persist( singleManyToOne );
c1.setState( italy );
s.flush(); // due fix HHH-7160, now the obsolete entry should get evicted
from shared cache
assertNull(s.byNaturalId(Citizen.class).using("state",
france).using("ssn","1234" ).load());
}
{code}
N.B.: To make the testcase work, the NaturalId on state in Citizen has to be turned into a
mutable one:
{code:title=org.hibernate.test.annotations.naturalid.Citizen .java|borderStyle=solid}
@NaturalId(mutable=true)
@ManyToOne
private State state;
{code}
was (Author: pb00067):
The according test-method to add in
org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest
{code:title=org.hibernate.test.annotations.naturalid.NaturalIdOnSingleManyToOneTest.java|borderStyle=solid}
@Test
@TestForIssue( jiraKey = "HHH-7160" )
public void testHHH7160() {
NaturalIdOnManyToOne singleManyToOne = new NaturalIdOnManyToOne();
Citizen c1 = new Citizen();
c1.setFirstname( "Emmanuel" );
c1.setLastname( "Bernard" );
c1.setSsn( "1234" );
State france = new State();
france.setName( "Ile de France" );
State italy = new State();
italy.setName( "Italia" );
c1.setState( france );
singleManyToOne.setCitizen( c1 );
Session s = openSession();
Transaction tx = s.beginTransaction();
s.persist( france );
s.persist( italy );
s.persist( c1 );
s.persist( singleManyToOne );
c1.setState( italy );
s.flush(); // due fix HHH-7160, now the obsolete entry should get evicted
from shared cache
assertNull(s.byNaturalId(Citizen.class).using("state",
france).using("ssn","1234" ).load());
}
{code}
NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed
------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Fix For: 4.1.2
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:33 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-7160) NaturalIdXrefDelegate#cache() needs to remove obsolete entries in shared cache when NaturalId values changed
[
https://hibernate.onjira.com/browse/HHH-7160?page=com.atlassian.jira.plug...
]
Steve Ebersole resolved HHH-7160.
---------------------------------
Resolution: Fixed
NaturalIdXrefDelegate#cache() needs to remove obsolete entries in
shared cache when NaturalId values changed
------------------------------------------------------------------------------------------------------------
Key: HHH-7160
URL: https://hibernate.onjira.com/browse/HHH-7160
Project: Hibernate ORM
Issue Type: Bug
Components: core
Affects Versions: 4.1.1
Environment: Hibernate4.1.1
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Labels: naturalId
Fix For: 4.1.2
Attachments: TestCaseNaturalIdChangeBetweenPersistAndFlush.jar
Original Estimate: 1h
Time Spent: 2.25h
Remaining Estimate: 1h
Method NaturalIdXrefDelegate#cache() misses to remove obsolete entry in naturalIdToPkMap
when NaturalId values changed,
thus NaturalIdAccess delivers results even by searching with obsolete values (see
attached Testcase).
Cause:
following instruction is missing in Method NaturalIdXrefDelegate#cache():
if ( initial != null ) {
if ( areSame( naturalIdValues, initial.getValues()) ) {
return false;
}
naturalIdToPkMap.remove(initial); // <-- this instruciton is missing
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5128
days inactive
5139
days old
hibernate-issues@lists.jboss.org
7 comments
2 participants
participants (2)
-
Guenther Demetz (JIRA) -
Steve Ebersole (JIRA)