[Hibernate-JIRA] Created: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
12:14 p.m.
Hibernate doesn't support official JPA2 escape char for table name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby (used
for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole updated HHH-4553:
--------------------------------
Assignee: Steve Ebersole
Fix Version/s: 3.5
Actually I think the more correct solution is for the annotation binder to see the
double-quotes in the table name and convert them to back-ticks.
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:17 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole updated HHH-4553:
--------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HHH-4325
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:19 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole commented on HHH-4553:
-------------------------------------
Reference -> 2.13 Naming of Database Objects
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Emmanuel Bernard commented on HHH-4553:
---------------------------------------
+1 we should also keep support for back-ticks as it's much much more elegant than the
crap \" the EG managed to impose on us.
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole commented on HHH-4553:
-------------------------------------
IMO, the most correct psuedo-logic here is:
{code}
String objectName = [getExplicitName];
// apply naming strategy
if ( objectName == null ) {
// No explicit name given, so allow the naming strategy the chance
// to determine it based on the corresponding mapped java name
objectName = namingStrategy.[determineDatabaseObjectNameBasedOnMappedJavaName];
// Conceivable that the naming strategy could return a quoted identifier, or
// that user enabled <delimited-identifiers/>
objectName = normalizeQuotedIdentifier( objectName );
}
else {
// An explicit name was given:
// in some cases we allow the naming strategy to "fine tune" these, but
first
// handle any quoting for consistent handling in naming strategies
objectName = normalizeQuotedIdentifier( objectName );
objectName = namingStrategy.[fineTuneExplicitName];
objectName = normalizeQuotedIdentifier( objectName );
}
private String normalizeQuotedIdentifier(String identifier) {
if ( identifier != null
&& identifier.startsWith( "\"" )
&& identifier.endsWith( "\"" ) ) {
return '`' + identifier.substring( 1, identifier.length() - 1 ) +
'`';
}
if ( identifier != null && useQuotedIdentifiersGlobally
&& ! ( identifier.startsWith( "`" ) &&
identifier.endsWith( "`" ) ) {
return '`' + identifier + '`';
}
return identifier;
}
{code}
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole commented on HHH-4553:
-------------------------------------
The commit to revision #18148 introduces support for both (a) use of double-quote quoting
and (b) global quote-identifier use (what JPA calls <delimited-identifiers/>) to:
1) Tables (should be all tables) : name, schema, catalog
2) UniqueConstraints : name and column-names
3) id generators should account for all identifiers used in built-in generators
Support for columns is still generally left to do
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
Time Spent: 6 hours, 35 minutes
Remaining Estimate: 0 minutes
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole commented on HHH-4553:
-------------------------------------
Clarification, the support for "global quoted-identifiers" was added to core
which is enabled by the org.hibernate.cfg.Environment#GLOBALLY_QUOTED_IDENTIFIERS option.
Still need to account for the 'bridge' where EM (or whatever) sees
<delimited-identifiers/> in persistence.xml and enables that config option.
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
Time Spent: 6 hours, 35 minutes
Remaining Estimate: 0 minutes
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Emmanuel Bernard commented on HHH-4553:
---------------------------------------
Make sure that
"When using XML, a name is specified as a delimited identifier by use of double
quotes, e.g., <table name=""customer""/>"
properly works
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
Time Spent: 6 hours, 35 minutes
Remaining Estimate: 0 minutes
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:15 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole commented on HHH-4553:
-------------------------------------
Apparently the final yet-to-be-release adds a very troubling footnote that effects how
quoting occurs in the case where both approaches intersect. According to the footnote,
@Table(name="\"test\"") + <delimited-identifier/> should lead to
the actual name being name="\"\"test\"\"". We do not
support that as of yet. Essentially the footnote makes this an additive situation, while
my code treats it as either or. For the time being I will leave this as-is.
I ended up sometimes applying the "name normalization" code multiple times,
which could be very bad with this new additive rule: "test" ->
""test"" -> """test""" -> ...
If we do need to end up fixing this (as of now I only plan on doing this if the TCK
explicitly tests for it) I want this handled via the
org.hibernate.cfg.Environment#JPAQL_STRICT_COMPLIANCE switch as I'd prefer this
"additive approach" to not be the default behavior.
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
Time Spent: 6 hours, 35 minutes
Remaining Estimate: 0 minutes
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-4553) Hibernate doesn't support official JPA2 escape char for table name
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553?page=c...
]
Steve Ebersole resolved HHH-4553.
---------------------------------
Resolution: Fixed
Columns should all be accounted for now too
Hibernate doesn't support official JPA2 escape char for table
name
------------------------------------------------------------------
Key: HHH-4553
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4553
Project: Hibernate Core
Issue Type: Sub-task
Affects Versions: 3.5.0-Beta-2
Environment: Oracle 9i
Derby
Reporter: Julien HENRY
Assignee: Steve Ebersole
Fix For: 3.5
Time Spent: 6 hours, 35 minutes
Remaining Estimate: 0 minutes
One of the table of my schema is named FUNCTION. As it is a reserved name with Derby
(used for my JUnit tests), I have escaped the table name to make it works with Derby (as
specified by JPA2 spec $2.13):
@Entity
@Table(name="\"FUNCTION\"")
public class Function {
//...
}
My JUnit tests are working fine, then I tried to connect to my Oracle DB, and I have
enabled schema validation:
<property name="hibernate.hbm2ddl.auto" value="validate"/>
But I got an exception as Hibernate is looking for a table with name "FUNCTION"
in Oracle metadata.
Caused by: org.hibernate.HibernateException: Missing table: "FUNCTION"
at org.hibernate.cfg.Configuration.validateSchema(Configuration.java:1153)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.tool.hbm2ddl.SchemaValidator.validate(SchemaValidator.java:139)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:364)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1367)
[hibernate-core-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:858)
[hibernate-annotations-3.5.0-Beta-2.jar:3.5.0-Beta-2]
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:733)
[hibernate-entitymanager-3.5.0-Beta-2.jar:3.5.0-Beta-2]
This is not specific to Oracle, because when I change:
<property name="hibernate.hbm2ddl.auto" value="create"/>
by
<property name="hibernate.hbm2ddl.auto" value="validate"/>
in my JUnit tests, I have the same issue with the embedded Derby DB.
Using Hibernate specific ` as quote works fine:
@Entity
@Table(name="`FUNCTION`")
public class Function {
//...
}
The issue can be easily fixed in Table.setName(String name). Replace:
if ( name.charAt( 0 ) == '`' ) {
by
if ( name.charAt( 0 ) == '"' ) {
or if you want to keep backward compatibility:
if ( name.charAt( 0 ) == '`' || name.charAt( 0 ) == '"' ) {
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5314
days inactive
5343
days old
hibernate-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Emmanuel Bernard (JIRA) -
Julien HENRY (JIRA)
-
Steve Ebersole (JIRA)