[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole commented on HHH-5428: ------------------------------------- afaict though this is an issue with the NamingStrategy implementations. Or...? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Emmanuel Bernard commented on HHH-5428: --------------------------------------- Did you apply the fix I sent you the Friday before my vacations? This was the one fixing this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Emmanuel Bernard commented on HHH-5428: --------------------------------------- I don't think it's as critical as you describe it. Remember it only happens if people don't set an explicit name to their collection table. So if things don't suit their needs, they can make the name explicit. My goal here was to make default naming operations work in as much cases as possible. What are the real problems you are referring to? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Emmanuel Bernard commented on HHH-5428: --------------------------------------- If we can settle on smarter rules, that's of course a better outcome. Maybe something as simple as if the collection table contains only a-z A-Z 0-9 and _ we don't quote. My initial gut feeling is that it was a a sloppy road but maybe I am wrong. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole commented on HHH-5428: ------------------------------------- Well this illustrates a failing in the {{NamingStrategy}} contract imo. The {{NamingStrategy}} is not "clued in" to the fact that the owner table name is quoted. I mean there is just a disconnect here between the {{NamingStrategy}} and the caller. One way to view this is that we really should not be using strings here for the names. We really should have a notion of Identifier or Name. In fact the new metamodel stuff I am working on does just this. Then the {{NamingStrategy}} could just ask the Identifier/Name if it is quoted. Of course this means a change to the contract. Another option is to actually pass in the quoted owner table name (with the backticks). Currently we do {code} String logicalOwnerTableName = ownerTable.getName(); {code} and pass {{logicalOwnerTableName}} in to the {{NamingStrategy}}. Instead we could do {code} String logicalOwnerTableName = ownerTable.getQuotedName(); {code} and document the change in behavior in the migration guide. I think you are right that any set of rules we could ever hope to apply to the code in {{HBMBinder}} is never going to work properly. That is why I said all along that imo it is not a responsibility of the {{HBMBinder}}. And you are right also about this in regards to trying to apply rules in the {{NamingStrategy}} too, *provided* we keep passing in the same parameter value for the ownerTableName. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole updated HHH-5428: -------------------------------- Fix Version/s: (was: 3.6.0.Beta4) cfg-rework -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole updated HHH-5428: -------------------------------- Fix Version/s: (was: 4.0.0.Alpha1) 4.0.0.Alpha2 Discuss whether to pass Identifier from new metamodel into {{NamingStrategy}} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole updated HHH-5428: -------------------------------- Fix Version/s: (was: 4.0.0.Alpha2) 4.0.0.Alpha3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5428?page=c... ] Steve Ebersole commented on HHH-5428: ------------------------------------- I am thinking at this point that we can simply say this will be fixed by HHH-6077 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira