[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Anthony Patricio updated HHH-4614: ---------------------------------- Description: Notes: - test runs fine with cglib, hb 3.2.4 SP1 + ann 3.2.1 - test runs fine with cglib, plain mapping files (trunk). - no matter if you use annotation or mapping files, test will fail using javassist (it used to fail with previous version too) So focus on instrumentation done using cglib. See attached testcase to reproduce the problem. Guideline: - testcase the pattern used in hb-core, just using annotations - run org.hibernate.test.instrument2.runtime.CGLIBInstrumentationTest - easy to switch from annotation to mapping files in org.hibernate.test.instrument2.cases.AbstractExecutable (comment/uncomment specific lines in getAnnotatedClasses and getXmlFiles) interesting point: if you complete the source with id setters + annotate the getters (instead of fields) + make the getInterestRate @Transient, the test passes. was: Notes: - test runs fine with cglib, hb 3.2.4 SP1 + ann 3.2.1 - test runs fine with cglib, plain mapping files (trunk). - no matter if you use annotation or mapping files, test will fail using javassist (it used to fail with previous version too) So focus on instrumentation done using cglib. See attached testcase to reproduce the problem. Guideline: - testcase is a duplication of what is tested in hb-core, just using annotations - run org.hibernate.test.instrument2.runtime.CGLIBInstrumentationTest - easy to switch from annotation to mapping files in org.hibernate.test.instrument2.cases.AbstractExecutable (comment/uncomment specific lines in getAnnotatedClasses and getXmlFiles) interesting point: if you complete the source with id setters + annotate the getters (instead of fields) + make the getInterestRate @Transient, the test passes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Emmanuel Bernard updated HHH-4614: ---------------------------------- Attachment: minimal-test-cglib.zip The problem for CGLIB is that CGLIB removes annotations on fields for some reason. I've simplified the test case to not use Hibernate except for the InstrumentCL and BytecodeImpl. Run SimpleCGLIBInstrumentationTest to see what's going on. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Strong Liu updated HHH-4614: ---------------------------- Attachment: SimpleJavassistInstrumentationTest.java the SimpleJavassistInstrumentionTest passes so the original issue fails on javassist because of some hibernate code? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Emmanuel Bernard commented on HHH-4614: --------------------------------------- yes Javassist has a different issue altogether that I haven't spend time to identify. Kabir or somebody with javassist knowledge would be better placed I guess. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Emmanuel Bernard commented on HHH-4614: --------------------------------------- (Leaving the bug open because Javassist has a different error). I am ot checking this one :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Strong Liu updated HHH-4614: ---------------------------- Attachment: cglib-2.2-JBoss-1.jar cglib-2.2-JBoss-1.jar has been patched, please use this jar instead of the original jar from http://cglib.sourceforge.net -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Strong Liu commented on HHH-4614: --------------------------------- looks like hibernate does not instrument CustomerAccountBase.getAccountProduct() method take a look of https://anonsvn.jboss.org/repos/hibernate/core/trunk/core/src/main/java/o... the code in FieldTransformer.transformInvokevirtualsIntoPutAndGetfields: if (codeAttr == null) { return; } this will skip other methods once the current MethodInfo.getCodeAttribute() return null, I tried to change the "return" to "continue", then the test passes (HBM only, haven't test annotations yet" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Strong Liu updated HHH-4614: ---------------------------- Attachment: HHH-4614-Javassist.patch this patch (HHH-4614-Javassist.patch) can make the test case attached pass (both HBM and annotations) I created this patch on trunk -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4614?page=c... ] Strong Liu updated HHH-4614: ---------------------------- Description: Notes: - no matter if you use annotation or mapping files, test will fail using javassist (it used to fail with previous version too) See attached testcase to reproduce the problem. Guideline: - testcase the pattern used in hb-core, just using annotations - run org.hibernate.test.instrument2.runtime.JAVASSISTInstrumentationTest - easy to switch from annotation to mapping files in org.hibernate.test.instrument2.cases.AbstractExecutable (comment/uncomment specific lines in getAnnotatedClasses and getXmlFiles) was: Notes: - test runs fine with cglib, hb 3.2.4 SP1 + ann 3.2.1 - test runs fine with cglib, plain mapping files (trunk). - no matter if you use annotation or mapping files, test will fail using javassist (it used to fail with previous version too) So focus on instrumentation done using cglib. See attached testcase to reproduce the problem. Guideline: - testcase the pattern used in hb-core, just using annotations - run org.hibernate.test.instrument2.runtime.CGLIBInstrumentationTest - easy to switch from annotation to mapping files in org.hibernate.test.instrument2.cases.AbstractExecutable (comment/uncomment specific lines in getAnnotatedClasses and getXmlFiles) interesting point: if you complete the source with id setters + annotate the getters (instead of fields) + make the getInterestRate @Transient, the test passes. Affects Version/s: 3.2.4.sp1 Component/s: (was: annotations) core Summary: (javassist) Instrumented model with abstract MappedSuperclass and field access doesn't work (was: Instrumented model with abstract MappedSuperclass and field access doesn't work) split this issue I will create another one focus on cglib later -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira