[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Sven Rienstra commented on HHH-5750: ------------------------------------ I'm not using the Tools class directly, but after I inserted an audited object, an other audited object had lost it's session and I identified this tools method as the cause. I'll try to explain the scenario: I have 2 classes Person and Target. Person has a list of targets. Target has a ManyToOne relation to Person and Person has an OneToMany(mappedBy="person"). Both classes are audited. After I called saveOrUpdate to insert a new target, the session from all proxies in the Person object are gone. So when I try to get the list with targets from the person, I get a no session error. -- Code fragment: //Doel = target, Patient = person //Patientmodel is a Wicket model holding a patient proxy Doel doel = this.getModelObject(); doel.setZwipPatient(patientModel.getObject()); doelenService.saveOrUpdate(doel); //Current workaround hibernateService.getHibernateSession().evict(patientModel.getObject()); patientModel.detach(); <== Creates a new proxy patientModel.getObject().getDoelen(); <==Breaks without workaround, because the Patient proxy now contains an implementation linked to a closed session. (the temporary session created in the tools method) -- END I Hope this clarifies the bug a bit. The only I reason I wrote the testcase this way is because when I was debugging I found the session was removed from the PersistentBag by this method in Tools. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Sven Rienstra commented on HHH-5750: ------------------------------------ I think the solution to fix this bug is actually very simple, just remove the following line of code: proxy.getHibernateLazyInitializer().setImplementation( target ); I see no reason to place back the target in the proxy. (I wanted to make a push request or patch file, but egit is not my favorite pluin yet ;) ) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Erik-Berndt Scheper commented on HHH-5750: ------------------------------------------ It's your own choice ... However, pull requests tend to be integrated faster than patch files. It's just great to be able to comment on individual commits. And you don't need egit to create a pull request; Git works great from the command line. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Erik-Berndt Scheper commented on HHH-5750: ------------------------------------------ Note that HHH-4791 contains more information why the target must be injected into the proxy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Erik-Berndt Scheper commented on HHH-5750: ------------------------------------------ Note that HHH-4791 contains more information why the target must be injected into the proxy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Erik-Berndt Scheper commented on HHH-5750: ------------------------------------------ Since Adam has asserted that this change shouldn't do any harm, I will add the testcase and resolve this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5750?page=c... ] Erik-Berndt Scheper resolved HHH-5750. -------------------------------------- Resolution: Fixed Fix Version/s: 4.0.0.Alpha1 3.6.1 Fixed in master by commit f125f06c4575294ed58960f6e09c524d29114440 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira