[Hibernate-JIRA] Created: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
1:17 p.m.
Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure that
this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Gunnar Morling commented on HV-402:
-----------------------------------
Right, there is no problem if ValueMessageInterpolator is not explicitely configured.
But there is a problem, if you do want to work with ValueMessageInterpolator but only want
to use the toString() approach (and not the scripting one) for the interpolation of the
validated value. This is because this class can't be loaded by the JVM when running on
JDK 5 (and not having a JSR 223 implementation on the classpath) due to the imports from
javax.script.*
So if I'm not mistaken one always needs a JSR 223 implementation to use
ValueMessageInterpolator although not actually using scripting interpolation.
We had a similar issue (HV-302), where JAXB was always required, also if no XML
configuration was used. This was solved by only loading those classes importing from
javax.xml.bind.* if actually required.
To confirm, one would need to configure ValueMessageInterpolator and test a toString()
interpolation, which currently is expected to fail on JDK 5.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:54 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Kevin Pollet commented on HV-402:
---------------------------------
I've just test the ValueMessageInterpolator on JDK5 with a toString() interpolation
and as said Gunnar it's failed. The error is when the ValueMessageInterpolator is
instantiated by the user because this class imports _javax.script.ScriptException_.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Kevin Pollet commented on HV-402:
---------------------------------
It's not a ValueMessageInterpolator consequences but it seems that Hibernate Validator
doesn't work well with JDK 5 because of an _Arrays.copyOf_ call which is available
since JDK 6.
{quote}
Exception in thread "main" java.lang.NoSuchMethodError:
java.util.Arrays.copyOf([Ljava/lang/Object;I)[Ljava/lang/Object;
at
org.hibernate.validator.engine.ValidatorImpl.determineGroupExecutionOrder(ValidatorImpl.java:194)
at org.hibernate.validator.engine.ValidatorImpl.validate(ValidatorImpl.java:120)
{quote}
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Gunnar Morling commented on HV-402:
-----------------------------------
Thanks for pointing that out. Could you create a separate JIRA issue for this, as it is
unrelated to the problem at hand?
This problem is quite new, it originates from
https://github.com/hibernate/hibernate-validator/commit/8f7460ff51b67f92a...
. System#arraycopy() could be used instead.
Hardy, maybe we can setup another Hudson session which executes the build/tests on JDK 5?
I remember a similar issue where I accidentally used a String method also introduced with
SE 6.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Kevin Pollet commented on HV-402:
---------------------------------
Sure, the created issue is HV-405.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:53 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik commented on HV-402:
--------------------------------------
Thanks Kevin for creating HV-405. {{java.util.Arrays.copyOf}} must have sneaked in with my
latest ValidatorImpl changes. I was experimenting a lot at missed this one.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:51 p.m.
New subject: [Hibernate-JIRA] Updated: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik updated HV-402:
---------------------------------
Assignee: (was: Hardy Ferentschik)
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik commented on HV-402:
--------------------------------------
With HV-403 ready to go, the easiest seems to be to remove/disable
{{ValueMessageInterpolator}} (or {{ValueScriptingMessageInterpolator}} as it is called in
its latest version)
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:46 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Gunnar Morling commented on HV-402:
-----------------------------------
I think we should remove this interpolator, as we have a straight-forward and easy to use
solution for the value interpolation problem with HV-403. The code of
ValueScriptingMessageInterpolator could be put into the Wiki, so anybody interested can
give it a try.
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:37 a.m.
New subject: [Hibernate-JIRA] Assigned: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik reassigned HV-402:
------------------------------------
Assignee: Hardy Ferentschik
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:09 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik commented on HV-402:
--------------------------------------
Created wiki page -
http://community.jboss.org/wiki/CustomMessageInterpolatorusingJavaScripti...
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:55 p.m.
New subject: [Hibernate-JIRA] Resolved: (HV-402) Make sure that Validator still works on JDK 5 due to ValueMessageInterpolator
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-402?page=com...
]
Hardy Ferentschik resolved HV-402.
----------------------------------
Resolution: Fixed
Make sure that Validator still works on JDK 5 due to
ValueMessageInterpolator
-----------------------------------------------------------------------------
Key: HV-402
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-402
Project: Hibernate Validator
Issue Type: Bug
Components: documentation, engine
Affects Versions: 4.1.0.Final
Reporter: Hardy Ferentschik
Assignee: Hardy Ferentschik
Fix For: 4.2.0.Beta1
{{ValueMessageInterpolator}} requires the JSR 223 scripting API. We have to make sure
that this does not cause any problems on a Java 5 runtime. However, since you have to
explicitly configure this interpolator. We have to confirm that though.
We probably need a note in the documentation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5152
days inactive
5168
days old
hibernate-issues@lists.jboss.org
12 comments
3 participants
participants (3)
-
Gunnar Morling (JIRA) -
Hardy Ferentschik (JIRA)
-
Kevin Pollet (JIRA)