[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard moved HV-295 to BVAL-202: ------------------------------------------ Component/s: (was: engine) spec-general Key: BVAL-202 (was: HV-295) Project: Bean Validation (was: Hibernate Validator) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard commented on BVAL-202: --------------------------------------- Solution #3 Let constraints not defining a ConstraintValidator<Constraint, Iterable<?>> (or any of the Iterator subclasses) be applied on the collection elements. This works well as applying such a constraint today on a Iterable<?> raises a runtime exception. Use solution #1 or #2 for constraints that do declare a ConstraintValidator<Constraint, Iterable<?>> @NotNull @Size(max=30) @Size(max=50, validElements=true) @Email Collection<String> emails; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard commented on BVAL-202: --------------------------------------- for solution #2 validateElements might be a better name and is still within the realm of the reserved valid prefix -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard edited comment on BVAL-202 at 3/15/10 10:38 AM: ----------------------------------------------------------------- Solution #4 add a new OnElements subannotation. This annotation should contain all the attribute of its mother constraint annotation. .List should probably contains this annotation too. [code] @NotNull @Size(max=30) @Size.OnElements(max=50) @Email.OnElements Collection<String> emails; [/code] where public @interface Size { String message() default {...}; int min default 0; ... @interface OnElements { String message() default {...}; int min default 0; } @interface List { Size[] value(); @interface OnElements { Size[] value(); } } advanced example @Size.List.OnElements( { @Size(max=30), @Size(max=40, groups=Admin.class) }) The drawback of this method is that: - it requires to change existing applications - it make creating a constraint pretty complex was (Author: emmanuel): Solution #4 add a new OnElements subannotation. This annotation should contain all the attribute of its mother constraint annotation. .List should probably contains this annotation too. <code> @NotNull @Size(max=30) @Size.OnElements(max=50) @Email.OnElements Collection<String> emails; </code> where public @interface Size { String message() default {...}; int min default 0; ... @interface OnElements { String message() default {...}; int min default 0; } @interface List { Size[] value(); @interface OnElements { Size[] value(); } } advanced example @Size.List.OnElements( { @Size(max=30), @Size(max=40, groups=Admin.class) }) The drawback of this method is that: - it requires to change existing applications - it make creating a constraint pretty complex -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard edited comment on BVAL-202 at 3/15/10 10:40 AM: ----------------------------------------------------------------- Solution #4 add a new OnElements subannotation. This annotation should contain all the attribute of its mother constraint annotation. .List should probably contains this annotation too. {code} @NotNull @Size(max=30) @Size.OnElements(max=50) @Email.OnElements Collection<String> emails; {code} where {code} public @interface Size { String message() default {...}; int min default 0; ... @interface OnElements { String message() default {...}; int min default 0; } @interface List { Size[] value(); @interface OnElements { Size[] value(); } } {code} advanced example {code} @Size.List.OnElements( { @Size(max=30), @Size(max=40, groups=Admin.class) }) {code} The drawback of this method is that: - it requires to change existing applications - it make creating a constraint pretty complex was (Author: emmanuel): Solution #4 add a new OnElements subannotation. This annotation should contain all the attribute of its mother constraint annotation. .List should probably contains this annotation too. [code] @NotNull @Size(max=30) @Size.OnElements(max=50) @Email.OnElements Collection<String> emails; [/code] where public @interface Size { String message() default {...}; int min default 0; ... @interface OnElements { String message() default {...}; int min default 0; } @interface List { Size[] value(); @interface OnElements { Size[] value(); } } advanced example @Size.List.OnElements( { @Size(max=30), @Size(max=40, groups=Admin.class) }) The drawback of this method is that: - it requires to change existing applications - it make creating a constraint pretty complex -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard edited comment on BVAL-202 at 3/15/10 10:40 AM: ----------------------------------------------------------------- Solution #3 Let constraints not defining a ConstraintValidator<Constraint, Iterable<?>> (or any of the Iterator subclasses) be applied on the collection elements. This works well as applying such a constraint today on a Iterable<?> raises a runtime exception. Use solution #1 or #2 for constraints that do declare a ConstraintValidator<Constraint, Iterable<?>> {code}@NotNull @Size(max=30) @Size(max=50, validElements=true) @Email Collection<String> emails;{code} was (Author: emmanuel): Solution #3 Let constraints not defining a ConstraintValidator<Constraint, Iterable<?>> (or any of the Iterator subclasses) be applied on the collection elements. This works well as applying such a constraint today on a Iterable<?> raises a runtime exception. Use solution #1 or #2 for constraints that do declare a ConstraintValidator<Constraint, Iterable<?>> @NotNull @Size(max=30) @Size(max=50, validElements=true) @Email Collection<String> emails; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard edited comment on BVAL-202 at 3/15/10 10:41 AM: ----------------------------------------------------------------- Use a specific group as a marker to define that a constraint should be applied on the elements {code} @NotNull @Size(max=30) @Size(max=50, groups=OnElements.class) @Email(groups=OnElements.class) Collection<String> emails;{code} @NotNull and @Size(30) are applied on the collection and @Size(50) and @Email are applied on the elements of the collection This solution reads extremely well but is kind of a hack of groups as this special group does not convey the semantic of groups. An alternative approach is to use Payloads {code} @NotNull @Size(max=30) @Size(max=50, payload=OnElements.class) @Email(payload=OnElements.class) Collection<String> emails;{code} but I am reluctant to use payload for some core behaviors of Bean Validation was (Author: emmanuel): Use a specific group as a marker to define that a constraint should be applied on the elements @NotNull @Size(max=30) @Size(max=50, groups=OnElements.class) @Email(groups=OnElements.class) Collection<String> emails; @NotNull and @Size(30) are applied on the collection and @Size(50) and @Email are applied on the elements of the collection This solution reads extremely well but is kind of a hack of groups as this special group does not convey the semantic of groups. An alternative approach is to use Payloads @NotNull @Size(max=30) @Size(max=50, payload=OnElements.class) @Email(payload=OnElements.class) Collection<String> emails; but I am reluctant to use payload for some core behaviors of Bean Validation -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Gunnar Morling commented on BVAL-202: ------------------------------------- Would #1 to #3 work at all that way? Can one have the same annotation multiple times at the same element? Doing so gives me the compiler error "duplicate annotation". The type-annotations approach seems interesting, will that be part of Java 7? JSR 308 is currently in state "inactive", though this shouldn't be a problem according to [FAQ: Is JSR 308 inactive?|http://groups.google.com/group/jsr308-discuss/browse_thread/thr...]. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Hardy Ferentschik commented on BVAL-202: ---------------------------------------- JSR 308 seems to be the best option. People can for now always add a custom constraint validator implementation for their usecases. 'Misusing' payload or groups seems wrong to me. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Sanne Grinovero commented on BVAL-202: -------------------------------------- Hi, I've no clue if it's implementable, but I think it looks nice, and it would be great to be able to reuse all existing annotations (or have to implement less code for new validators) : {code}@ValidateEach(@Email) Collection<String> emails; {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Gunnar Morling commented on BVAL-202: ------------------------------------- It would compile, if there was a dedicated @ValidateEach annotation for each constraint, as with @List today: {noformat} public @interface Size { String message() default "{javax.validation.constraints.Size.message}"; Class<?>[] groups() default {}; Class<? extends Payload>[] payload() default {}; int min() default 0; int max() default Integer.MAX_VALUE; @interface List { Size[] value(); } @interface ValidateEach { Size[] value(); } } {noformat} This would read pretty good as long as only one @ValidateEach is imported. Also list semantics are covered: {noformat} @NotNull @Size(max=30) @ValidateEach({@Size(max=30), @Size(max=40, groups=Admin.class) }) Collection<String> emails; {noformat} It reads slightly worse but still ok when multiple @ValidateEach are required: {noformat} @NotNull @Size(max=30) @Size.ValidateEach({@Size(max=30), @Size(max=40, groups=Admin.class) }) @Email.ValidateEach(@Email) Collection<String> emails; {noformat} So basically this is similar to #4 without having all attributes from the original constraint again in the sub-annotation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard commented on BVAL-202: --------------------------------------- Let's organize an IRC meetup to whoeever is interested and beat this subject to death. Something Thursday or Friday. Thursday 17:00 CET good for everyone? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Emmanuel Bernard commented on BVAL-202: --------------------------------------- Adding Sebastian Thomschke's proposal {code} Hi, I remember we had a discussion whether or not to allow the validation of a map's keys. And at the time being the decision was made to not support this. In OVal 1.40 I introduced a feature that gives users control on how a constraint should be applied. For example when you have a not-null constraint for a map field your use cases could be, the map's keys may not contain null, none of the map's value may null, or the map itself may not be null. In OVal you can do this: @NotNull private Map myMap; // the map and the values may not be null @NotNull(appliesTo = ConstraintTarget.CONTAINER) private Map myMap; // the map itself may not be null @NotNull(appliesTo = ConstraintTarget.VALUES) private Map myMap; // the values may not be null @NotNull(appliesTo = ConstraintTarget.KEYS) private Map myMap; // the keys may not be null @NotNull(appliesTo = {ConstraintTarget.CONTAINER,ConstraintTarget.KEYS,ConstraintTarget.VALUES}) private Map myMap; // the map itslef, keys and values may not be null This also works for Lists and Arrays...of course the option Container.KEYS is ignored there. Any thoughts? Regards, Seb {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] Gunnar Morling commented on BVAL-202: ------------------------------------- Post 1.1. IMO we should wait for JSR 308 instead of establishing some work-around which we couldn't remove easily later on. Generally I think the issue can be circumvented by using dedicated types (e.g. {{List<Email> mails}} instead of {{List<String> mails}}) which allows for a cascaded validation using {{@Valid}}. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-202?page=c... ] jason commented on BVAL-202: ---------------------------- JSR 308 does not seem to be helpful for array fields. But appliesTo/ConstraintTarget can do the job for arrays as well as primitive collections. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira