Change made so that temp tables need not to be deleted, they get deleted automatically in Sybase. -------------------------------------------------------------------------------------------------- Key: HHH-5558 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5558 Project: Hibernate Core Issue Type: Improvement Components: core Reporter: Strong Liu Assignee: Strong Liu Fix For: 3.6.0.CR1 > > Change made so that temp tables need not to be deleted, they get deleted > automatically in Sybase. > Hibernate does not isolate operations on temp tables in a separate transaction because: 1) "ddl in trans" is set (iirc, this is a requirement for hibernate to work properly) 2) (DatabaseMetaData.dataDefinitionCausesTransactionCommit() returns false). In other words, operations on temp tables are executed in the current transaction. Since other operations can be executed later in the same transaction, I though it was a good idea to manually drop the temp tables when they are no longer needed, instead of waiting for them to be cleaned up automatically on commit. If "ddl in trans" is no longer needed or if you think it is more correct to wait until the transaction is committed for temp table cleanup, then it should be OK to make this change to the dialect. <AJ> While I do this change I see some performance improvement and no regression in the tests (I ran around 2000 tests of testsuite). If you see the same in your testing it is worth doing. > > Sybase supports alias length upto 30 characters (more than 10 as it is > indicated) > As far as I know, there should be no problem making this update.

Change made so that temp tables need not to be deleted, they get deleted automatically in Sybase. -------------------------------------------------------------------------------------------------- Key: HHH-5558 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5558 Project: Hibernate Core Issue Type: Improvement Components: core Reporter: Strong Liu Assignee: Strong Liu > > Change made so that temp tables need not to be deleted, they get deleted > automatically in Sybase. > Hibernate does not isolate operations on temp tables in a separate transaction because: 1) "ddl in trans" is set (iirc, this is a requirement for hibernate to work properly) 2) (DatabaseMetaData.dataDefinitionCausesTransactionCommit() returns false). In other words, operations on temp tables are executed in the current transaction. Since other operations can be executed later in the same transaction, I though it was a good idea to manually drop the temp tables when they are no longer needed, instead of waiting for them to be cleaned up automatically on commit. If "ddl in trans" is no longer needed or if you think it is more correct to wait until the transaction is committed for temp table cleanup, then it should be OK to make this change to the dialect. <AJ> While I do this change I see some performance improvement and no regression in the tests (I ran around 2000 tests of testsuite). If you see the same in your testing it is worth doing. > > Sybase supports alias length upto 30 characters (more than 10 as it is > indicated) > As far as I know, there should be no problem making this update.