[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik commented on HV-90: ------------------------------------- i assume that's for supporting genric resolution in ConstraintValidator, right? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik updated HV-90: -------------------------------- Fix Version/s: 4.0.0.Alpha3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik reassigned HV-90: ----------------------------------- Assignee: Hardy Ferentschik -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Emmanuel Bernard commented on HV-90: ------------------------------------ Do we really want to add yet another jar to manage on Hibernate users for 12 classes? I was thinking of copying the classes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Emmanuel Bernard commented on HV-90: ------------------------------------ Is it harder for us? A little bit. Is it easier for users? yes. License is fine (ASL), you can repackage org.hibernate.validator.jtype -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik commented on HV-90: ------------------------------------- I had a quick look at the shading plugin. Not sure if I like the implications. If you want to include/shade the jtype dependency into the HV jar you still need to reference the dependency in the pom. This means that people using maven will automatically get the jtype dependency as well when they use HV. Unless, of course you mark the dependency as optional. This would prevent maven to pull jtype transitively. However, it would create of course the wrong impression since the dependency is of course not optional. Also, if you apply the relocation functionality to for example com.googlecode.jtype to org.hibernate.util.jtype the shade-plugin must apply some byte code modifications. I could image that that could cause problems during debugging. For me the share-plugin seems to be more for standalone applications and not so much for libraries like HV. I guess then I prefer to include the sources under org.hibernate.validator.util.jtype and manage any up-/downstream changes manually. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Mark Hobson commented on HV-90: ------------------------------- Also, note that you can create a shaded source jar too for debugging: http://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#create... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Mark Hobson commented on HV-90: ------------------------------- That's the idea, and that has been my experience of using it too. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Mark Hobson commented on HV-90: ------------------------------- Sure, I'm just sorting out the Maven release process under Google Code and aim to release 0.1.0 tomorrow. I'll let you know when it's there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik resolved HV-90. --------------------------------- Resolution: Fixed Thanks for the release, Mark. I added jtype support and use the shade plugin to include the classes into the main Validator jar file. As you said, this way you get the best of two worlds. I did not bother to relocate the jtype. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Hardy Ferentschik commented on HV-90: ------------------------------------- Good question. Maybe we should relocate after all. That would definitely solve the problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-90?page=com.... ] Mark Hobson commented on HV-90: ------------------------------- Good stuff :) Yes, it's probably wise to relocate JType to a subpackage to avoid version conflicts. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira