9:14 a.m.
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M)
is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:34 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Diego Pires Plentz updated HHH-2799:
------------------------------------
Component/s: metamodel
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Henri Tremblay commented on HHH-2799:
-------------------------------------
I'm using Hibernate 3.2.4-sp1 with Hibernate annotations 3.3.0-ga. With Oracle. I
think have the same issue. Let's consider:
@Column(scale = 4) public BigDecimal getRate() { return rate; }
or
@Column public BigDecimal getRate() { return rate; }
Both will generate a DB field like this: RATE numer(19,2)
In my case the "2" wasn't expected at all since the default scale for
@Column is 0.
I did some debugging and the issue comes from
1- Ejb3Column.java
if ( precision > 0 ) { //revelent precision
this.mappingColumn.setPrecision( precision );
this.mappingColumn.setScale( scale );
}
-> This keeps the default scale for a column which is "2", not zero. A
workaround is then to specify @Column(precision=19, scale=127) but not really nice.
2- SchemaExport always set scale and precision to what's in Column
(TypeNames.replace).
-> So you get number(19,2)
At least for Oracle, I think we should have some "null" value to allow no
precision and no scale.
But right now, having a 2 appearing is quite puzzling.
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Emmanuel Bernard commented on HHH-2799:
---------------------------------------
It does not really make sense to define scale without a precision, does it?
I think it does not, that's the reason for the if in the Ejb3Column :)
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:02 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Henri Tremblay commented on HHH-2799:
-------------------------------------
No, it does not. At least with Oracle. You can have only one of these:
Number
Number(p)
Number(p,s)
With a precision of 0, I would expect to have Number generated, not Number(19,2).
Then if the precision is specified but the scale is some null value (Integer.MAX_VALUE or
whatever), I would expect Number(p)
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Henri Tremblay commented on HHH-2799:
-------------------------------------
Hum... I'll comment my comment.
I just learned that typing Number create a floating point. That will bring me to think
that a it would be a bad thing to have a BigDecimal mapping to a floating point in the
database.
Putting 19 by default is a little surprising since the maximum for Oracle is 38 so one can
wonder where this value is coming from.
The 2 is also surprising since working in finance, for me 5 is the minimum default I would
use.
I fixed my issue typing everything with precision=38, scale=10 (19 with a scale of 10 is
too short).
So, I now one thing that disturbed me and one wish.
The 2 is still a bug from my point of view since the default in @Column is 0 according to
JPA. So I think the default should be respected or at least the 2 documented in hibernate
annotations' doc.
Then, what would be nice is to be able to set our own defaults for a given type.Right now,
that doesn't seem possible without overloading the dialect (and that might not be true
since I don't know if the scale and precision are used for something else than
database generation).
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Emmanuel Bernard commented on HHH-2799:
---------------------------------------
The spec says
int
precision
(Optional) The precision for a decimal (exact numeric) column. (Applies only if a decimal
column is used.)
0 (Value must be set by developer.)
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2799) Default Scale value doesn't right
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799?page=c...
]
Henri Tremblay commented on HHH-2799:
-------------------------------------
True. And read slowly, probably means that IT MUST be set be the developer otherwise the
DDL would be random and an exception would be thrown.
So I won't argue anymore. I just think adding comment in hibernate or hibernate
annotations' doc telling the default is (19, 2) isn't a complete lost of time.
That said, after reading this bug carefully, I can't see why setting only the
precision in @Column would lead to a scale of 2 since the default 0 should propagate in
the if:
if ( precision > 0 ) { //revelent precision
this.mappingColumn.setPrecision( precision );
this.mappingColumn.setScale( scale );
}
BTW, there's a typo in "revelent" (relevent) :-)
Default Scale value doesn't right
---------------------------------
Key: HHH-2799
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2799
Project: Hibernate3
Issue Type: Bug
Components: metamodel
Affects Versions: 3.2.0.ga
Environment: Name and version of the database you are using:MySQL 5.0.37
Reporter: Bliznets Roman
Original Estimate: 2 hours
Remaining Estimate: 2 hours
In my Mapping documents:
...
<property name="goodsNumeric" lazy="false" insert="true"
update="true" not-null="false" unique="false"
type="java.math.BigInteger">
<column not-null="false" unique="false"
name="`goodsnumeric`" precision="5"/>
</property>
...
From MySQL documentation
In standard SQL, the syntax DECIMAL(M) is equivalent to DECIMAL(M,0).
But In log and in database scale=2, it's have to be exactly 0.
Debug level Hibernate log excerpt:
12484 [main] DEBUG org.hibernate.tool.hbm2ddl.SchemaUpdate - create table
`goodsitembasetype` (e_id bigint not null auto_increment, e_version integer not null,
`goodsnumeric` numeric(5,2), `grossweightquantity` numeric(19,6), `netweightquantity`
numeric(19,6), `invoicedcost` numeric(16,2), `customscost` numeric(16,2),
`statisticalcost` numeric(16,2), primary key (e_id))
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6253
days inactive
6337
days old
hibernate-issues@lists.jboss.org
7 comments
4 participants
participants (4)
-
Bliznets Roman (JIRA) -
Diego Pires Plentz (JIRA)
-
Emmanuel Bernard (JIRA)
-
Henri Tremblay (JIRA)