[ http://opensource.atlassian.com/projects/hibernate/browse/HV-472?page=com... ] Hardy Ferentschik commented on HV-472: -------------------------------------- Moving the issue from BV to HV. The email constraints is not part of the Bean Validation specification, but a Hibernate Validator specific constraint. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-472?page=com... ] Tom Schindl commented on HV-472: -------------------------------- well should be quite easy to come up with one e.g. "myname(a)xn--stereich-m4a.at" should be a valid address given that http://www.nic.at/service/technische_informationen/idn/zeichentabelle_kon... allows ö in its domain names. The real problem I see is that which values are allowed in a domain name differs from top-level to top-level domain (not even german speaking countries came across a common set of chars allowed)! So probably the savest (though not 100% accurate assumption could be to allow all unicode letter chars in the domain name) so a regex which passes the above could look like this: private static String ATOM = "[a-z0-9!#$%&'*+/=?^_`{|}~-]"; private static String ATOM_DOMAIN = "[\\p{L}!#$%&'*+/=?^_`{|}~-]"; private static String DOMAIN = "(" + ATOM_DOMAIN + "+(\\."+ ATOM_DOMAIN + "+)*"; private static String IP_DOMAIN = "\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\]"; private java.util.regex.Pattern pattern = java.util.regex.Pattern.compile( "^" + ATOM + "+(\\." + ATOM + "+)*@" + DOMAIN + "|" + IP_DOMAIN + ")$", java.util.regex.Pattern.CASE_INSENSITIVE ); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-472?page=com... ] Hardy Ferentschik commented on HV-472: -------------------------------------- I think we can add an _idn_ parameter to the existing _@Email_ annotation which allows to configure the behavior. If _idn_ is set to _true_ we allow unicode characters. This way we don't change existing behavior unless you explicitly configure it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-472?page=com... ] Hardy Ferentschik edited comment on HV-472 at 12/5/11 5:29 AM: --------------------------------------------------------------- well should be quite easy to come up with one e.g. "myname(a)xn--stereich-m4a.at" should be a valid address given that http://www.nic.at/service/technische_informationen/idn/zeichentabelle_kon... allows ö in its domain names. The real problem I see is that which values are allowed in a domain name differs from top-level to top-level domain (not even german speaking countries came across a common set of chars allowed)! So probably the savest (though not 100% accurate assumption could be to allow all unicode letter chars in the domain name) so a regex which passes the above could look like this: {code} private static String ATOM = "[a-z0-9!#$%&'*+/=?^_`{|}~-]"; private static String ATOM_DOMAIN = "[\\p{L}!#$%&'*+/=?^_`{|}~-]"; private static String DOMAIN = "(" + ATOM_DOMAIN + "+(\\."+ ATOM_DOMAIN + "+)*"; private static String IP_DOMAIN = "\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\]"; private java.util.regex.Pattern pattern = java.util.regex.Pattern.compile( "^" + ATOM + "+(\\." + ATOM + "+)*@" + DOMAIN + "|" + IP_DOMAIN + ")$", java.util.regex.Pattern.CASE_INSENSITIVE ); {code} was (Author: tomsontom): well should be quite easy to come up with one e.g. "myname(a)xn--stereich-m4a.at" should be a valid address given that http://www.nic.at/service/technische_informationen/idn/zeichentabelle_kon... allows ö in its domain names. The real problem I see is that which values are allowed in a domain name differs from top-level to top-level domain (not even german speaking countries came across a common set of chars allowed)! So probably the savest (though not 100% accurate assumption could be to allow all unicode letter chars in the domain name) so a regex which passes the above could look like this: private static String ATOM = "[a-z0-9!#$%&'*+/=?^_`{|}~-]"; private static String ATOM_DOMAIN = "[\\p{L}!#$%&'*+/=?^_`{|}~-]"; private static String DOMAIN = "(" + ATOM_DOMAIN + "+(\\."+ ATOM_DOMAIN + "+)*"; private static String IP_DOMAIN = "\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\]"; private java.util.regex.Pattern pattern = java.util.regex.Pattern.compile( "^" + ATOM + "+(\\." + ATOM + "+)*@" + DOMAIN + "|" + IP_DOMAIN + ")$", java.util.regex.Pattern.CASE_INSENSITIVE ); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-472?page=com.atlassian.jira.plugin... ] Hardy Ferentschik edited comment on HV-472 at 2/2/12 4:43 AM: -------------------------------------------------------------- Actually we could also use _java.net.IDN_: {code} String asciiString = IDN.toASCII( value.toString() ); {code} But IDN is only available since Java 6 was (Author: hardy.ferentschik): Actually we could also use _java.net.IDN_: {code} String asciiString = IDN.toASCII( value.toString() ); {code} But IDN is only available since Java6 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-472?page=com.atlassian.jira.plugin... ] Hardy Ferentschik reassigned HV-472: ------------------------------------ Assignee: Hardy Ferentschik -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-472?page=com.atlassian.jira.plugin... ] Hardy Ferentschik updated HV-472: --------------------------------- Pull Requests: https://github.com/hibernate/hibernate-validator/pull/102 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira