[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3001?page=c... ] Maciej Baranowski commented on HHH-3001: ---------------------------------------- I have posted some JUnit tests and a comment with the patch to HHH-2928. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3001?page=c... ] Laszlo Sas commented on HHH-3001: --------------------------------- Dear developers, NoopOptimizer is not thread-safe. Marciej has right. The generate and getLastSourceValue methods must be synchronized. Only two words. :( I attach a test case. Could you fix it in the next version? Thanks, Laszlo -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3001?page=c... ] Laszlo Sas commented on HHH-3001: --------------------------------- By the way... I used version 3.5.3 and Postgresql. It threw Exceptions without the fix. :( Apply the fix and it runs perfectly. :) Laszlo -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3001?page=c... ] Steve Ebersole updated HHH-3001: -------------------------------- Summary: The NoopOptimizer is not thread safe (was: The NoopOptimizer needs to be synchronized) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3001?page=c... ] Steve Ebersole commented on HHH-3001: ------------------------------------- Laszlo, {code:title=snippet from Optimizer.java|borderStyle=solid} /** * A common means to access the last value obtained from the underlying * source. This is intended for testing purposes, since accessing the * underlying database source directly is much more difficult. * * @return The last value we obtained from the underlying source; * null indicates we have not yet consulted with the source. */ public IntegralDataTypeHolder getLastSourceValue(); {code} *This is intended for testing purposes, since accessing the underlying database source directly is much more difficult.* But yes, Maciej was correct. But the correct solution, imo and his, was making it a method-local variable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira