[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Theo Platt commented on HHH-2308: --------------------------------- Actually (for my purposes at least) there is a work around - and that's to use hibernate filters. If you enable a filter on a collection it will add it as an outer join predicate. Still - it might be neater to just add it to the criteria api rather than using filters - might get messy if you have more than one term to filter by ? Theo -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Daniel commented on HHH-2308: ----------------------------- Hey Sergey, i try to use your "patch" for creating a LEFT JOIN statement between unrelated and unmapped classes. But - myybe i didn't find the right code in your example - i am really confident that your patch als oworks only with mapped classes. Is there any other way to do a different JOINS between unmapped classes? Greetings from Germany Daniel -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Sergey Pulyaev updated HHH-2308: -------------------------------- Attachment: hibernate-joinOn-sorted.ZIP I found that joins are sorted by their hirarchy - so i have added sorter for parameters.... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Scott Van Wart commented on HHH-2308: ------------------------------------- Theo, With the criteria API it seems to add it to the WHERE clause instead, which is no good, because then left outer joining is useless. Consider this (SQL, you sound like you probably already know all about this, but I'll include it for the sake of clarity :) ): SELECT p.name, c.name FROM parent p LEFT JOIN child c ON p.parentId = c.parentId AND c.gender = 'M'; This will return ALL parent names. It will also return all male child names, or NULL if the parents don't have any male children. SELECT p.name, c.name FROM parent p LEFT JOIN child c ON p.parentId = c.parentId WHERE c.gender = 'M'; All we've done is moved the predicate to the WHERE clause, but this will exclude all parents who only have female children. In my case the results are 2000 rows with the extra join predicate versus a few hundred thousand if I have to filter after retrieval. No good :(. Patch time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Scott Van Wart updated HHH-2308: -------------------------------- Attachment: hibernate-3.3.2.GA-createAlias_withClause.patch Adds a new method createAlias to the criteria API accepting a Criterion of arbitrary clauses. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Adam Ringel commented on HHH-2308: ---------------------------------- Are there any plans to implement the new createAlias method with the extraJoinClauses parameter in an official release? This is a highly valuable addition to the Criteria API. I have used the Filter work around but I find it rather clunky. Plus I don't want to have a filter enabled in a session when it is possible that another query in that session could be invoked that doesn't want that filter!! I tried doing a disable followed by a session flush but it didn't seem to work: crit.list(); //doesn't work, have to live with filter being live in this session session.flush(); session.disableFilter("ackFilter"); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Craig Christophel updated HHH-2308: ----------------------------------- Attachment: hibernate-outer-join-criteria-trunk.diff Updated the patch to work against 3.5 (trunk). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Steve Ebersole updated HHH-2308: -------------------------------- Summary: Adding predicates to the join condition using Criteria Query (was: Adjusting the Outer Join Predicate using Criteria Query) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Steve Ebersole updated HHH-2308: -------------------------------- Comment: was deleted (was: This patch adds both of the following new methods to Criteria: {code} /** * Join an association using the specified join-type, assigning an alias * to the joined association. * <p/> * The joinType is expected to be one of {@link #INNER_JOIN} (the default), * {@link #FULL_JOIN}, or {@link #LEFT_JOIN}. * * @param associationPath A dot-seperated property path * @param alias The alias to assign to the joined association (for later reference). * @param joinType The type of join to use. * @param withClause The criteria to be added to the join condition (<tt>ON</tt> clause) * * @return this (for method chaining) * * @throws HibernateException Indicates a problem creating the sub criteria */ public Criteria createAlias(String associationPath, String alias, int joinType, Criterion withClause) throws HibernateException; /** * Create a new <tt>Criteria</tt>, "rooted" at the associated entity, * assigning the given alias and using the specified join type. * * @param associationPath A dot-seperated property path * @param alias The alias to assign to the joined association (for later reference). * @param joinType The type of join to use. * @param withClause The criteria to be added to the join condition (<tt>ON</tt> clause) * * @return the created "sub criteria" * * @throws HibernateException Indicates a problem creating the sub criteria */ public Criteria createCriteria(String associationPath, String alias, int joinType, Criterion withClause) throws HibernateException; {code}) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Steve Ebersole closed HHH-2308. ------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Sergey Pulyaev commented on HHH-2308: ------------------------------------- Is it possible to add methods like addWithClause into Criteria? We use some logic to create required path of subcriterias - so we need first to create criteria, and then - to add restrictions... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Sergey Pulyaev commented on HHH-2308: ------------------------------------- Bad - this patch is useless for me :-( I have to use my own implementation of this... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2308?page=c... ] Chris Wilson commented on HHH-2308: ----------------------------------- If you need this support in a stable release (3.3.2GA) you can use [our RitaCriteriaQuery class|http://rita.wfplogistics.org/trac/browser/rita/src/org/wfp/rita/db/...]: {code} Criteria rl = session.createCriteria(RequestLine.class); RitaCriteriaQuery rcq = new RitaCriteriaQuery(rl, m_Facade); ... Criteria mo = session.createCriteria(rl, "movementsIn", "mo", JoinFragment.INNER_JOIN); rcq.setJoinRestriction(mo, Restrictions.eq("ownerCode", Movement.OwnerCode.O)); ... List<RequestLine.Id> ids = rcq.list(); {code} You'll probably want to change the RitaCriteriaQuery constructor to take a Session and a SessionFactory instead of a DataFacade (which is our Session wrapper). See [our RequestDao class|http://rita.wfplogistics.org/trac/browser/rita/src/org/wfp/rita/dat...] for more details and sample code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira