[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Steve Ebersole updated HHH-4812: -------------------------------- Fix Version/s: (was: 3.5.0-CR-2) 3.5.x -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Steve Ebersole updated HHH-4812: -------------------------------- Fix Version/s: (was: 3.5.0-CR-2) 3.5.0-CR-3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Hardy Ferentschik commented on HHH-4812: ---------------------------------------- Ok, this are the new annotation I think we have to add for this: {code} @Target({ ElementType.TYPE, ElementType.PACKAGE }) @Retention(RetentionPolicy.RUNTIME) public @interface FetchProfile { String name(); @Target({ ElementType.TYPE, ElementType.PACKAGE }) @Retention(RUNTIME) @interface FetchOverride { Class<?>[] entity(); String association(); FetchMode mode(); } } {code} and {code} @Target({ METHOD, FIELD }) @Retention(RUNTIME) public @interface FetchProfiles { public abstract FetchProfile[] profiles(); } {code} I don't like the name {{FetchOverride}} so much, but {{@Fetch}} already exists independently to the fetch profile feature (in order to define the fetch type on field/method level). Not sure whether there is a better name. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Hardy Ferentschik commented on HHH-4812: ---------------------------------------- To have entity as an array was a typo. So here is how it looks like now: {code} @Target({ ElementType.TYPE, ElementType.PACKAGE }) @Retention(RetentionPolicy.RUNTIME) public @interface FetchProfile { String name(); FetchOverride[] fetchOverrides(); @Target({ ElementType.TYPE, ElementType.PACKAGE }) @Retention(RUNTIME) @interface FetchOverride { Class<?> entity(); String association(); FetchMode mode(); } } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Emmanuel Bernard commented on HHH-4812: --------------------------------------- interesting question. It would be nice to favor XML over annotations for the same fetch profile. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Hardy Ferentschik commented on HHH-4812: ---------------------------------------- Well, in JPA there are clear rules about configuration overrides via xml, but in this case we are talking about JPA mapping files. In this case we are talking about Hibernate mapping files and I am not sure whether we considered overriding there. I don't think so. What's for example with named queries defined in annotations and hbm mapping files? I don't think we consider overriding there. I think we should stick to what we currently do. If we want to have overriding it should be implemented consistently which is another issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812?page=c... ] Hardy Ferentschik resolved HHH-4812. ------------------------------------ Resolution: Fixed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira