[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-524?page=co... ] Marcio Carvalho commented on HBX-524: ------------------------------------- Ok Max. I really implemented the aforementioned PK-FK LAW #2, which is the standard way to express one-to-one relations here in my job. I've just changed the JDBCBinder class. Here are my changes: 1- method bindIncomingForeignKeys(): I inserted another condition asking if the current FK is a OneToOne relation. In case it is, I call the new method bindOneToOne() which is similar to bindOneToMany(). 2- method isOneToOne(ForeignKey fk): I created this method to check whether the referred fk represents a OneToOne relation according to the PK-FK Law #2. protected boolean isOneToOne(ForeignKey foreignKey) { List fkColumns = foreignKey.getColumns(); List pkForeignTableColumns = null; if (foreignKey.getTable().hasPrimaryKey()) pkForeignTableColumns = foreignKey.getTable().getPrimaryKey().getColumns(); boolean equals = fkColumns != null && pkForeignTableColumns != null && fkColumns.size() == pkForeignTableColumns.size(); Iterator columns = foreignKey.getColumnIterator(); while (equals && columns.hasNext()) { Column fkColumn = (Column) columns.next(); equals = equals && pkForeignTableColumns.contains(fkColumn); } return equals; } 3- method bindOneToOne(): I created this method to actually compose the Property which has an org.hibernate.mapping.OneToOne value. It mostly resembles the bindOneToMany method. private Property bindOneToOne(PersistentClass rc, Table table, ForeignKey fk, Set processedColumns) { OneToOne value = new OneToOne(table, rc); value.setReferencedEntityName(revengStrategy .tableToClassName(TableIdentifier.create(table))); boolean isUnique = isUniqueReference(fk); String propertyName = revengStrategy.foreignKeyToEntityName(fk.getName(), TableIdentifier.create(fk.getReferencedTable()), fk .getReferencedColumns(), TableIdentifier .create(table), fk.getColumns(), isUnique); Iterator columns = fk.getColumnIterator(); while (columns.hasNext()) { Column fkcolumn = (Column) columns.next(); checkColumn(fkcolumn); value.addColumn(fkcolumn); processedColumns.add(fkcolumn); } value.setFetchMode(FetchMode.SELECT); return makeProperty(TableIdentifier.create(table), propertyName, value, true, true, value.getFetchMode() != FetchMode.JOIN, null, null); } This are mostly the changes I made to recognize One-To-One relationships. To express this situation in my pojos, I 've put the correct annotations in my pojo templates. Hope this helps. Cheers, Marcio -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira