[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] John Aylward commented on HHH-2603: ----------------------------------- Could you add in some documentation for what we could use instead of connection()? If the option to not use hibernate to grab an unmanaged connection is the correct way, it should be documented in the deprecation notes. The API docs need to be updated on documents section of the hibernate.org website to reflect the deprecated methods -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Glen K. Peterson commented on HHH-2603: --------------------------------------- Did you deprecate the method before providing an alternative or is there an alternative you just aren't telling people about? Since I require "no errors, no warnings" in all my compiles, it distresses me that after downloading Hibernate Core 3.2.5.ga, I now have 3 warnings over this deprecated method. I guess I'll have to switch back to an older version until this is fixed with documentation or by undoing the deprecation warning. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Glen K. Peterson commented on HHH-2603: --------------------------------------- That's the nicest thing anyone's said to me all day! When the @deprecated tag is used in JavaDocs, there is usually a comment that suggests a working alternative. This deprecation warning is unusual because the accompanying comment suggests an alternative that does not seem to exist yet. What am I missing? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Mark Reynolds commented on HHH-2603: ------------------------------------ Deprecation is for cases where an alternate API has been provided and use of the old one is now discouraged and/or planned for removal. It is unusual and confusing to deprecate a method for which there is no current alternative. If you prefer to disparage those who are thusly confused rather than simply remove the premature deprecation, so be it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Glen K. Peterson commented on HHH-2603: --------------------------------------- I recommend that you list the dangers of using Session.connection() in the JavaDocs for that method and update any other documentation accordingly. The JavaDocs are the first place I would look for that type of information and it's also where I would most likely find it by accident. I still think it's premature to mark it deprecated. Deprecating a method means that "you should no longer use it, since it has been superseded and may cease to exist in the future." Source: http://java.sun.com/j2se/1.5.0/docs/guide/javadoc/deprecation/deprecation... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Landon Fuller commented on HHH-2603: ------------------------------------ Was the result of this discussion that: - Developers should assume that in a future release, it will not be possible to retrieve a JDBC Connection object at all? or - An API to retrieve the connection will be available in some other form? The current JavaDoc notice is unclear on that point. If there will be an alternative API to access a JDBC Connection, then I'm inclined to attach a comment and @SupressWarnings attribute to my single use of connection(), and replace the usage when the build breaks. If the API is going away entirely, and access to an underlying JDBC connection will not be available, then I need to write an alternative implementation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Hontvári József commented on HHH-2603: -------------------------------------- Yes, deprecation doesn't mean that there is an alternative API, but that is not a problem here. There are two kind of deprecation: 1) something was wrong and cannot be fixed therefore no alternative method is provided. Like Thread.stop. In the deprecation comment Sun provides a very detailed problem description so you can understand the consequences and risks of the (continued) usage of the method. 2) something is wrong or not optimal and it WAS replaced by something better. Like getenv, Sun recommended the system properties in the deprecation comment. I believe in this case the deprecation was either used for an inapproprate purpose (roadmap?) and/or the deprecation comment is missing. I really appreciate Hibernate developers, but I think in this case you don't understand that during maintenance deprecated class/method usage requires attention, it may indicate real problems and it means tasks to do, and you treated this problem a bit too lightly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Justin Levis commented on HHH-2603: ----------------------------------- I need to get access to the current connection so I can display the connection URL in my application. That's it, simple. That doesn't exactly sound like "do JDBC work", but I am after JDBC information. In this case, I'm just using it as a visual confirmation that the users are running the correct application and it's connecting to the correct database, etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Glen K. Peterson commented on HHH-2603: --------------------------------------- Thank you very much, Steve. This is just what I needed. I apologize for my haughty tone earlier. For the record, I also tried an earlier suggestion: hibernateConfig.buildSettings().getConnectionProvider().getConnection(); and got: FATAL org.hibernate.connection.ProxoolConnectionProvider::configure(150): Proxool Provider unable to load load Property configurator file: proxool.properties org.logicalcobwebs.proxool.ProxoolException: Attempt to register duplicate pool called 'pool1' So Steve's suggestion appears to be the best solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Steve Ebersole commented on HHH-2603: ------------------------------------- Dilip, currently you do something akin to: doSomeLegacyJunk( session.getConnection() ); why on God's green earth does everyone think it is so inconceivable to instead do: session.doWork( new Work() { public void execute(Connection connection) throws SQLException { doSomeLegacyJunk( connection ); } } ); ??? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Steve Ebersole commented on HHH-2603: ------------------------------------- Shawn, I am responding specifically to the questions that keep cropping up on this specific issue which invariable seem to discuss exactly this type of usage. Its been discussed (and I thought you were involved in some of them) that yes there still needs to be an API for obtaining a 'child session' (specifically one utilizing the same JDBC connection). This will happen before 4.0. The rub, to me, is the already large number of overloaded SF.openSession() methods we have; that needs to be considered carefully. But honestly I have not had time to think through the details of it; feel free to put some thought into it and start a discussion on the dev list. (BTW Session.getSession(EntityMode) has a totally different purpose/intent) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Dilip Dalton commented on HHH-2603: ----------------------------------- Steve, thanks for describing the work API. We can use this work API, but it will involve a bigger refactoring work compared to obtaining the JDBC connection object. Given how stable and mature the code has been, it is highly likely that we will never do this refactoring on the legacy code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2603?page=c... ] Paul Benedict commented on HHH-2603: ------------------------------------ Ana, see HHH-2859 for the alternative. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira