Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjk1NTI0MTUx... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16972?atlOrigin=eyJpIjoiNjk1NT... ) HHH-16972 ( https://hibernate.atlassian.net/browse/HHH-16972?atlOrigin=eyJpIjoiNjk1NT... ) references to SQM types from org.hibernate.metamodel.model.domain ( https://hibernate.atlassian.net/browse/HHH-16972?atlOrigin=eyJpIjoiNjk1NT... ) Issue Type: Improvement Assignee: Unassigned Components: hibernate-core Created: 21/Jul/2023 11:37 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) There are 17 references to types in the package org.hibernate.query.sqm from the package org.hibernate.metamodel.model.domain. In my opinion, these are layer-breakers. The reason I make this claim is that org.hibernate.metamodel.model.domain lives in the same layer as org.hibernate.query.criteria , and is referenced from types in that package. But org.hibernate.query.criteria is some sort of abstraction over org.hibernate.query.sqm. We shouldn’t be able to navigate to types in the “lower” layer by following getters within the “higher” layer. This package is still marked @Incubating , so it’s not too later to fix this. Related to https://hibernate.atlassian.net/browse/HHH-16866. ( https://hibernate.atlassian.net/browse/HHH-16972#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16972#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=Em... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:4329f54 )