[Hibernate-JIRA] Created: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[Hibernate-JIRA] Created:...

Max Rydahl Andersen (JIRA)

Wednesday, 18 April 2007 Wed, 18 Apr '07

3:11 a.m.

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate3 Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Thomas Masutti (JIRA)

Saturday, 21 June Sat, 21 Jun

7 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Thomas Masutti commented on HHH-2576: ------------------------------------- would help a lot otherwise we have to place to queries in the java code since we're using the schema to switch between test and productive environment.

...

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

Thomas Masutti (JIRA)

Wednesday, 20 August Wed, 20 Aug

4:32 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Thomas Masutti commented on HHH-2576: ------------------------------------- The workaround is to use an Interceptor and replace the placeholder.

...

Neil Redway (JIRA)

Thursday, 4 June Thu, 4 Jun

3:50 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Neil Redway commented on HHH-2576: ---------------------------------- I can do the following and get the schema name that is used by the persistence unit. I then simply add this schema to the beginning of the tables in my native query. private static String SCHEMA; static { Ejb3Configuration configure = new Ejb3Configuration(); configure.configure("sims",new HashMap()); configure.buildSettings(); SCHEMA = (String)configure.getProperties().get("hibernate.default_schema"); };

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Tuesday, 6 October Tue, 6 Oct

1:04 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I don't see any compatibility issue implementing this. The native SQL processor already handles a slew of placeholders (http://docs.jboss.org/hibernate/core/3.3/reference/en/html/querysql.html see table 16.1). If a new alias was introduced like {default_schema}, the issue would be solved.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Tuesday, 13 October Tue, 13 Oct

8:57 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ For the above example, the dot can't be hard-coded because if there is no default schema, then the SQL is invalid. Rather, it should be: <sql-query name="queryName"> select * from ${default_schema}CUSTOMER x where ... </sql-query>

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Thursday, 15 October Thu, 15 Oct

11:01 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I wrote a patch and will upload it soon. This is how I have approached the issue, and am sharing my philosophy early to receive any feedback. All Hibernate properties will become available to SQL parsing. They are under the alias "hibernate" such as: SELECT * FROM {hibernate.default_schema}.table SELECT * FROM table FETCH FIRST {hibernate.default_batch_fetch_size} ROWS ONLY I gave two special considerations "hibernate.default_schema" and "hibernate.default_catalog". If these property names actually end in a dot, I include the dot at the end, which will facilitate allowing fully-qualified objects being optional if these properties are not specified. This requires a default schema otherwise the SQL is invalid: SELECT * FROM {hibernate.default_schema}.table This allows the schema to be totally optional: SELECT * FROM {hibernate.default_schema.}table

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

2:04 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- I would like to chime in about something else I plan on adding because it impacts here. Eventually I'd like to be able to allow native-sql queries to use the function registry. Also I'd like to see an explicit alias notation. The reason I bring these up is that they all use {} as delimiters. We need to consider adding some form of distinction to these so that we know what is being referenced. For example, for functions I had considered {fn: } as distinct delimiter; so {fn:current_timestamp} for example. Paul, I really like everything else you planned.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

3:49 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ As you probably already know, JDBC uses {} for escape sequences, and fn is already in use (without the colon). My references are: * http://download.oracle.com/docs/cd/E13222_01/wls/docs91/jdbc_drivers/sqle... * http://java.sun.com/developer/onlineTraining/Programming/JDCBook/jdbc.html Can you entertain using the colon as protocol separator (like JDBC)? The first part would always begin with "hibernate:" as such: SELECT * FROM {hibernate:property:hibernate.default_schema}.table WHERE col = {hibernate:fn:current_timestamp}

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Saturday, 17 October Sat, 17 Oct

8:10 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ Nix the previous idea. Using a colon requires a change to the parameter parser since the token starts a named parameter. It's probably not worth the effort to make a change there. Maybe this is better: SELECT * FROM {property hibernate.default_schema}.table Steve, what is the "function registry"? You mean of the dialect? I'd like to hear more about this.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Sunday, 18 October Sun, 18 Oct

1:48 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict updated HHH-2576: ------------------------------- Attachment: HHH-2576-01.patch Attached is my first patch for this issue. I tested against 3.3.x just fine. * Unlike previously stated, not all Hibernate properties are available (only hibernate.default_schema and hibernate.default_catalog) and that is because session factories do not keep a reference to their configuration properties. This limitation is explicitly stated in o.h.cfg.Environment, but perhaps the design decision should be rethought? If it proves a good idea to expose any property in SQL (and perhaps HQL too?), then I think the limitation should definitely be lifted. * Steve, thanks for making me aware of SQLFunctionRegistry. I see its association in SessionFactoryImplementor. Can you please explain how you would want to integrate it? If we can, as you said, come up with a unified substitution notation for hibernate-specific values, I can attempt to integrate the two.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

Monday, 19 October Mon, 19 Oct

8:22 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Yes I am aware of the JDBC escape syntax. As for keeping references to the properties, the main argument against keeping them is that it would send the wrong implication wrt changing the values. I first started considering this whole idea in regards to mapping fragments, specifically in <formula/> mappings. I'm fine to entertain other delimiters. I just went with {fn: } for (1) succinctness, (2) naturalness and (3) familiarity.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

9:49 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ Can you jot out what you wanted to do with {fn:} and SQLFunctionRegistry? Were you trying to gain meta-like SQL to be database independent based on what methods and syntax are available?

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

Tuesday, 20 October Tue, 20 Oct

2:02 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Hey Paul, well like I said this originally grew from a desire to add this to metadata fragments. For example, currently a user might say something like: <formula>crypt(my_password_column)</formula> Or even better imagine this with HHH-4440: <column name="my_password_column" read="decrypt(my_password_column)" write="crypt(?)/> Now here the user is restricted to running this mapping on databases which support functions named crypt and decrypt. If instead these function names could be resolved against the SQLFunctionRegistry, ThatWouldBeGoodness. So that is one basic impetus here. These are pretty straight forward examples. Not much potential ambiguity in terms of parsing and interpreting what the user intended (the parentheses are a great disambiguate-er). Stupid example, but consider: <formula>current_timestamp</formula> Do we need to qualify this (pre-pend the alias)? The problem is that here we have syntactic ambiguity. The only way to alleviate this ambiguity is semantically: what does "current_timestamp" *mean*? However, this form is syntactically non-ambiguous: <formula>{fn: current_timestamp}</formula> This syntactic ambiguity issue is another impetus. That is where all this got started. And we have not even discussed more complicated formula mappings yet where both of these come into play... Anyway, I just saw potential synergy there with this discussion.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Saturday, 24 October Sat, 24 Oct

12:18 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------

...

> I'm fine to entertain other delimiters. I just went with {fn: }...

Two issues arise: 1) The use of the colon requires mods to the parameter parser. 2) {fn} is already in use as a JDBC escape syntax. I would suggest {hibernate-fn xxx} for a function and {hibernate-prop xxx} for a key: INSERT INTO {hibernate-prop hibernate.default_schema.}table (ts) VALUES ({hibernate-fn current_timestamp})

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

Sunday, 25 October Sun, 25 Oct

12:37 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- I am fine with re-working the parameter parser. Actually I hope it goes away at point. I guess I can see {fn:} perhaps being too close to {fn} and being easily mistaken. But, I also do not like {hibernate-fn} nor {hibernate-prop}... way too verbose. {hib-fn } and {hib-prop }? {h-fn } and {h-prop }? Another thought for props... Do we really need unrestricted access to *all* properties? If just schema and catalog, you can make this very very concise as {schema} and {catalog}. [insert into {schema}my_table ...] Anyway, maybe we just need to determine what properties make sense and explicitly account for them.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

7:53 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ Yes, I am of the same thought that {hibernate-fn} is way too verbose. I will run with {h-fn/prop} until it is decided to be too concise :-) As for needing "unrestricted access to all properties", my answer is maybe. As the first patch shows, only schema and catalog have explicit handling currently, but I see great potential if any property was accessible. Even if hibernate.xxx are not the most interesting properties, opening the door for developers to incorporate application specific properties seem pretty useful. How about this: 1) {h-schema} and {h-schema.} for unqualified and qualified schema replacement 2) {h-catalog} for catalog replacement (do we need qualified access?) 3) {h-prop xxx} for a property 4) {h-fn xxx} for a function

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Max Rydahl Andersen (JIRA)

Tuesday, 3 November Tue, 3 Nov

10:11 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Max Rydahl Andersen commented on HHH-2576: ------------------------------------------ Nice to see progress on this one (me being lazy not doing it sooner ;) I tend to agree with Steve on not seeing the need for free access to hibernate properties. Sure, it could be "cool" to do - but it also just seem to be a very wide and open door risking all kind of issues depending on what the values actually are; accidentally sql injection etc. Without a good use case I see more danger in that than value. Access to functions sound good, but not sure a basic {h-fn xxx} is enough - doesn't it need to receive parameters to expand/work correctly ? Leaving the initial feature last, then {h-catalog.} is needed too; or at least some {h-catalog-schema.} option that would generate the fully qualified name needed databases that need both.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

12:17 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ In regards to SQL injection, I concur. When I was writing above, I neglected to mention that all properties could be exposed through an HQL function to make them legitimate values. Otherwise, the only injection possible is through {h-schema/catalog}. Although not explicitly stated, I thought {h-fn xxx} would use tuple syntax just like any other function?

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Max Rydahl Andersen (JIRA)

Wednesday, 4 November Wed, 4 Nov

3:23 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Max Rydahl Andersen commented on HHH-2576: ------------------------------------------ "Although not explicitly stated, I thought {h-fn xxx} would use tuple syntax just like any other function?" You mean like {h-fn concat(x,y,z)} ? If yes, then sure, but then you really need to update the parser much more. Right now we do nothing for picking out such values in the native query afaik.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

9:47 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Sure the parser is going to need significant rework to support this. Also consider something like: {h-fn abc( { h-fn xyc(?) }, ? )}

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Friday, 6 November Fri, 6 Nov

12:24 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict updated HHH-2576: ------------------------------- Attachment: HHH-2576-R2.patch Please review the updated patch. (PS: Evidently Hibernate uses tabs for indentation -- grr -- and this path doesn't respect that yet)

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

11:36 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- WTF Paul?!?! No tabs?!?! Geesh :) Seriously, what did you see as not yet implemented or accounted for? I am fighting through LVM learning curves at the moment. I'll apply patch/review after i get some space :(

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

11:56 a.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I reserved h- for any further extensions of Hibernate; thus throwing an error. Probably to be implemented in another ticket would be {h-fn xxx}

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

Wednesday, 11 November Wed, 11 Nov

1:30 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Paul, which branch did you diff this against? I tried applying to trunk, but no-go..

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

1:30 p.m.

New subject: [Hibernate-JIRA] Assigned: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole reassigned HHH-2576: ----------------------------------- Assignee: Steve Ebersole

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

1:32 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole updated HHH-2576: -------------------------------- Fix Version/s: 3.5

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

2:42 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I wrote it against 3.3

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

3:10 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- And you used svn diff? I tried applying it against 3.3 as well. Still no luck

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Thursday, 12 November Thu, 12 Nov

12:11 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

12:28 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- If you are offering :) Yes, I will need to apply this to trunk/3.2 as well.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

12:38 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I thought I just saw you say you aren't planning anymore 3.2 releases!

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

12:48 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- that is true. I only work 2 major releases at a time. Anything more is unmanageable

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

12:50 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- ohhhh, sorry... trunk/3.5 :)

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Friday, 13 November Fri, 13 Nov

7:51 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict updated HHH-2576: ------------------------------- Attachment: HHH-2576-R3.patch This patch was made against: https://anonsvn.jboss.org/repos/hibernate/core/branches/Branch_3_3/core Since no changes ought to have yet effected the same files in 3.5, it should be able to be applied to trunk as well. This patch also respects your tab-only policy.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

Thursday, 19 November Thu, 19 Nov

11:36 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Out of curiosity, what do y'all think about a {h-domain.} as well? I took the term "domain" from what ANSI SQL calls a "domain name" which is an object's name qualified with schema/catalog information (its name within that "domain"). The idea being what the original description calls ${catalogschema}. Also, do we really need qualified/unqualified? What is the use case for using these for something other than to qualify a database object name?

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

11:49 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ I give my +1 on the {h-domain} idea. Personally, I have no use for the unqualified feature, but I didn't want to preclude it when designing a general purpose facility. If you want to always include the dot, fine by me -- probably makes SQL injection safer :-)

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

Friday, 20 November Fri, 20 Nov

1:51 a.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict updated HHH-2576: ------------------------------- Attachment: HHH-2576-R4.patch Attached is an updated patch with {h-domain}. One thing of note, you'll see some duplicated code to generate the catalog/schema combination, but that was intentional. I could have refactored into a private method, but because SQL replacement should be speedy -- and these replacements are likely to appear (often) whenever a table is specified -- I chose not to incur additional method invocations. Steve, could you also add a Fix Version of 3.3? I would like to use it earlier in my day job :-)

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

1:39 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole commented on HHH-2576: ------------------------------------- Paul you're patches still have spaces instead of tabs. That appears to be the reason I cannot apply them.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

1:45 p.m.

New subject: [Hibernate-JIRA] Commented: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict commented on HHH-2576: ------------------------------------ Okay, I know what is going on. I have tabs in the source files, but when I copy my diff to the clipboard and paste into TextPad, my tabs are converted. Sorry I didn't realize this earlier. I will submit anew tonight.

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

2:22 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole updated HHH-2576: -------------------------------- Fix Version/s: 3.3.x

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Paul Benedict (JIRA)

6:30 p.m.

New subject: [Hibernate-JIRA] Updated: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Paul Benedict updated HHH-2576: ------------------------------- Attachment: HHH-2576-R5.patch

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.3.x, 3.5 Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch, HHH-2576-R5.patch we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

Steve Ebersole (JIRA)

8:02 p.m.

New subject: [Hibernate-JIRA] Closed: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576?page=c... ] Steve Ebersole closed HHH-2576. ------------------------------- Resolution: Fixed

...

Allow native-sql to have placeholders for default schema and catalog -------------------------------------------------------------------- Key: HHH-2576 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2576 Project: Hibernate Core Issue Type: Improvement Components: query-sql Affects Versions: 3.2.3 Reporter: Max Rydahl Andersen Assignee: Steve Ebersole Fix For: 3.5, 3.3.x Attachments: HHH-2576-01.patch, HHH-2576-R2.patch, HHH-2576-R3.patch, HHH-2576-R4.patch, HHH-2576-R5.patch Time Spent: 1 hour, 31 minutes Remaining Estimate: 0 minutes we shold consider allowing something like: <sql-query name="queryName" callable="true"> { call ${default_schema}.storedProcName() } </sql-query> similar for normal SQL queries too. <sql-query name="queryName"> select * from ${default_schema}.CUSTOMER x where ... </sql-query> Maybe ${catalogschema} should be allowed to which would be the full prefix needed dependent on the dialect and would free one from having both catalog and schema + poper seperators in there.

5514

days inactive

6462

days old

hibernate-issues@lists.jboss.org

Manage subscription

42 comments

5 participants

tags (0)

participants (5)

Max Rydahl Andersen (JIRA)
Neil Redway (JIRA)
Paul Benedict (JIRA)
Steve Ebersole (JIRA)
Thomas Masutti (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[Hibernate-JIRA] Created: (HHH-2576) Allow native-sql to have placeholders for default schema and catalog