[
http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-47?page...
]
Tomislav Nad commented on HSHARDS-47:
-------------------------------------
I just started to take a look, so just some quick comments:
- could you make the patch against head version
- 2 tests are failing (in ModelCriteriaPermutedIntegrationTest)
- it would be nice to have tests for new functionality
A set of changes applied to the project
---------------------------------------
Key: HSHARDS-47
URL:
http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-47
Project: Hibernate Shards
Issue Type: Patch
Affects Versions: 3.0.0.Beta2
Reporter: Aviad Lichtenstadt
Assignee: Max Ross
Attachments: AllSourceChanges.txt
org/hibernate/shards/Shard.java:
* Support for executeUpdate - straight forward, just execute on all shards
org/hibernate/shards/session/ShardedSessionImpl.java
* Change implementation of is open (discussed already with Max
* Add support for SQLQuery in the Shard object, at this time only the implementation
that is identical to the regular hql Query
org/hibernate/shards/criteria/ShardedCriteriaImpl.java
* Support for PropertyProjection
* Correct support for AggregateProjection (max, min) so they will be done in the
database
org/hibernate/shards/criteria/AggregateProjectionEvent.java
* An event so the projection can be done in the database.
org/hibernate/shards/criteria/ExitOperationsCriteriaCollector.java
* Correct compilation of results for PropertyProjection including ordering with property
projection which is a special case
org/hibernate/shards/criteria/GeneralProjectionEvent.java
* A general Projection event needed for lazily adding the property projection (specially
for cases were there are also ordering in the criteria)
org/hibernate/shards/criteria/CountProjectionEvent.java
* A count projection event (including distinct count, so the count will be in the
database) and the collector will only need to collect the numbers
org/hibernate/shards/strategy/exit/AggregateExitOperation.java
* add correct support for max and min
* add support for count
* add support for distinct count
org/hibernate/shards/strategy/exit/OrderExitOperation.java
* Make utility method public so can be used in other classes
org/hibernate/shards/strategy/exit/PropertyProjectionOrderExitOperation.java
* Support for ordering in cases of property projection
org/hibernate/shards/strategy/exit/PropertyProjectionExitOperation.java
* Support for property projection (return always the first element of the returned
result set)
org/hibernate/shards/ShardImpl.java
* Support for SQLQuery
* Support for execute update operation
org/hibernate/shards/query/ShardedSQLQueryImpl.java
* Implementation for SQLQuery using Shards, all the implemented operations are just the
same as the hql query, the rest is not supported
org/hibernate/shards/query/ShardedSQLQuery.java
* An interface for SQLQuery using Shards
org/hibernate/shards/query/ShardedQueryImpl.java
* Support execute update operation
org/hibernate/shards/query/AdHocQueryFactoryImpl.java
* Support creation of SQLQuery
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira