[Hibernate-JIRA] Created: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
5:33 a.m.
validateValue() and validateProperty() are too restrictive regarding processable property
names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Priority: Minor
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in Java
identifiers
* private String €Amount; // some currency signs such as "€" are allowed, sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:23 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik updated HV-376:
---------------------------------
Fix Version/s: 4.2.0.CR1
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Hardy Ferentschik
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
New subject: [Hibernate-JIRA] Assigned: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Kevin Pollet reassigned HV-376:
-------------------------------
Assignee: Kevin Pollet
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:06 a.m.
New subject: [Hibernate-JIRA] Issue Comment Edited: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik edited comment on HV-376 at 2/7/11 4:05 AM:
--------------------------------------------------------------
The proposed solution by Kevin is to replace:
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\w+)(\\[(\\w*)\\])?(\\.(.*))*" );{code}
by
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*"
);{code}
The latter works, because of pattern categories and the fact that {{Character}} methods of
the form _ismethodname_ which return boolean are valid categories. Considering this the
proposed solution seems to be correct.
However, there are concerns that not all JVM implementations implement these categories
properly. Obviously that would be against the spec, but I still would prefer that HV is
not failing in this case.
At the moment we have a regexp which is not 100% correct, but at least it works on all
JVMs (personally I think anyone using "€" and similar within method names should
be punished anyways). If switching to a more correct regular expression means that we
introduce problems for "reasonable" method names on some JVMs we maybe should
look at other solutions (or keep the current one).
was (Author: hardy.ferentschik):
The proposed solution by Kevin is to replace:
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\w+)(\\[(\\w*)\\])?(\\.(.*))*" );{code}
by
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*"
);{code}
The latter works, because of pattern categories and the fact that {{Character}} methods of
the form _ismethodname_ which return boolean are valid categories. Considering this the
proposed solution seems to be correct.
However, there are concerns that not all JVM implementations implement these categories
properly. Obviously that would be against the spec, but I still would prefer that HV is
not failing in this case.
At the moment we have a regexp which is not 100% correct, but at least it works on all
JVMs (personally I think anyone using "€" and similar within method names should
be punished anyways). If switching to a more correct regular expression means that we
introduce problems for "reasonable" method names on some JVMs we maybe should
look at other solutions.
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:06 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik commented on HV-376:
--------------------------------------
The proposed solution by Kevin is to replace:
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\w+)(\\[(\\w*)\\])?(\\.(.*))*" );{code}
by
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"(\\p{javaJavaIdentifierStart}\\p{javaJavaIdentifierPart}*)(\\[(\\w*)\\])?(\\.(.*))*"
);{code}
The latter works, because of pattern categories and the fact that {{Character}} methods of
the form _ismethodname_ which return boolean are valid categories. Considering this the
proposed solution seems to be correct.
However, there are concerns that not all JVM implementations implement these categories
properly. Obviously that would be against the spec, but I still would prefer that HV is
not failing in this case.
At the moment we have a regexp which is not 100% correct, but at least it works on all
JVMs (personally I think anyone using "€" and similar within method names should
be punished anyways). If switching to a more correct regular expression means that we
introduce problems for "reasonable" method names on some JVMs we maybe should
look at other solutions.
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Kevin Pollet commented on HV-376:
---------------------------------
I've an other proposition to avoid the use of categories pattern in the regular
expression. The regular expression could be modified to
{code}private static final Pattern PATH_PATTERN = Pattern.compile(
"([^\\[\\.]+)(\\[(\\w*)\\])?(\\.(.*))*" );{code}
and add a method in the PathImpl class which validates the identifier with the *Character*
_isJavaIdentifierStart/Part_ methods. Something like this
[https://gist.github.com/3e1da7b7f3660868cba5].
WDYT ?
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik updated HV-376:
---------------------------------
Fix Version/s: (was: 4.2.0.CR1)
4.2.0.Beta2
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.2.0.Beta1
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.Beta2
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik updated HV-376:
---------------------------------
Affects Version/s: (was: 4.1.0.Final)
4.2.0.Beta1
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.2.0.Beta1
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.Beta2
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 a.m.
New subject: [Hibernate-JIRA] Resolved: (HV-376) validateValue() and validateProperty() are too restrictive regarding processable property names
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-376?page=com...
]
Hardy Ferentschik resolved HV-376.
----------------------------------
Resolution: Fixed
validateValue() and validateProperty() are too restrictive regarding
processable property names
-----------------------------------------------------------------------------------------------
Key: HV-376
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-376
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.2.0.Beta1
Reporter: Gunnar Morling
Assignee: Kevin Pollet
Priority: Minor
Fix For: 4.2.0.CR1
The methods Validator#validateValue() and Validator#validateProperty() expect the name of
a bean property, for which constraint validation should be performed.
Currently not all valid Java property (field/method) identifiers are supported here, as
the specified property name is processed in PathImpl with a regular expression, that
matches only the word character class (A-Za-z0-9_), causing the evaluation of uncommon but
yet valid property names such as the following ones to fail:
* private String höchstBetrag; // German Umlaute such as "ö" are allowed in
Java identifiers
* private String €Amount; // some currency signs such as "€" are allowed,
sigh
* private String höchst\u00f6Betrag; // specifying letters such as "ö" using
Unicode is allowed
Trying to do so results in the following exception:
{code:java}
java.lang.IllegalArgumentException: Unable to parse property path ö
at org.hibernate.validator.engine.PathImpl.parseProperty(PathImpl.java:216)
at org.hibernate.validator.engine.PathImpl.createPathFromString(PathImpl.java:64)
at org.hibernate.validator.engine.ValidatorImpl.validateValue(ValidatorImpl.java:152)
{code}
More information on the identifiers allowed in the Java language can be found in [JLS,
chapter 3.8|http://java.sun.com/docs/books/jls/third_edition/html/lexical.html#3.8].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4990
days inactive
5126
days old
hibernate-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Gunnar Morling (JIRA) -
Hardy Ferentschik (JIRA)
-
Kevin Pollet (JIRA)