[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095?page=c... ] Matt Benson commented on HHH-5095: ---------------------------------- or, I suppose if you really wanted to get fancy: {code} private boolean isBag(CollectionPersister collectionPersister) { return collectionPersister.getCollectionType() instanceof BagType; } {code} ;) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095?page=c... ] Gail Badner commented on HHH-5095: ---------------------------------- Matt, Please attach a runnable test case (Java + mapping) that reproduces this issue. It would be good to have a test that shows that MultipleBagFetchException is thrown as expected. Thanks, Gail -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095?page=c... ] Gail Badner updated HHH-5095: ----------------------------- Assignee: Gail Badner Fix Version/s: 3.6 3.5.2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095?page=c... ] Matt Benson commented on HHH-5095: ---------------------------------- Heh--good question. In my particular case I aspect my domain types' collection/map members with an extra interface by dynamically generating proxy objects for incoming values when the fields are set. Mixing these proxies with Hibernate persistent collections doesn't work because Hibernate expects identity equality for these. I don't want to alter my Hibernate mappings to use custom collections if I can help it because I have designed this aspecting approach to be non-invasive; with this goal in mind I instead post-process the Hibernate Configuration, dynamically extending the various CollectionType and PersistentCollection subclasses. This way Hibernate tracks its PersistentCollection instances in the way it expects and I add my additional interface to the PersistentCollections directly, but subclassing BagType is a requirement to make all this work. :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-5095?page=c... ] Matt Benson commented on HHH-5095: ---------------------------------- Well, after reviewing the code in question, isBag(...) is only used locally to determine whether to throw an exception in the event that more than one bag is part of the same query, so the only thing I give up by using the released code is a little comfort that Hibernate will detect this condition. I would assume that this check exists only to verify that some other code elsewhere in Hibernate hasn't done something it wasn't supposed to. I will nonetheless make the assertion that if theoretical BagType subclasses, however unlikely, were truly intended to be excluded here, the original author would/should have used Class.equals(...) rather than .isAssignableFrom(...). Regards, Matt -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira