[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-1829?page=c... ] Anthony Patricio commented on HHH-1829: --------------------------------------- Hi Mathieu, I ported and tested the patch on trunk. Here are my comments: - it works, makes the feature available - it doesn't impact the results of the testsuite so no new bugs HOWEVER - hibernate annotation doesn't compile anymore, that's a first big issue - the impact is huge and complex, SingleTableEntityPersister, Queryable,Loadable,EntityPersister, PersistentClass, MultiTableUpdateExecutor, MultiTableDeleteExecutor, AbstractStatementExecutor but mainly in AbstractEntityPersister These changes make the code more complex to maintain. Did you think of other ways this could be implemented or was it the only option available? In a future release (3.6/3.7), a new metadata API will be available. It will offer the ability to point a FK at a column other than the PK. This is exactly what is needed here but unfortunately not easy at all with the current design. Maybe it could be much more interesting to wait until 3.6/3.7. What do you think? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira