[Hibernate-JIRA] Created: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
1:19 p.m.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:34 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Adrian Hummel commented on HHH-5032:
------------------------------------
Using {{EntityManager.lock(entity, LockModeType.OPTIMISTIC)}} (or {{LockModeType.READ}})
does not work correctly, too. Assume the following scenario:
1) T1 reads Customer with its CreditCards
2) T2 updates the customer
3) T2 commits
4) T1 updates one CreditCard and locks the customer to be sure it hasn't changed yet:
{{lock(customer, LockModeType.OPTIMISTIC)}}
5) T1 commits
Step 5) executes without detecting stale data. Expected an {{OptimisticLockException}} to
be thrown.
(the same scenario worked as expected with hibernate-entitymanager 3.3.2.GA)
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:03 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara updated HHH-5032:
-----------------------------
Attachment: optimisticlocking.tar.gz
Attached a project that replicates the issue under hibernate 3.5.0.final
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner commented on HHH-5032:
----------------------------------
Is this still an issue using 3.5.1?
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara commented on HHH-5032:
----------------------------------
Yes, same behavior in 3.5.1-final
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:36 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner updated HHH-5032:
-----------------------------
Affects Version/s: 3.5.1
Carlos, thanks for checking and for the test case!
Is this a problem for a particular dialect?
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:09 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner reassigned HHH-5032:
--------------------------------
Assignee: Scott Marlow
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:32 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara commented on HHH-5032:
----------------------------------
Hi Gail,
AFAIK it is not dialect dependent. Also, I have checked under H2 and PostgreSQL and both
had the same behavior.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow reassigned HHH-5032:
---------------------------------
Assignee: (was: Scott Marlow)
Carlos, I'll leave unassigned since your not yet a committer :)
Just leave a comment when you are done with the unit test and I will take it back.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow commented on HHH-5032:
-----------------------------------
Thanks for the test case, could you merge the test into file
./entitymanager/src/test/java/org/hibernate/ejb/test/lock/LockTest.java? If you could do
so and attach a patch (result of executing subversion diff in project root folder, as in
"svn diff > hhh5032.patch").
We can discuss further if your not configured to build/run the Hibernate unit tests. So
info is here http://hibernate.org/sourcecode.html
I'll assign the jira back to you. You can assign back to me after the test case is
converted into a unit test.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Attachments: optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara updated HHH-5032:
-----------------------------
Attachment: hhh5032.patch
Merged test into LockTest
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara commented on HHH-5032:
----------------------------------
Hi Scott,
I created the test and included it in your LockTest. You already had a similar test, the
difference being that in your test you check using the same em for creating and locking
the object (and it works alright), while in my test, I use a second em for finding and
then locking the object. Problem is when calling em.find() in the new em, the object gets
locked with LockMode.READ, which is higher than LockMode.OPTIMISTIC_FORCE_INCREMENT.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Attachments: hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner reassigned HHH-5032:
--------------------------------
Assignee: Scott Marlow
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Attachments: hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:52 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow resolved HHH-5032.
-------------------------------
Resolution: Fixed
Fix Version/s: 3.6
3.5.x
fix checked into 3_5 + trunk.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.x, 3.6
Attachments: hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Carlos Vara updated HHH-5032:
-----------------------------
Attachment: hhh5032-2.patch
Hi Scott,
sorry for the delay, I couldn't test this sooner. Thanks for the fix, it is working
fine if a lock mode is specified when fetching an entity. However, if no lock mode is
specified, the upgrade to OPTIMISTIC_FORCE_INCREMENT fails again :-/
I attach another test that should replicate the issue.
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:29 a.m.
New subject: [Hibernate-JIRA] Reopened: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow reopened HHH-5032:
-------------------------------
sigh :)
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:39 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner commented on HHH-5032:
----------------------------------
Hi Scott,
I'm getting ready to release 3.5.2. Can the fix in its current state be released in
3.5.2? If more work needs to be done, can it be done as a separate issue?
Thanks,
Gail
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:46 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow commented on HHH-5032:
-----------------------------------
Gail, the current fix is fine to release. I'm fine with moving this jira to the next
3.5.x release or whatever you want to do with it.
Best, Scott
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:57 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Gail Badner resolved HHH-5032.
------------------------------
Resolution: Fixed
I'll resolve this as fixed then. Please create a new Jira issue for wrapping up any
loose ends.
Thanks,
Gail
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:09 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Scott Marlow commented on HHH-5032:
-----------------------------------
New issue is HHH-5222, feel free to update...
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-5032) Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only OPTIMISTIC
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032?page=c...
]
Steve Ebersole closed HHH-5032.
-------------------------------
Setting LockModeType.OPTIMISTIC_FORCE_INCREMENT defaults to only
OPTIMISTIC
---------------------------------------------------------------------------
Key: HHH-5032
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5032
Project: Hibernate Core
Issue Type: Bug
Affects Versions: 3.5.0-CR-2, 3.5.1
Environment: Hibernate Core 3.5.0-CR-2, Hibernate Validator 4.1 Snapshot, Spring
3.0.1, JPA2
Reporter: Carlos Vara
Assignee: Scott Marlow
Fix For: 3.5.2, 3.6
Attachments: hhh5032-2.patch, hhh5032.patch, optimisticlocking.tar.gz
Using EntityManager.lock(entity, LockModeType.OPTIMISTIC_FORCE_INCREMENT) doesn't
change lock type, and version doesn't get updated on transaction commit.
The following code:
System.out.println("PRE lock mode: " + this.entityManager.getLockMode(an));
this.entityManager.lock(an, LockModeType.OPTIMISTIC_FORCE_INCREMENT);
System.out.println("POST lock mode: " + this.entityManager.getLockMode(an));
Outputs:
PRE lock mode: OPTIMISTIC
POST lock mode: OPTIMISTIC
Debugging AbstractLockUpgradeEventListener.upgradeLock, the reason is it doesn't
upgrade it because previous lock mode is "READ" (whose level is 5), and
OPTIMISTIC_FORCE_INCREMENT has level 4, so it doesn't trigger the update.
I'm not sure about Hibernate's LockMode, but I think that
OPTIMISTIC_FORCE_INCREMENT is a bit more restrictive than just OPTIMISTIC, so the locking
type should be upgraded.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5197
days inactive
5312
days old
hibernate-issues@lists.jboss.org
20 comments
5 participants
participants (5)
-
Adrian Hummel (JIRA) -
Carlos Vara (JIRA)
-
Gail Badner (JIRA)
-
Scott Marlow (JIRA)
-
Steve Ebersole (JIRA)