3:23 a.m.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.3.0.CR1, 3.2.6, 3.2.5, 3.2.4.sp1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so as
to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
Please check to see if this is a duplicate of HHH-2269.
If not, then please attach a runnable test case (Java + mapping) that reproduces this
issue.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge commented on HHH-3334:
------------------------------------
Looks like it's the same final cause though this case looks a little bit simpler to
debug.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:10 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge updated HHH-3334:
-------------------------------
Attachment: AbstractSaveEventListener.java
Search for "// Start WW patch" till "// End WW patch".
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:12 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge commented on HHH-3334:
------------------------------------
I've coded a workaround. Patch is attached (search for "// Start WW patch"
to "// End WW patch")
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:03 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
Wallace, I think your issue is related to HHH-2269, but it doesn't look like the patch
fixes the that issue.
There is a test case that reproduces HHH-2269:
org.hibernate.test.cascade.BidirectionalOneToManyCascadeTest.testSaveOrphanDeleteChildWithParentFailureExpected
When I ran the unit tests using the patch, this test still fails using HSQLDB and MySQL.
Does it fail when you run your unit tests?
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge commented on HHH-3334:
------------------------------------
I didn't have time yet to test out
"testSaveOrphanDeleteChildWithParentFailureExpected" so I've removed the
"fixes issue hhh-269" link for now (I have limited connectivity to the web for
the next few days), I hope to find time to test it out in a couple of weeks.
It certainly fixes the problem related to this issue for us though.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:12 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
When you have a chance, please attach a test case that reproduces the issue that your
patch fixes.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:38 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Pavol Zibrita commented on HHH-3334:
------------------------------------
HI, Wallace.
Can you please check, if the patch in HHH-3046 fixes this issue?
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:25 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge updated HHH-3334:
-------------------------------
Attachment: brokenCascade.zip
Test case demonstrating problem. Test succeeds if my patch is applied.
Pavol, I'll be testing your patch too.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:04 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge commented on HHH-3334:
------------------------------------
Pavol,
Your alternate patch has also worked for my test case.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate3
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:37 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
I've checked the fix for HHH-3810 into Branch_3_2. I'll check it into the other
branches tonight or tomorrow morning.
This should fix this issue as well.
I also checked in the test case attached to this issue and added another test case based
it. These test cases are in org.hibernate.test.cascade.circle:
org.hibernate.test.cascade.circle.MultiPathCircleCascadeTest
org.hibernate.test.cascade.circle.CascadeMergeToChildBeforeParentTest
Another test case for merge-cascade is at:
org.hibernate.test.cascade.MultiPathCascadeTest
Wallace, I have not tried your test case. Please let me know if the fix for HHH-3810 fixes
your issue. If it doesn't, I'll take a look at it.
You can check the code out from
http://anonsvn.jboss.org/repos/hibernate/core/branches/Branch_3_2/.
If you do try it out, please let me know if it works for your issue.
Thanks,
Gail
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Wallace Wadge commented on HHH-3334:
------------------------------------
Tried it and I'm afraid it still breaks for the following case:
parent_table:
parent_id INTEGER with no autoincrement (i.e id is assigned)
child_table:
child_id INTEGER AUTOINC (generated via MySQL)
parent_id INTEGER FK to parent_table.parent_id
Same test runs fine with Pavol's patch.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:23 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
Hi Wallace, thanks for checking. I'm looking into it...
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
Hi Wallace,
My fix does not affect using Session.save().
Could you try using Session.merge? instead of Session.save() ?
Thanks,
Gail
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
I've checked in the fix for HHH-3810 to Branch_3_3 and trunk.
Wallace, you'll still need to use Session.merge() for your issue in those branches.
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:41 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-3334) Cascading breaks if parent table doesn't have Auto-inc
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner reassigned HHH-3334:
--------------------------------
Assignee: Gail Badner
Cascading breaks if parent table doesn't have Auto-inc
------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:52 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner updated HHH-3334:
-----------------------------
Summary: Cascade-save breaks if parent ID is assigned (delays insert) and child has
identity ID (early insert) (was: Cascading breaks if parent table doesn't have
Auto-inc)
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert)
-----------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:10 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner commented on HHH-3334:
----------------------------------
I've added a FailureExpected test that reproduces this issue in Branch_3_5 and trunk:
org.hibernate.test.cascade.CascadeTestWithAssignedParentIdTest.testSaveChildWithParentFailureExpected()
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert)
-----------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:12 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner updated HHH-3334:
-----------------------------
Affects Version/s: 3.5.3
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert)
-----------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1, 3.5.3
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:15 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert) (Wallace Wadge)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner updated HHH-3334:
-----------------------------
Fix Version/s: 3.5.6
3.6.0.Beta4
Summary: Cascade-save breaks if parent ID is assigned (delays insert) and child
has identity ID (early insert) (Wallace Wadge) (was: Cascade-save breaks if parent ID is
assigned (delays insert) and child has identity ID (early insert))
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert) (Wallace Wadge)
---------------------------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1, 3.5.3
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Fix For: 3.6.0.Beta4, 3.5.6
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert) (Wallace Wadge)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Gail Badner resolved HHH-3334.
------------------------------
Resolution: Fixed
Fixed in trunk and Branch_3_5.
Wallace, thanks for your test case and the fix. I don't see a need for executing the
inserts before and after cascadeBeforeSave(), so I've simply moved that code to where
you suggested. This way the inserts can be executed in 1 batch instead of 2.
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert) (Wallace Wadge)
---------------------------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1, 3.5.3
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Fix For: 3.6.0.Beta4, 3.5.6
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:13 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-3334) Cascade-save breaks if parent ID is assigned (delays insert) and child has identity ID (early insert) (Wallace Wadge)
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334?page=c...
]
Strong Liu commented on HHH-3334:
---------------------------------
https://jira.jboss.org/browse/JBPAPP-4926
Cascade-save breaks if parent ID is assigned (delays insert) and
child has identity ID (early insert) (Wallace Wadge)
---------------------------------------------------------------------------------------------------------------------
Key: HHH-3334
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3334
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.2.4.sp1, 3.2.5, 3.2.6, 3.3.0.CR1, 3.5.3
Environment: tested on MySql, and hibernate versions (with annotations) v3.2.4 to
3.3.0CR1
Reporter: Wallace Wadge
Assignee: Gail Badner
Fix For: 3.6.0.Beta4, 3.5.6
Attachments: AbstractSaveEventListener.java, brokenCascade.zip
(reposting here from forum)
Consider:
- a table with an assigned PK (i.e. not auto-increment), let's call this
"A"
- Another table ("B") linked to the table listed above but with it's PK set
to auto-increment.
Now if you try to save B with cascading switched on, it will break. From the little
debugging I've done it looks like:
a) hibernate detects that A needs to be saved first, but puts it into some sort of
queue.
b) when it hits B, it short-circuits this save queue and tries to save B immediately so
as to obtain a PK reference for B. This fails since A hasn't been yet been saved so
it's link is still null.
Schema used is listed below (MySQL):
----
CREATE DATABASE `jira` /*!40100 DEFAULT CHARACTER SET latin1 */;
DROP TABLE IF EXISTS `jira`.`parent`;
CREATE TABLE `jira`.`parent` (
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
DROP TABLE IF EXISTS `jira`.`child`;
CREATE TABLE `jira`.`child` (
`child_id` int(10) unsigned NOT NULL auto_increment,
`parent_id` int(10) unsigned NOT NULL,
PRIMARY KEY (`child_id`),
KEY `FK_child_1` (`parent_id`),
CONSTRAINT `FK_child_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`parent_id`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5145
days inactive
5953
days old
hibernate-issues@lists.jboss.org
22 comments
4 participants
participants (4)
-
Gail Badner (JIRA) -
Pavol Zibrita (JIRA)
-
Strong Liu (JIRA)
-
Wallace Wadge (JIRA)