[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik edited comment on HHH-6132 at 4/18/11 9:55 AM: ----------------------------------------------------------------- Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ * _SequenceGenerator_ was (Author: hardy.ferentschik): Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ *_SequenceGenerator_ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik edited comment on HHH-6132 at 4/29/11 8:32 AM: ----------------------------------------------------------------- Need to decide whether it is better to do this before or after the main entities are bound. Or maybe both. Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ * _SequenceGenerator_ * _TableGenerator_ * _org.hibernate.annotations.FilterDef(s)_ * _org.hibernate.annotations.GenericGenerator(s)_ * _org.hibernate.annotations.NamedNativeQuery_ * _org.hibernate.annotations.Table(s)_ (provided there is still a way to iterate over all configured tables) was (Author: hardy.ferentschik): Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ * _SequenceGenerator_ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik commented on HHH-6132: ---------------------------------------- {quote} i haven't process (mocking annotations) for all NamedQuery/NamedNativeQuery/SequenceGenerator/TableGenerator/SqlResultSetMapping defined in orm.xml, but just collected them so, i need to know if this issue starts from index or you'd prefer a generated jaxb class instances collection. {quote} Both approaches are possible. From a design point of view I would prefer the mock approach. Seems to makes most sense imo. {quote} if, this starts from index, one way i'd think is i can just find a class and mock all these annotations on to it, wdyt? {quote} right the problem is to which class/package to bind these mock annotations. First I thought about the default package which can be specified, but I think even that is optional. In the worst case the initial annotation based index might be even empty in case the application is purely configured via xml. I am wondering though if we couldn't just make create even a mock "default package" annotation. I don't think that for these annotations we have to actually load the annotation target, so it can be pretty much whatever we want. WDYT? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik edited comment on HHH-6132 at 5/2/11 8:25 AM: ---------------------------------------------------------------- Need to decide whether it is better to do this before or after the main entities are bound. Or maybe both. Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ * _SequenceGenerator_ * _TableGenerator_ * _org.hibernate.annotations.FilterDef(s)_ * _org.hibernate.annotations.TypeDef(s)_ * _org.hibernate.annotations.GenericGenerator(s)_ * _org.hibernate.annotations.NamedNativeQuery_ * _org.hibernate.annotations.Table(s)_ (provided there is still a way to iterate over all configured tables) was (Author: hardy.ferentschik): Need to decide whether it is better to do this before or after the main entities are bound. Or maybe both. Examples for these global configuration are: * _FetchProfile_(s) * _NamedQuery_ * _NamedNativeQuery_ * _SequenceGenerator_ * _TableGenerator_ * _org.hibernate.annotations.FilterDef(s)_ * _org.hibernate.annotations.TypeDefs(s)_ * _org.hibernate.annotations.GenericGenerator(s)_ * _org.hibernate.annotations.NamedNativeQuery_ * _org.hibernate.annotations.Table(s)_ (provided there is still a way to iterate over all configured tables) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] John Verhaeg updated HHH-6132: ------------------------------ Fix Version/s: (was: 4.0.0.Alpha3) 4.0.0.Beta1 Much of this work is done, but still some open issues: - Lots of tests need to be created for this code - Not sure if all global configuration has been accounted for - May need to make adjustments depending upon how we determine to complete the validation phase wrt metadata Therefore, keeping issue open and pushing to 4.0.0.Beta1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] John Verhaeg commented on HHH-6132: ----------------------------------- Looks like I royally hosed this up. Reverted all changes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik commented on HHH-6132: ---------------------------------------- {quote} so, i'm wondering maybe we should add a delimitedIdentifier property to the MetadataImpl? and I can set it if delimited-identifier is found in persistence-metadata-unit, and using that to determine if the Identifier should be quoted by default when creating Relational Model. {quote} I guess this would fall under the _XmlContext_ I have been talking about. How this would be made available to the annotation binders, I am not sure. I guess one way would be to add it to _MetadataImpl_. In this case we should probably call this _OrmXmlContext_ (just to differentiate from hbm xml). Didn't think about this though as part of this issue, but rather about the orm.xml parsing issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Strong Liu edited comment on HHH-6132 at 5/13/11 8:44 AM: ---------------------------------------------------------- well, the reason i'd prefer mock annotation is that persistence-metadata-unit also can define <entity-listeners>, and the idea i thought is we should get rid of XMLxxx object at binder and above level here is the prototype: {code:xml} <persistence-unit-metadata> <persistence-unit-defaults> <delimited-identifiers/> <access>FIELD</access> <entity-listeners> <entity-listener class="org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener"> <pre-persist method-name="prePersist"/> <post-persist method-name="postPersist"/> </entity-listener> </entity-listeners> </persistence-unit-defaults> </persistence-unit-metadata> {code} {code:java} public interface MockedNames { public static final DotName DEFAULT_ACCESS = DotName.createSimple( "default.access" ); public static final DotName DEFAULT_DELIMITED_IDENTIFIERS = DotName.createSimple( "default.delimited.identifiers" ); public static final DotName DEFAULT_ENTITY_LISTENERS = DotName.createSimple( "default.entity.listeners" ); public static final DotName DEFAULT_POST_LOAD = DotName.createSimple( "default.entity.listener.post.load" ); public static final DotName DEFAULT_POST_PERSIST = DotName.createSimple( "default.entity.listener.post.persist" ); public static final DotName DEFAULT_POST_REMOVE = DotName.createSimple( "default.entity.listener.post.remove" ); public static final DotName DEFAULT_POST_UPDATE = DotName.createSimple( "default.entity.listener.post.update" ); public static final DotName DEFAULT_PRE_PERSIST = DotName.createSimple( "default.entity.listener.pre.persist" ); public static final DotName DEFAULT_PRE_REMOVE = DotName.createSimple( "default.entity.listener.pre.remove" ); public static final DotName DEFAULT_PRE_UPDATE = DotName.createSimple( "default.entity.listener.pre.update" ); } {code} {quote} Annotations: default.delimited.identifiers: (isMocked = true) default.access: (isMocked = true, value = FIELD) default.entity.listeners: (isMocked = true, value = [org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener]) default.entity.listener.pre.persist: Method: void org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener.prePersist() (isMocked = true) default.entity.listener.post.persist: Method: void org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener.postPersist() (isMocked = true) {quote} was (Author: stliu): well, the reason i'd prefer mock annotation is that persistence-metadata-unit also can define <entity-listeners>, and the idea i thought is we should get rid of XMLxxx object at binder and above level here is the prototype: {quote} <persistence-unit-metadata> <persistence-unit-defaults> <delimited-identifiers/> <access>FIELD</access> <entity-listeners> <entity-listener class="org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener"> <pre-persist method-name="prePersist"/> <post-persist method-name="postPersist"/> </entity-listener> </entity-listeners> </persistence-unit-defaults> </persistence-unit-metadata> {quote} {quote} public interface MockedNames { public static final DotName DEFAULT_ACCESS = DotName.createSimple( "default.access" ); public static final DotName DEFAULT_DELIMITED_IDENTIFIERS = DotName.createSimple( "default.delimited.identifiers" ); public static final DotName DEFAULT_ENTITY_LISTENERS = DotName.createSimple( "default.entity.listeners" ); public static final DotName DEFAULT_POST_LOAD = DotName.createSimple( "default.entity.listener.post.load" ); public static final DotName DEFAULT_POST_PERSIST = DotName.createSimple( "default.entity.listener.post.persist" ); public static final DotName DEFAULT_POST_REMOVE = DotName.createSimple( "default.entity.listener.post.remove" ); public static final DotName DEFAULT_POST_UPDATE = DotName.createSimple( "default.entity.listener.post.update" ); public static final DotName DEFAULT_PRE_PERSIST = DotName.createSimple( "default.entity.listener.pre.persist" ); public static final DotName DEFAULT_PRE_REMOVE = DotName.createSimple( "default.entity.listener.pre.remove" ); public static final DotName DEFAULT_PRE_UPDATE = DotName.createSimple( "default.entity.listener.pre.update" ); } {quote} {quote} Annotations: default.delimited.identifiers: (isMocked = true) default.access: (isMocked = true, value = FIELD) default.entity.listeners: (isMocked = true, value = [org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener]) default.entity.listener.pre.persist: Method: void org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener.prePersist() (isMocked = true) default.entity.listener.post.persist: Method: void org.hibernate.metamodel.source.annotations.xml.mocker.ItemListener.postPersist() (isMocked = true) {quote} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik commented on HHH-6132: ---------------------------------------- i am undecided. Somehow it has a certain beauty. The problem is that we are now not only mocking annotations, but also using _DotName_ not as class or package name. On the other hand a _DotName_ can just be seen as a seperated name. But how do you know what the mocked _AnnotationInstance_s contain? Btw, what's wrong with the _@EntityListeners_ annotation, together with the _@PrePersist_ and _@PostPersist_. _@EntityListeners_ can be mocked against any target and _@PrePersist_ and _@PostPersist_ we mock onto the actual listener. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] Hardy Ferentschik commented on HHH-6132: ---------------------------------------- Got you now. So we really have three choices: * Have some sort of context object (eg _OrmXmlContext) * Create completely new mock instances (your approach with _MockNames_; maybe _PeristentUnitDefaults_ would be better) * Re-use the existing annotations, but add a new property, like _persistenceDefault=true_ At the first thought I preferred the last option, but this might be even less transparent then your option. I think in the end it doesn't matter too much. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] John Verhaeg resolved HHH-6132. ------------------------------- Resolution: Fixed Created binders for several global configurations and updated metadata appropriately. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-6132?page=c... ] John Verhaeg resolved HHH-6132. ------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira