[Hibernate-JIRA] Created: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
4:12 a.m.
Add Set<String> EventListeners.getEventTypes() method and public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
7:24 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Steve Ebersole commented on HHH-2055:
-------------------------------------
This has been asked before.
Useful? Yes.
A priority? No.
Fell free to create a patch...
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
1:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Josh Moore commented on HHH-2055:
---------------------------------
Gladly. Good to know there aren't any objections.
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
1:39 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=all ]
Josh Moore updated HHH-2055:
----------------------------
Attachment: elistener_patch.txt
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Attachments: elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
4:40 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Steve Ebersole commented on HHH-2055:
-------------------------------------
What about the code in Configuration that still use the "raw" strings?
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Attachments: elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
1:39 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Josh Moore commented on HHH-2055:
---------------------------------
One thing at a time ;-) Any other locations of interest? The log.trace() statements in the
event listeners themselves where applicable? (The "load-collection" of
ResultSetMappingBinder probably doesn't count.)
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Attachments: elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
8 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=all ]
Josh Moore updated HHH-2055:
----------------------------
Attachment: cfg_patch.txt
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:45 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Steve Ebersole commented on HHH-2055:
-------------------------------------
Right, the ResultSetMappingBinder one is *not* referencing the event type.
As for the rest, well thats the trick no? ;) Its the part everyone else requesting this
chose to over-look. I am honestly not sure what to tell you; it'll require someone
scouring the code and finding all pertinent uses...
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:47 a.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=all ]
Steve Ebersole reassigned HHH-2055:
-----------------------------------
Assign To: Steve Ebersole
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Assignee: Steve Ebersole
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:52 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Steve Ebersole commented on HHH-2055:
-------------------------------------
Another thought... What about defining these as enums?
public class EventType implements Serializable {
public static final EventType AUTO_FLUSH = new EventType( "auto-flush" );
private final String name;
private EventType(String name) {
this.name = name;
}
...
}
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Assignee: Steve Ebersole
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
9:55 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Josh Moore commented on HHH-2055:
---------------------------------
My approach was this:
josh@millaboula:~/code/hibernateSVN/Hibernate3$ grep -rlE
'("auto-flush"|"merge"|"create"|"create-onflush"|"delete"|"dirty-check"|"evict"|"flush"|"flush-entity"|"load"|"load-collection"|"lock"|"refresh"|"replicate"|"save-update"|"save"|"update"|"pre-load"|"pre-update"|"pre-delete"|"pre-insert"|"post-load"|"post-update"|"post-delete"|"post-insert"|"post-commit-update"|"post-commit-delete"|"post-commit-insert")'
src/ | grep -v svn | less
src/org/hibernate/secure/HibernatePermission.java
src/org/hibernate/pretty/Formatter.java
src/org/hibernate/classic/Session.java
src/org/hibernate/cfg/SettingsFactory.java
src/org/hibernate/cfg/ResultSetMappingBinder.java
src/org/hibernate/cfg/HbmBinder.java
src/org/hibernate/engine/CascadeStyle.java
src/org/hibernate/mapping/Index.java
src/org/hibernate/impl/StatelessSessionImpl.java
src/org/hibernate/tool/hbm2ddl/SchemaExportTask.java
src/org/hibernate/persister/entity/AbstractEntityPersister.java
src/org/hibernate/event/def/DefaultMergeEventListener.java
src/org/hibernate/event/def/DefaultRefreshEventListener.java
src/org/hibernate/event/EventListeners.java
src/org/hibernate/hql/QuerySplitter.java
src/org/hibernate/Session.java
Checked all of those. The only one that seemed iffy was the RSMBinder. (Lots of
flushMode.equals("merge"), cascades, and whatnot. The same run on /test shows
nothing of interest. Almost only *.hbm.xml files.
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Assignee: Steve Ebersole
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
10:54 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2055) Add Set<String> EventListeners.getEventTypes() method and public constants.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055?page=c...
]
Josh Moore commented on HHH-2055:
---------------------------------
Apparently our comments overlapped (diff=3 minutes), no optimistic locking for JIRA
apparently. Anyway by "my approach" I meant how I found the dubious strings,
naturally.
As for the enums, may be userful like CascadeStyle, could even add the interface a la:
public class EventType implements Serializable {
public static final EventType AUTO_FLUSH = new EventType( "auto-flush" ,
AutoFlushEventListener.class );
}
But the look-up via getClassFor(String type) would still require a map with the strings,
and it's just these that I wanted to have. Or the getClassFor method takes an
EventType. What's the chances of dropping that requirement?
Configuration.setListeners() would have to take an EventType, which effects the XML
parsing. Seems messy.
Other possibility is to have Strings and the EventTypes and a Map<String,EventType>
where EventType also has its interface. This could be generated by looping over the enums.
That's be something like:
public EventListeners {
public static class EventType implements Serializable {
private EventType( String name, Class interface, Set typeSet ) {
// ...
typeSet.add( this );
}
}
private static Set types = new HashSet();
public final static EventType AUTO_FLUSH = new
EventType("auto-flush",AutoFlushEventListener.class,types);
//...
}
Add Set<String> EventListeners.getEventTypes() method and
public constants.
---------------------------------------------------------------------------
Key: HHH-2055
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2055
Project: Hibernate3
Type: Improvement
Components: core
Versions: 3.2.0.cr4
Reporter: Josh Moore
Assignee: Steve Ebersole
Priority: Trivial
Attachments: cfg_patch.txt, elistener_patch.txt
Since the EventListeners.getListenerClassFor(String type) takes string types, it would be
useful to be able to get these strings, and perhaps even to them available as public final
static String constants. Simplifies programmatic configuration, and allows for easily
detecting if a new event listener type has been added or removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6680
days inactive
6682
days old
hibernate-issues@lists.jboss.org
11 comments
2 participants
participants (2)
-
Josh Moore (JIRA) -
Steve Ebersole (JIRA)