[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik commented on HV-491: -------------------------------------- Great idea. Any chance you want to contribute a patch ;-) Here are some thoughts from my side. Maybe it would make sense to have a _Mod11_ constraint and as parameter we pass the mod11 algorithm type. If we go down this path it makes sense to re-work our _CreditCardNumber_ constraint. It implements the Luhn algorithm which is effectively Mod10. _CreditCardNumber_ can then use constraint composition. In fact we could also just have one single _ModCheck_ constraint and implement the different mod10 and mod11 algorithms there. WDYT? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] George Gastaldi commented on HV-491: ------------------------------------ I think it´s a great idea. I´ll try to implement something using these. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] George Gastaldi commented on HV-491: ------------------------------------ Explanation of MOD11 algorithm: http://www.pgrocer.net/Cis51/mod11.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik reassigned HV-491: ------------------------------------ Assignee: Hardy Ferentschik -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik commented on HV-491: -------------------------------------- I think this might be the work we have been discussing https://github.com/gastaldi/hibernate-validator/tree/feature/mod11 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik commented on HV-491: -------------------------------------- Ok, thanks. I rebased it onto master. I'll take closer look. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] George Gastaldi commented on HV-491: ------------------------------------ Looks good to me ! I just added the messages in Brazilian and Default (English) in https://github.com/hferentschik/hibernate-validator/pull/2. Will check the docs when possible. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik commented on HV-491: -------------------------------------- Added some online docs and created pull request - https://github.com/hibernate/hibernate-validator/pull/98 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-491?page=com... ] Hardy Ferentschik commented on HV-491: -------------------------------------- {quote} There is another rule on the CPF constraint: "00000000000" and "99999999999" returns true on the current algorithm, however, they should not be used when thinking about business requirements. {quote} If these values are excluded by the ruls of a CPF the constraint should handle them. {quote} Is there a @InvalidValues constraint or something like it ? {quote} There is no _@InvalidValue_. I guess you would use a regular expression. Something like {noformat} ^(?:(?!000\.000\.000-00).)*$ ^(?:(?!999\.999\.999-99).)*$ {noformat} should work in conjunction with _(a)Pattern.List_ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-491?page=com.atlassian.jira.plugin... ] Hardy Ferentschik resolved HV-491. ---------------------------------- Resolution: Fixed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira