[Hibernate-JIRA] Created: (EJB-361) Query#setParameter(int position, Object value) wrong implementation
4:56 p.m.
Query#setParameter(int position, Object value) wrong implementation
-------------------------------------------------------------------
Key: EJB-361
URL: http://opensource.atlassian.com/projects/hibernate/browse/EJB-361
Project: Hibernate Entity Manager
Issue Type: Bug
Components: EntityManager
Affects Versions: 3.3.2.GA
Reporter: Fabrice Daugan
The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value)
implementation does not suit to the JPA specicafication.
Indeed, the actual integer passed to the operation is converted to String by Hibernate and
then used to find the named parameter.
Please have a look to the folowing stack trace :
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException:
org.hibernate.QueryParameterException: could not locate named parameter [1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185)
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240)
at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316)
To repoduce this error :
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:58 p.m.
New subject: [Hibernate-JIRA] Commented: (EJB-361) Query#setParameter(int position, Object value) wrong implementation
[
http://opensource.atlassian.com/projects/hibernate/browse/EJB-361?page=co...
]
Fabrice Daugan commented on EJB-361:
------------------------------------
The code used to reproduce this error :
Query queryObject = em.createQuery(queryString);
if (values != null) {
for (int i = 0; i < values.length; i++) {
queryObject.setParameter(i + 1, values[i]);
}
}
return queryObject.getResultList();
Query#setParameter(int position, Object value) wrong implementation
-------------------------------------------------------------------
Key: EJB-361
URL: http://opensource.atlassian.com/projects/hibernate/browse/EJB-361
Project: Hibernate Entity Manager
Issue Type: Bug
Components: EntityManager
Affects Versions: 3.3.2.GA
Reporter: Fabrice Daugan
Original Estimate: 2 hours
Remaining Estimate: 2 hours
The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value)
implementation does not suit to the JPA specicafication.
Indeed, the actual integer passed to the operation is converted to String by Hibernate
and then used to find the named parameter.
Please have a look to the folowing stack trace :
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException:
org.hibernate.QueryParameterException: could not locate named parameter [1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185)
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240)
at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316)
To repoduce this error :
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:41 p.m.
New subject: [Hibernate-JIRA] Commented: (EJB-361) Query#setParameter(int position, Object value) wrong implementation
[
http://opensource.atlassian.com/projects/hibernate/browse/EJB-361?page=co...
]
John Sublette commented on EJB-361:
-----------------------------------
I just ran into what looks like this problem also. I tracked it down to the
QueryImpl.isPositionalParameter() function. It looks to me like the comments don't
match the code.
According to the code, the following queryStrings should return:
"SELECT Foo FROM Foo WHERE Foo.param1 = :value" TRUE (index == -1, Should
have been false, right?)
"SELECT Foo FROM Foo WHERE Foo.param1 = ?" FALSE (found index is last char,
Should have been true, right?)
"SELECT Foo FROM Foo WHERE Foo.param1 = ?1" TRUE (found index is followed by a
digit)
I noticed this problem when I tried using a query similar to the first (by name) but was
trying to set the parameters by index (similar to Fabrice Daugan). It looks like it would
work correctly if the return values were swapped for the first two cases.
private boolean isPositionalParameter() {
256 if (isPositional == null) {
257 //compute it
258 String queryString = query.getQueryString();
259 int index = queryString.indexOf( '?' );
260 //there is a ? and the following char is a digit
261 if (index == -1) {
262 //no ?
263 isPositional = true;
264 }
265 else if ( index == queryString.length() - 1 ) {
266 // "... ?"
267 isPositional = false;
268 }
269 else {
270 isPositional = Character.isDigit( queryString.charAt( index + 1 ) );
271 }
272 }
273 return isPositional;
274 }
275
Query#setParameter(int position, Object value) wrong implementation
-------------------------------------------------------------------
Key: EJB-361
URL: http://opensource.atlassian.com/projects/hibernate/browse/EJB-361
Project: Hibernate Entity Manager
Issue Type: Bug
Components: EntityManager
Affects Versions: 3.3.2.GA
Reporter: Fabrice Daugan
Original Estimate: 2 hours
Remaining Estimate: 2 hours
The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value)
implementation does not suit to the JPA specicafication.
Indeed, the actual integer passed to the operation is converted to String by Hibernate
and then used to find the named parameter.
Please have a look to the folowing stack trace :
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException:
org.hibernate.QueryParameterException: could not locate named parameter [1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185)
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240)
at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316)
To repoduce this error :
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 p.m.
New subject: [Hibernate-JIRA] Commented: (EJB-361) Query#setParameter(int position, Object value) wrong implementation
[
http://opensource.atlassian.com/projects/hibernate/browse/EJB-361?page=co...
]
John Sublette commented on EJB-361:
-----------------------------------
Missed a potential problem
"SELECT Foo FROM Foo WHERE Foo.param1 = ? AND Foo.param2 = 5" FALSE (found index
is followed by a non-digit (space) -- should be true, right?)
Query#setParameter(int position, Object value) wrong implementation
-------------------------------------------------------------------
Key: EJB-361
URL: http://opensource.atlassian.com/projects/hibernate/browse/EJB-361
Project: Hibernate Entity Manager
Issue Type: Bug
Components: EntityManager
Affects Versions: 3.3.2.GA
Reporter: Fabrice Daugan
Original Estimate: 2 hours
Remaining Estimate: 2 hours
The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value)
implementation does not suit to the JPA specicafication.
Indeed, the actual integer passed to the operation is converted to String by Hibernate
and then used to find the named parameter.
Please have a look to the folowing stack trace :
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException:
org.hibernate.QueryParameterException: could not locate named parameter [1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185)
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240)
at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316)
To repoduce this error :
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-4157) Query#setParameter(int position, Object value) wrong implementation
[
https://hibernate.onjira.com/browse/HHH-4157?page=com.atlassian.jira.plug...
]
Roger Pack commented on HHH-4157:
---------------------------------
I think this is still a problem isn't it? Or at least shouldn't "select foo
from foo where param1 = ?".setParameter(1, "abc") work?
Query#setParameter(int position, Object value) wrong implementation
-------------------------------------------------------------------
Key: HHH-4157
URL: https://hibernate.onjira.com/browse/HHH-4157
Project: Hibernate ORM
Issue Type: Bug
Components: entity-manager
Reporter: Fabrice Daugan
Original Estimate: 2h
Remaining Estimate: 2h
The Hibernate JPA javax.persistence.Query#setParameter(int position, Object value)
implementation does not suit to the JPA specicafication.
Indeed, the actual integer passed to the operation is converted to String by Hibernate
and then used to find the named parameter.
Please have a look to the folowing stack trace :
java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException:
org.hibernate.QueryParameterException: could not locate named parameter [1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:185)
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:240)
at org.springframework.orm.jpa.JpaTemplate$9.doInJpa(JpaTemplate.java:316)
To repoduce this error :
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4465
days inactive
5881
days old
hibernate-issues@lists.jboss.org
4 comments
3 participants
participants (3)
-
Fabrice Daugan (JIRA) -
John Sublette (JIRA)
-
Roger Pack (JIRA)