[Hibernate-JIRA] Created: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
6:59 a.m.
Provide a fail fast switch to stop processing constraints on first failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
On first failure, HS should stop processing constraint failures and return straight.
this should be both a ValidatorFactory setting and a Validator setting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Emmanuel Bernard commented on HV-381:
-------------------------------------
http://github.com/emmanuelbernard/hibernate-validator/commits/failFast
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
On first failure, HS should stop processing constraint failures and return straight.
this should be both a ValidatorFactory setting and a Validator setting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:33 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik updated HV-381:
---------------------------------
Fix Version/s: 4.x
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.x
On first failure, HS should stop processing constraint failures and return straight.
this should be both a ValidatorFactory setting and a Validator setting
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:05 a.m.
New subject: [Hibernate-JIRA] Updated: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik updated HV-381:
---------------------------------
Description:
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
was:
On first failure, HS should stop processing constraint failures and return straight.
this should be both a ValidatorFactory setting and a Validator setting
Fix Version/s: (was: 4.x)
4.2.0.Beta2
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik commented on HV-381:
--------------------------------------
https://github.com/kevinpollet/hibernate-validator/commits/HV-381
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Gunnar Morling commented on HV-381:
-----------------------------------
When discussing this issue on hibernate-dev last year there was the idea of introducing a
numeric parameter representing the maximum violations allowed instead of a boolean
parameter, see http://lists.jboss.org/pipermail/hibernate-dev/2010-October/005613.html. I
still like that approach, it is just a bit more flexible. WDYT?
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:43 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Emmanuel Bernard commented on HV-381:
-------------------------------------
Yes we can do that. If anyone want to take over this work that would help me. I'm
quite busy on other things.
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik commented on HV-381:
--------------------------------------
Kevin is already working on it. Check his hv fork if you are interested.
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Emmanuel Bernard
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 a.m.
New subject: [Hibernate-JIRA] Assigned: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik reassigned HV-381:
------------------------------------
Assignee: Kevin Pollet (was: Emmanuel Bernard)
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik commented on HV-381:
--------------------------------------
For the records - link to the hibernate-dev discussion around this issue -
http://www.mail-archive.com/hibernate-dev@lists.jboss.org/msg05192.html
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:15 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik commented on HV-381:
--------------------------------------
Regarding the numeric parameter. We could start with just failFast:
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast( true )
.getValidator();
{code}
and if we want we add later:
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast( true )
.maxFailures(5)
.getValidator();
{code}
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Kevin Pollet commented on HV-381:
---------------------------------
+1, I like Hardy's idea.
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Gunnar Morling commented on HV-381:
-----------------------------------
I'm not sure whether I like this as it leaves space for inconsistent invocations of
the API such as
{code:java}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast( false )
.maxFailures(5)
.getValidator();
{code}
Plus, would it be sufficient to invoke maxFailures() or would it be required to invoke
failFast() as well? If you don't feel like starting with the numeric parameter in the
first place we should better leave it out at all.
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Emmanuel Bernard commented on HV-381:
-------------------------------------
another approach is to make maxFailure a method only available on the object returned by
failFast. That way, people cannot get confused by what Gunnar is pointing out.
WRT the last comment by Gunnar, I think that
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast( true )
.maxFailures(5)
.getValidator();
{code}
is more readable than
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.maxFailures(5)
.getValidator();
{code}
We can even think about using failFast() instead of failFast(boolean)
The drawback of that approach is that it's a bit harder on generic users of the
programmatic API (ie the one having a failFast boolean).
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik commented on HV-381:
--------------------------------------
Making it only available on {{failFast}} was the intention, but I guess I should have made
this more obvious via intendation :-)
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:26 p.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Gunnar Morling commented on HV-381:
-----------------------------------
Ah ok, now I see. Making maxFailures only available when failFast() was called, seems like
a good approach.
Continuing Emmanuel's last idea we might also offer simply two overloaded methods,
failFast() and failFast(int maxFailures), where there first would be equivalent to calling
failFast(1). This would allow to set the maximum failure count with one call, which I
personally would prefer. But I'm fine with either way as long as there is no chance to
use the API in a wrong way :)
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Kevin Pollet commented on HV-381:
---------------------------------
First off all it's just my opinion :)
Using {{failFast()}} instead of {{failFast(boolean)}} can be confusing if people wants to
disable failFast locally on the Validator with {{usingContext}} method. Another point, if
people use {{failFast(int maxFailures)}} to enable failFast what's the value to
disable it ?
I think {{failFast(boolean)}} is the best solution to enable/disable the functionnality.
Continuing Gunnar's idea we might provide two overloaded methods like :
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast()
.maxFailures( 5 )
.getValidator();
{code}
The above method enables failFast and allow to customize it with the max failures value.
{code}
final Validator validator = factory.unwrap( HibernateValidatorFactory.class )
.usingContext()
.failFast( false )
.getValidator();
{code}
The above method could be used to simply enable it (maxFailures(1)) and to disable it.
WDYT ?
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:41 a.m.
New subject: [Hibernate-JIRA] Commented: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Emmanuel Bernard commented on HV-381:
-------------------------------------
I'm not a big fan of overloaded methods personally. Plus they do not convert naturally
into their properties counterpart.
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:34 a.m.
New subject: [Hibernate-JIRA] Resolved: (HV-381) Provide a fail fast switch to stop processing constraints on first failure
[
http://opensource.atlassian.com/projects/hibernate/browse/HV-381?page=com...
]
Hardy Ferentschik resolved HV-381.
----------------------------------
Resolution: Fixed
Provide a fail fast switch to stop processing constraints on first
failure
--------------------------------------------------------------------------
Key: HV-381
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-381
Project: Hibernate Validator
Issue Type: Bug
Components: engine
Affects Versions: 4.1.0.Final
Reporter: Emmanuel Bernard
Assignee: Kevin Pollet
Fix For: 4.2.0.Beta2
On first failure, HS should stop processing constraint failures and return straight.
This should be both a {{ValidatorFactory}} setting and a {{Validator}} setting.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5083
days inactive
5216
days old
hibernate-issues@lists.jboss.org
18 comments
4 participants
participants (4)
-
Emmanuel Bernard (JIRA) -
Gunnar Morling (JIRA)
-
Hardy Ferentschik (JIRA)
-
Kevin Pollet (JIRA)