March 2016 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-3938) AdvancedAsyncCacheLoader.process() concurrency issues

by RH Bugzilla Integration (JIRA)

[ https://issues.jboss.org/browse/ISPN-3938?page=com.atlassian.jira.plugin.... ] RH Bugzilla Integration updated ISPN-3938: ------------------------------------------ Bugzilla References: https://bugzilla.redhat.com/show_bug.cgi?id=1312186 Bugzilla Update: Perform > AdvancedAsyncCacheLoader.process() concurrency issues > ----------------------------------------------------- > > Key: ISPN-3938 > URL: https://issues.jboss.org/browse/ISPN-3938 > Project: Infinispan > Issue Type: Bug > Components: Core, Loaders and Stores > Affects Versions: 6.0.0.Final > Reporter: Dan Berindei > Assignee: Sebastian Łaskawiec > Fix For: 8.2.0.CR1 > > > {{AdvancedAsyncCacheLoader.process()}} calls {{advancedLoader().process()}} to collect all the keys in the store, but the HashSet used to collect the keys it not thread-safe. This can cause problems, e.g. during state transfer: > {noformat} > WARN cheTopologyControlCommand | ISPN000071: Caught exception when handling command CacheTopologyControlCommand{cache=sessions, type=CH_UPDATE, sender=alfie-lt-46127, joinInfo=null, topologyId=3, currentCH=DefaultConsistentHash{numSegments=60, numOwners=1, members=[alfie-lt-46127]}, pendingCH=null, throwable=null, viewId=1}java.util.ConcurrentModificationException > at java.util.HashMap$HashIterator.nextEntry(HashMap.java:926) > at java.util.HashMap$KeyIterator.next(HashMap.java:960) > at org.infinispan.persistence.async.AdvancedAsyncCacheLoader.process(AdvancedAsyncCacheLoader.java:80) > at org.infinispan.persistence.manager.PersistenceManagerImpl.processOnAllStores(PersistenceManagerImpl.java:414) > at org.infinispan.statetransfer.StateConsumerImpl.invalidateSegments(StateConsumerImpl.java:910) > at org.infinispan.statetransfer.StateConsumerImpl.onTopologyUpdate(StateConsumerImpl.java:393) > at org.infinispan.statetransfer.StateTransferManagerImpl.doTopologyUpdate(StateTransferManagerImpl.java:178) > at org.infinispan.statetransfer.StateTransferManagerImpl.access$000(StateTransferManagerImpl.java:38) > at org.infinispan.statetransfer.StateTransferManagerImpl$1.updateConsistentHash(StateTransferManagerImpl.java:100) > at org.infinispan.topology.LocalTopologyManagerImpl.handleConsistentHashUpdate(LocalTopologyManagerImpl.java:191) > at org.infinispan.topology.CacheTopologyControlCommand.doPerform(CacheTopologyControlCommand.java:152) > at org.infinispan.topology.CacheTopologyControlCommand.perform(CacheTopologyControlCommand.java:124) > at org.infinispan.topology.ClusterTopologyManagerImpl$3.run(ClusterTopologyManagerImpl.java:606) > at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) > at java.util.concurrent.FutureTask.run(FutureTask.java:262) > at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:744) > {noformat} -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6279) Refactor CacheLoader API to make it thread safe

by Sebastian Łaskawiec (JIRA)

[ https://issues.jboss.org/browse/ISPN-6279?page=com.atlassian.jira.plugin.... ] Sebastian Łaskawiec commented on ISPN-6279: ------------------------------------------- After thinking about it a little bit longer, I think it would be good to have a default implementation of {{process}} method (which as you mentioned could use {{WithinThreadExecutor}}). This method could call our new simplified method (without {{Executor}} argument etc). This way less advanced users could use simplified API (and be less exposed to concurrency issues in their own code) whereas more advanced could implement {{process}} and do whatever they like. [~william.burns] WDYT? > Refactor CacheLoader API to make it thread safe > ----------------------------------------------- > > Key: ISPN-6279 > URL: https://issues.jboss.org/browse/ISPN-6279 > Project: Infinispan > Issue Type: Feature Request > Components: Loaders and Stores > Reporter: Sebastian Łaskawiec > Priority: Minor > Fix For: 9.0.0.Final > > > h3. Introduction > Currently {{CacheLoader}} thread safety can be easily compromised by broken implementations. We should provide a better implementation to make it more convenient and less error prone. > h3. Problem statement > CacheLoader API looks like this: > {code} > public interface AdvancedCacheLoader<K, V> extends CacheLoader<K, V> { > ... > void process(KeyFilter<? super K> filter, CacheLoaderTask<K, V> task, Executor executor, boolean fetchValue, boolean fetchMetadata); > ... > } > {code} > The CacheLoader implementation controls {{CacheLoaderTask}} as well as the number of threads used for processing (specified by {{Executor}}). If one wants to collect all keys (similarly to [AdvancedCacheLoader|https://github.com/infinispan/infinispan/blob/master/...]) it is very easy to hit concurrently issues while adding them to the set (See previous JIRAs: ISPN-3938 and ISPN-6276). > h3. Solution > The solution should take away currently control (Executor) and keyset (the simplest idea is to add it to {{CacheLoaderTask}}) from from the implementation. One of the ideas is to create a Lambda expression for pulling records from Cache Store. Note that similar changes will need to be performed to {{CacheWriter}} (to make it similar). -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6294) Query DSL should allow easy 'continuation' to assist with creating dynamic queries

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6294?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6294: -------------------------------- Description: Conditional chaining of DSL conditions is cumbersome, as shown here: https://github.com/infinispan/infinispan/blob/af7f38ba1cf538be6b08d7b895f... > Query DSL should allow easy 'continuation' to assist with creating dynamic queries > ---------------------------------------------------------------------------------- > > Key: ISPN-6294 > URL: https://issues.jboss.org/browse/ISPN-6294 > Project: Infinispan > Issue Type: Enhancement > Components: Embedded Querying > Reporter: Adrian Nistor > Fix For: 9.0.0.Final > > > Conditional chaining of DSL conditions is cumbersome, as shown here: https://github.com/infinispan/infinispan/blob/af7f38ba1cf538be6b08d7b895f... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6294) Query DSL should allow easy 'continuation' to assist with creating dynamic queries

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6294?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6294: -------------------------------- Fix Version/s: 9.0.0.Final > Query DSL should allow easy 'continuation' to assist with creating dynamic queries > ---------------------------------------------------------------------------------- > > Key: ISPN-6294 > URL: https://issues.jboss.org/browse/ISPN-6294 > Project: Infinispan > Issue Type: Enhancement > Components: Embedded Querying > Reporter: Adrian Nistor > Fix For: 9.0.0.Final > > > Conditional chaining of DSL conditions is cumbersome, as shown here: https://github.com/infinispan/infinispan/blob/af7f38ba1cf538be6b08d7b895f... -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6298) Network partition detection not working in mgmt console

by Jiří Holuša (JIRA)

[ https://issues.jboss.org/browse/ISPN-6298?page=com.atlassian.jira.plugin.... ] Jiří Holuša updated ISPN-6298: ------------------------------ Description: Page: Clusters -> select server group. When I create a network partition and go to the page above, I still see the cluster status as "started". According to https://issues.jboss.org/browse/ISPN-5768 , there should be something as "Degraded" I checked that the cluster is really partitioned. When I go to JConsole, I see in JGroups JChannel attributes, that the "view" is only partial. I also see in the server logs that servers correctly detected the split. When I go to homepage (or the "Status event" tab), I see in the "Latest Grid Events:" that the split happened, hence the mgmt console is able to correctly detect it elsewhere. Note that neither the status of a cache, which has configured partition handling to true, changes. was: Page: Clusters -> select server group. When I create a network partition and go to the page above, I still see the cluster status as "started". According to https://issues.jboss.org/browse/ISPN-5768 , there should be something as "Degraded" I checked that the cluster is really partitioned. When I go to JConsole, I see in JGroups JChannel attributes, that the "view" is only partial. I also see in the server logs that servers correctly detected the split. When I go to homepage (or the "Status event" tab), I see in the "Latest Grid Events:" that the split happened, hence the mgmt console is able to correctly detect it elsewhere. > Network partition detection not working in mgmt console > ------------------------------------------------------- > > Key: ISPN-6298 > URL: https://issues.jboss.org/browse/ISPN-6298 > Project: Infinispan > Issue Type: Bug > Components: Console > Affects Versions: 8.1.2.Final > Reporter: Jiří Holuša > Assignee: Vladimir Blagojevic > > Page: Clusters -> select server group. > When I create a network partition and go to the page above, I still see the cluster status as "started". According to https://issues.jboss.org/browse/ISPN-5768 , there should be something as "Degraded" > I checked that the cluster is really partitioned. When I go to JConsole, I see in JGroups JChannel attributes, that the "view" is only partial. I also see in the server logs that servers correctly detected the split. > When I go to homepage (or the "Status event" tab), I see in the "Latest Grid Events:" that the split happened, hence the mgmt console is able to correctly detect it elsewhere. > Note that neither the status of a cache, which has configured partition handling to true, changes. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6298) Network partition detection not working in mgmt console

by Jiří Holuša (JIRA)

Jiří Holuša created ISPN-6298: --------------------------------- Summary: Network partition detection not working in mgmt console Key: ISPN-6298 URL: https://issues.jboss.org/browse/ISPN-6298 Project: Infinispan Issue Type: Bug Components: Console Affects Versions: 8.1.2.Final Reporter: Jiří Holuša Assignee: Vladimir Blagojevic Page: Clusters -> select server group. When I create a network partition and go to the page above, I still see the cluster status as "started". According to https://issues.jboss.org/browse/ISPN-5768 , there should be something as "Degraded" I checked that the cluster is really partitioned. When I go to JConsole, I see in JGroups JChannel attributes, that the "view" is only partial. I also see in the server logs that servers correctly detected the split. When I go to homepage (or the "Status event" tab), I see in the "Latest Grid Events:" that the split happened, hence the mgmt console is able to correctly detect it elsewhere. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6297) Move ConcurrentHashSet to infinispan-common

by Sebastian Łaskawiec (JIRA)

Sebastian Łaskawiec created ISPN-6297: ----------------------------------------- Summary: Move ConcurrentHashSet to infinispan-common Key: ISPN-6297 URL: https://issues.jboss.org/browse/ISPN-6297 Project: Infinispan Issue Type: Enhancement Components: Core Reporter: Sebastian Łaskawiec Assignee: Sebastian Łaskawiec Priority: Trivial Fix For: 9.0.0.Alpha1 -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6296) Mark dependencies as provided in Cache Stores

by Sebastian Łaskawiec (JIRA)

Sebastian Łaskawiec created ISPN-6296: ----------------------------------------- Summary: Mark dependencies as provided in Cache Stores Key: ISPN-6296 URL: https://issues.jboss.org/browse/ISPN-6296 Project: Infinispan Issue Type: Enhancement Reporter: Sebastian Łaskawiec Assignee: Sebastian Łaskawiec Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6295) Mark dependencies as provided in JCache

by Sebastian Łaskawiec (JIRA)

Sebastian Łaskawiec created ISPN-6295: ----------------------------------------- Summary: Mark dependencies as provided in JCache Key: ISPN-6295 URL: https://issues.jboss.org/browse/ISPN-6295 Project: Infinispan Issue Type: Enhancement Reporter: Sebastian Łaskawiec Assignee: Sebastian Łaskawiec Priority: Minor -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6294) Query DSL should allow easy 'continuation' to assist with creating dynamic queries

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/ISPN-6294?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-6294: -------------------------------- Status: Open (was: New) > Query DSL should allow easy 'continuation' to assist with creating dynamic queries > ---------------------------------------------------------------------------------- > > Key: ISPN-6294 > URL: https://issues.jboss.org/browse/ISPN-6294 > Project: Infinispan > Issue Type: Enhancement > Components: Embedded Querying > Reporter: Adrian Nistor > -- This message was sent by Atlassian JIRA (v6.4.11#64026)

9 years, 9 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues March 2016