[JBoss JIRA] (ISPN-9827) The Hot Rod client should apply topology changes after the response has been processed
by Radim Vansa (Jira)
[ https://issues.jboss.org/browse/ISPN-9827?page=com.atlassian.jira.plugin.... ]
Radim Vansa commented on ISPN-9827:
-----------------------------------
The problem was that the FTPing operation was already gone from the operations map, held only in the `operation` field.
So the remove in {{HotRodDecoder:126}} should be changed to get and the remove should be issued after line {{144}}, or maybe even better the current {{operation}} should be added to the list returned by {{allCompleteFuture()}}.
> The Hot Rod client should apply topology changes after the response has been processed
> --------------------------------------------------------------------------------------
>
> Key: ISPN-9827
> URL: https://issues.jboss.org/browse/ISPN-9827
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 10.0.0.Alpha2, 9.4.4.Final
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Major
>
> The Hot Rod client applies topology changes to the connection pool while it is processing the header. This could cause the channel on which it is reading to be closed before the response has been completely processed. Topology changes should be applied when the operation completes.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (ISPN-9827) The Hot Rod client should apply topology changes after the response has been processed
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-9827?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-9827:
------------------------------------
I was thinking we'd only read the response and act on it later. [~rvansa] how sure are you that sending the close event doesn't prevent the channel from becoming active again (so that the client can finish reading the response)?
> The Hot Rod client should apply topology changes after the response has been processed
> --------------------------------------------------------------------------------------
>
> Key: ISPN-9827
> URL: https://issues.jboss.org/browse/ISPN-9827
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 10.0.0.Alpha2, 9.4.4.Final
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Major
>
> The Hot Rod client applies topology changes to the connection pool while it is processing the header. This could cause the channel on which it is reading to be closed before the response has been completely processed. Topology changes should be applied when the operation completes.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months
[JBoss JIRA] (ISPN-9827) The Hot Rod client should apply topology changes after the response has been processed
by Radim Vansa (Jira)
[ https://issues.jboss.org/browse/ISPN-9827?page=com.atlassian.jira.plugin.... ]
Radim Vansa commented on ISPN-9827:
-----------------------------------
I don't agree. The channel pool is sending an event and not closing it right away - it just prevents new operations to be scheduled there, but that shouldn't happen as the channel pool is already marked inactive.
Remember that there are other operations on the channel as well. Behaviour to current operation (receiveing the topology update) should not differ to behaviour on the other operations.
> The Hot Rod client should apply topology changes after the response has been processed
> --------------------------------------------------------------------------------------
>
> Key: ISPN-9827
> URL: https://issues.jboss.org/browse/ISPN-9827
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 10.0.0.Alpha2, 9.4.4.Final
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Major
>
> The Hot Rod client applies topology changes to the connection pool while it is processing the header. This could cause the channel on which it is reading to be closed before the response has been completely processed. Topology changes should be applied when the operation completes.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 9 months