[JBoss JIRA] (ISPN-8923) PersistenceManagerCloseableSupplier can timeout if store produces entries too fast
by William Burns (JIRA)
William Burns created ISPN-8923:
-----------------------------------
Summary: PersistenceManagerCloseableSupplier can timeout if store produces entries too fast
Key: ISPN-8923
URL: https://issues.jboss.org/browse/ISPN-8923
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 9.2.0.Final
Reporter: William Burns
Fix For: 9.3.0.Final, 9.2.1.Final, 9.1.7.Final
PersistenceManagerCloseableSupplier get method polls the queue then locks the lock. It doesn't recheck the queue inside the lock. Thus if a loader fills up the entire queue before the get method can acquire the lock, this will cause the get method to timeout. Instead we should change the check inside the lock to always poll the queue.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8921) KeyStream stream operations use entrySet on remote nodes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8921?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8921:
--------------------------------
Status: Open (was: New)
> KeyStream stream operations use entrySet on remote nodes
> --------------------------------------------------------
>
> Key: ISPN-8921
> URL: https://issues.jboss.org/browse/ISPN-8921
> Project: Infinispan
> Issue Type: Bug
> Components: Streams
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.3.0.Final, 9.2.1.Final
>
>
> Currently when a remote stream operation is performed it is always done using an entrySet. This causes a lot of overhead for keySet operations - especially if there is a store! We should support key based streams for remote nodes in addition to entry set.
> There is nothing stopping this currently, all we should need is an additional argument for StreamIteratorRequestCommand to say if it is keyset or entry set. Then the LocalStreamManaterImpl and IteratorHandler need very minor tweaks. This should help operations such as size when using a store quite a bit depending on the store implementation.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8921) KeyStream stream operations use entrySet on remote nodes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8921?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8921:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/5824
> KeyStream stream operations use entrySet on remote nodes
> --------------------------------------------------------
>
> Key: ISPN-8921
> URL: https://issues.jboss.org/browse/ISPN-8921
> Project: Infinispan
> Issue Type: Bug
> Components: Streams
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.3.0.Final, 9.2.1.Final
>
>
> Currently when a remote stream operation is performed it is always done using an entrySet. This causes a lot of overhead for keySet operations - especially if there is a store! We should support key based streams for remote nodes in addition to entry set.
> There is nothing stopping this currently, all we should need is an additional argument for StreamIteratorRequestCommand to say if it is keyset or entry set. Then the LocalStreamManaterImpl and IteratorHandler need very minor tweaks. This should help operations such as size when using a store quite a bit depending on the store implementation.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8921) KeyStream stream operations use entrySet on remote nodes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8921?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-8921:
--------------------------------
Fix Version/s: 9.2.1.Final
> KeyStream stream operations use entrySet on remote nodes
> --------------------------------------------------------
>
> Key: ISPN-8921
> URL: https://issues.jboss.org/browse/ISPN-8921
> Project: Infinispan
> Issue Type: Bug
> Components: Streams
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.3.0.Final, 9.2.1.Final
>
>
> Currently when a remote stream operation is performed it is always done using an entrySet. This causes a lot of overhead for keySet operations - especially if there is a store! We should support key based streams for remote nodes in addition to entry set.
> There is nothing stopping this currently, all we should need is an additional argument for StreamIteratorRequestCommand to say if it is keyset or entry set. Then the LocalStreamManaterImpl and IteratorHandler need very minor tweaks. This should help operations such as size when using a store quite a bit depending on the store implementation.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8921) KeyStream stream operations use entrySet on remote nodes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8921?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-8921:
-------------------------------------
This is much more pervasive then originally thought - going through all the forEach methods as well.
> KeyStream stream operations use entrySet on remote nodes
> --------------------------------------------------------
>
> Key: ISPN-8921
> URL: https://issues.jboss.org/browse/ISPN-8921
> Project: Infinispan
> Issue Type: Bug
> Components: Streams
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.3.0.Final
>
>
> Currently when a remote stream operation is performed it is always done using an entrySet. This causes a lot of overhead for keySet operations - especially if there is a store! We should support key based streams for remote nodes in addition to entry set.
> There is nothing stopping this currently, all we should need is an additional argument for StreamIteratorRequestCommand to say if it is keyset or entry set. Then the LocalStreamManaterImpl and IteratorHandler need very minor tweaks. This should help operations such as size when using a store quite a bit depending on the store implementation.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8921) KeyStream stream operations use entrySet on remote nodes
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-8921?page=com.atlassian.jira.plugin.... ]
William Burns commented on ISPN-8921:
-------------------------------------
Unfortunately this requires more refactoring in DistributedCacheStream that the others. I will try to limit the scope of changes there.
> KeyStream stream operations use entrySet on remote nodes
> --------------------------------------------------------
>
> Key: ISPN-8921
> URL: https://issues.jboss.org/browse/ISPN-8921
> Project: Infinispan
> Issue Type: Bug
> Components: Streams
> Affects Versions: 9.2.0.Final
> Reporter: William Burns
> Assignee: William Burns
> Fix For: 9.3.0.Final
>
>
> Currently when a remote stream operation is performed it is always done using an entrySet. This causes a lot of overhead for keySet operations - especially if there is a store! We should support key based streams for remote nodes in addition to entry set.
> There is nothing stopping this currently, all we should need is an additional argument for StreamIteratorRequestCommand to say if it is keyset or entry set. Then the LocalStreamManaterImpl and IteratorHandler need very minor tweaks. This should help operations such as size when using a store quite a bit depending on the store implementation.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months
[JBoss JIRA] (ISPN-8918) When a cache is stopped and restarted, its configuration reference within component registry is not refreshed with defineConfiguration/undefineConfiguration
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-8918?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-8918:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 9.2.1.Final
Resolution: Done
> When a cache is stopped and restarted, its configuration reference within component registry is not refreshed with defineConfiguration/undefineConfiguration
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-8918
> URL: https://issues.jboss.org/browse/ISPN-8918
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.1.6.Final, 9.2.0.Final
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 9.2.1.Final
>
>
> When a cache is stopped and restarted, its configuration reference within component registry is not refreshed with defineConfiguration/undefineConfiguration.
> The problem is that org/infinispan/factories/ComponentRegistry.java:77 is only called once the cache is being wired thus {{registerComponent(configuration, Configuration.class);}} is the only place where the configuration is put into the registry.
> The best solution is to remove the cache in TERMINATED state once configuration is undefined thus establishing a clear terminal lifecycle.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
7 years, 10 months