[JBoss JIRA] (ISPN-2757) ReplaceCommand REPL mode cluster does not perform any modifications if the entry was not yet transfered during rehashing
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2757?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2757:
--------------------------------
Description: The local data container does not have the entry yet so the ReplaceCommand fails. See BaseReplStateTransferConsistencyTest.testReplace(). (was: The local data container does not have the entry yet so the ReplaceCommand fails. See BaseDistStateTransferConsistencyTest.testReplace() and BaseReplStateTransferConsistencyTest.testReplace().)
> ReplaceCommand REPL mode cluster does not perform any modifications if the entry was not yet transfered during rehashing
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ISPN-2757
> URL: https://issues.jboss.org/browse/ISPN-2757
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Affects Versions: 5.2.0.Beta5
> Reporter: Adrian Nistor
> Assignee: Adrian Nistor
> Priority: Blocker
> Fix For: 5.2.0.Final
>
>
> The local data container does not have the entry yet so the ReplaceCommand fails. See BaseReplStateTransferConsistencyTest.testReplace().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2756) Enabling/disabling RpcManager statistics via JMX doesn't work
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-2756?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-2756:
------------------------------------
Looks like the {{statisticsEnabled}} field and the {{isStatisticsEnabled}} method both have a {{@ManagedAttribute}} annotation and a {{JmxAttributeMetadata}} entry in the component metadata, but {{isStatisticsEnabled}} doesn't have write enabled.
{{ResourceDMBean}} processes the {{JmxAttributeMetadata}} entries in no particular order, so it could process the field entry last (meaning the attribute will be writable), or it could process the method entry last (and the attribute will be read-only). I think we should not allow components to use the {{@ManagedAttribute}} more than once for the same attribute.
I think we should also stop swallowing exceptions in {{ResourceDMBean}}.
> Enabling/disabling RpcManager statistics via JMX doesn't work
> -------------------------------------------------------------
>
> Key: ISPN-2756
> URL: https://issues.jboss.org/browse/ISPN-2756
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 5.2.0.CR2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 5.2.0.Final
>
>
> The test RpcManagerMBeanTest.testEnableJmxStats tries to write to the "StatisticsEnabled" attribute but fails. The operation doesn't throw an exception, but it does log this WARN message:
> {noformat}
> 10:43:42,079 WARN (testng-RpcManagerMBeanTest:) [ResourceDMBean] ISPN000043: Exception while writing value for attribute statisticsEnabled
> java.lang.NullPointerException
> at org.infinispan.jmx.ResourceDMBean$InvokableSetterBasedMBeanAttributeInfo.invoke(ResourceDMBean.java:391)
> at org.infinispan.jmx.ResourceDMBean.setNamedAttribute(ResourceDMBean.java:325)
> at org.infinispan.jmx.ResourceDMBean.setAttribute(ResourceDMBean.java:212)
> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.setAttribute(DefaultMBeanServerInterceptor.java:746)
> at com.sun.jmx.mbeanserver.JmxMBeanServer.setAttribute(JmxMBeanServer.java:729)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:134)
> {noformat}
> Because statistics are still enabled, the test then fails with an assertion error:
> {noformat}
> 10:43:42,464 ERROR (testng-RpcManagerMBeanTest:) [UnitTestTestNGListener] Test testEnableJmxStats(org.infinispan.jmx.RpcManagerMBeanTest) failed.
> java.lang.AssertionError: expected [-1] but found [1]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:165)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:138)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2756) Enabling/disabling RpcManager statistics via JMX doesn't work
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-2756?page=com.atlassian.jira.plugin.... ]
Work on ISPN-2756 started by Dan Berindei.
> Enabling/disabling RpcManager statistics via JMX doesn't work
> -------------------------------------------------------------
>
> Key: ISPN-2756
> URL: https://issues.jboss.org/browse/ISPN-2756
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 5.2.0.CR2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 5.2.0.Final
>
>
> The test RpcManagerMBeanTest.testEnableJmxStats tries to write to the "StatisticsEnabled" attribute but fails. The operation doesn't throw an exception, but it does log this WARN message:
> {noformat}
> 10:43:42,079 WARN (testng-RpcManagerMBeanTest:) [ResourceDMBean] ISPN000043: Exception while writing value for attribute statisticsEnabled
> java.lang.NullPointerException
> at org.infinispan.jmx.ResourceDMBean$InvokableSetterBasedMBeanAttributeInfo.invoke(ResourceDMBean.java:391)
> at org.infinispan.jmx.ResourceDMBean.setNamedAttribute(ResourceDMBean.java:325)
> at org.infinispan.jmx.ResourceDMBean.setAttribute(ResourceDMBean.java:212)
> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.setAttribute(DefaultMBeanServerInterceptor.java:746)
> at com.sun.jmx.mbeanserver.JmxMBeanServer.setAttribute(JmxMBeanServer.java:729)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:134)
> {noformat}
> Because statistics are still enabled, the test then fails with an assertion error:
> {noformat}
> 10:43:42,464 ERROR (testng-RpcManagerMBeanTest:) [UnitTestTestNGListener] Test testEnableJmxStats(org.infinispan.jmx.RpcManagerMBeanTest) failed.
> java.lang.AssertionError: expected [-1] but found [1]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:165)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:138)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2756) Enabling/disabling RpcManager statistics via JMX doesn't work
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2756?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño commented on ISPN-2756:
----------------------------------------
Most likely this is related to ISPN-2611 + ISPN-2745.
> Enabling/disabling RpcManager statistics via JMX doesn't work
> -------------------------------------------------------------
>
> Key: ISPN-2756
> URL: https://issues.jboss.org/browse/ISPN-2756
> Project: Infinispan
> Issue Type: Bug
> Components: JMX, reporting and management
> Affects Versions: 5.2.0.CR2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 5.2.0.Final
>
>
> The test RpcManagerMBeanTest.testEnableJmxStats tries to write to the "StatisticsEnabled" attribute but fails. The operation doesn't throw an exception, but it does log this WARN message:
> {noformat}
> 10:43:42,079 WARN (testng-RpcManagerMBeanTest:) [ResourceDMBean] ISPN000043: Exception while writing value for attribute statisticsEnabled
> java.lang.NullPointerException
> at org.infinispan.jmx.ResourceDMBean$InvokableSetterBasedMBeanAttributeInfo.invoke(ResourceDMBean.java:391)
> at org.infinispan.jmx.ResourceDMBean.setNamedAttribute(ResourceDMBean.java:325)
> at org.infinispan.jmx.ResourceDMBean.setAttribute(ResourceDMBean.java:212)
> at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.setAttribute(DefaultMBeanServerInterceptor.java:746)
> at com.sun.jmx.mbeanserver.JmxMBeanServer.setAttribute(JmxMBeanServer.java:729)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:134)
> {noformat}
> Because statistics are still enabled, the test then fails with an assertion error:
> {noformat}
> 10:43:42,464 ERROR (testng-RpcManagerMBeanTest:) [UnitTestTestNGListener] Test testEnableJmxStats(org.infinispan.jmx.RpcManagerMBeanTest) failed.
> java.lang.AssertionError: expected [-1] but found [1]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:494)
> at org.testng.Assert.assertEquals(Assert.java:123)
> at org.testng.Assert.assertEquals(Assert.java:165)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:138)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2622) Random failure in RpcManagerMBeanTest
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2622?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño reassigned ISPN-2622:
--------------------------------------
Assignee: Galder Zamarreño (was: Mircea Markus)
> Random failure in RpcManagerMBeanTest
> -------------------------------------
>
> Key: ISPN-2622
> URL: https://issues.jboss.org/browse/ISPN-2622
> Project: Infinispan
> Issue Type: Bug
> Components: RPC
> Affects Versions: 5.2.0.Beta5
> Reporter: Dan Berindei
> Assignee: Galder Zamarreño
> Priority: Minor
> Labels: testsuite_stability
> Fix For: 5.3.0.Final
>
> Attachments: testEnableJmxStats-0.log
>
>
> The test records the replication counter in RpcManagerImpl at the start of the test and after a put operation, and asserts that it only changed by 1. Occasionally, the assertion fails:
> {noformat}
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:89)
> at org.testng.Assert.failNotEquals(Assert.java:489)
> at org.testng.Assert.assertEquals(Assert.java:118)
> at org.testng.Assert.assertEquals(Assert.java:160)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:126)
> {noformat}
> This happens because replication counter is only incremented *after* a successful RPC. The test starts when the cluster is considered "formed", that is when all the nodes are included in the read CH on every node. But that doesn't mean that the RPCs pushing state have finished - a pushing node may still be waiting for a response and so it might increment its replication counter after the start of the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2622) Random failure in RpcManagerMBeanTest
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2622?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño commented on ISPN-2622:
----------------------------------------
That NPE could be the result of the JMX changes Tristan did as part of ISPN-2611 and ISPN-2745.
> Random failure in RpcManagerMBeanTest
> -------------------------------------
>
> Key: ISPN-2622
> URL: https://issues.jboss.org/browse/ISPN-2622
> Project: Infinispan
> Issue Type: Bug
> Components: RPC
> Affects Versions: 5.2.0.Beta5
> Reporter: Dan Berindei
> Assignee: Galder Zamarreño
> Priority: Minor
> Labels: testsuite_stability
> Fix For: 5.3.0.Final
>
> Attachments: testEnableJmxStats-0.log
>
>
> The test records the replication counter in RpcManagerImpl at the start of the test and after a put operation, and asserts that it only changed by 1. Occasionally, the assertion fails:
> {noformat}
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:89)
> at org.testng.Assert.failNotEquals(Assert.java:489)
> at org.testng.Assert.assertEquals(Assert.java:118)
> at org.testng.Assert.assertEquals(Assert.java:160)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:126)
> {noformat}
> This happens because replication counter is only incremented *after* a successful RPC. The test starts when the cluster is considered "formed", that is when all the nodes are included in the read CH on every node. But that doesn't mean that the RPCs pushing state have finished - a pushing node may still be waiting for a response and so it might increment its replication counter after the start of the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2622) Random failure in RpcManagerMBeanTest
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2622?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-2622:
-----------------------------------
Fix Version/s: 5.2.0.Final
(was: 5.3.0.Final)
> Random failure in RpcManagerMBeanTest
> -------------------------------------
>
> Key: ISPN-2622
> URL: https://issues.jboss.org/browse/ISPN-2622
> Project: Infinispan
> Issue Type: Bug
> Components: RPC
> Affects Versions: 5.2.0.Beta5
> Reporter: Dan Berindei
> Assignee: Galder Zamarreño
> Priority: Minor
> Labels: testsuite_stability
> Fix For: 5.2.0.Final
>
> Attachments: testEnableJmxStats-0.log
>
>
> The test records the replication counter in RpcManagerImpl at the start of the test and after a put operation, and asserts that it only changed by 1. Occasionally, the assertion fails:
> {noformat}
> java.lang.AssertionError: expected [1] but found [2]
> at org.testng.Assert.fail(Assert.java:89)
> at org.testng.Assert.failNotEquals(Assert.java:489)
> at org.testng.Assert.assertEquals(Assert.java:118)
> at org.testng.Assert.assertEquals(Assert.java:160)
> at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:126)
> {noformat}
> This happens because replication counter is only incremented *after* a successful RPC. The test starts when the cluster is considered "formed", that is when all the nodes are included in the read CH on every node. But that doesn't mean that the RPCs pushing state have finished - a pushing node may still be waiting for a response and so it might increment its replication counter after the start of the test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2756) Enabling/disabling RpcManager statistics via JMX doesn't work
by Dan Berindei (JIRA)
Dan Berindei created ISPN-2756:
----------------------------------
Summary: Enabling/disabling RpcManager statistics via JMX doesn't work
Key: ISPN-2756
URL: https://issues.jboss.org/browse/ISPN-2756
Project: Infinispan
Issue Type: Bug
Components: JMX, reporting and management
Affects Versions: 5.2.0.CR2
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 5.2.0.Final
The test RpcManagerMBeanTest.testEnableJmxStats tries to write to the "StatisticsEnabled" attribute but fails. The operation doesn't throw an exception, but it does log this WARN message:
{noformat}
10:43:42,079 WARN (testng-RpcManagerMBeanTest:) [ResourceDMBean] ISPN000043: Exception while writing value for attribute statisticsEnabled
java.lang.NullPointerException
at org.infinispan.jmx.ResourceDMBean$InvokableSetterBasedMBeanAttributeInfo.invoke(ResourceDMBean.java:391)
at org.infinispan.jmx.ResourceDMBean.setNamedAttribute(ResourceDMBean.java:325)
at org.infinispan.jmx.ResourceDMBean.setAttribute(ResourceDMBean.java:212)
at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.setAttribute(DefaultMBeanServerInterceptor.java:746)
at com.sun.jmx.mbeanserver.JmxMBeanServer.setAttribute(JmxMBeanServer.java:729)
at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:134)
{noformat}
Because statistics are still enabled, the test then fails with an assertion error:
{noformat}
10:43:42,464 ERROR (testng-RpcManagerMBeanTest:) [UnitTestTestNGListener] Test testEnableJmxStats(org.infinispan.jmx.RpcManagerMBeanTest) failed.
java.lang.AssertionError: expected [-1] but found [1]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:165)
at org.infinispan.jmx.RpcManagerMBeanTest.testEnableJmxStats(RpcManagerMBeanTest.java:138)
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years
[JBoss JIRA] (ISPN-2577) Silence SuspectExceptions
by Michal Linhard (JIRA)
[ https://issues.jboss.org/browse/ISPN-2577?page=com.atlassian.jira.plugin.... ]
Michal Linhard commented on ISPN-2577:
--------------------------------------
I didn't want to create a new JIRA this kind of cosmetic task, but if we're doing this SuspectException silencing, let's sync it with behaviour on hotrod client. If we have a RetryOnFailureOperation should it log an error (in the retry mode) ? My proposal would be switching this to warning.
{code}
09:25:19,154 ERROR [org.jboss.smartfrog.jdg.loaddriver.DriverThread] (DriverThread-378) Error doing: PUT key655878 to node node0003, took 1395 ms
org.infinispan.client.hotrod.exceptions.RemoteNodeSuspecException:Request for message id[1981607] returned server error (status=0x85): org.infinispan.remoting.transport.jgroups.SuspectException: One or more nodes have left the cluster while replicating command SingleRpcCommand{cacheName='testCache', command=PutKeyValueCommand{key=ByteArrayKey{data=ByteArray{size=12, hashCode=727c8fa, array=0x033e096b65793635..}}, value=CacheValue{data=ByteArray{size=1029, array=0x034304002106020a..}, version=9007207845383422}, flags=[IGNORE_RETURN_VALUES], putIfAbsent=false, lifespanMillis=-1, maxIdleTimeMillis=-1, successful=true}}
at org.infinispan.client.hotrod.impl.protocol.Codec10.checkForErrorsInResponseStatus(Codec10.java:153)
at org.infinispan.client.hotrod.impl.protocol.Codec10.readHeader(Codec10.java:110)
at org.infinispan.client.hotrod.impl.operations.HotRodOperation.readHeaderAndValidate(HotRodOperation.java:78)
at org.infinispan.client.hotrod.impl.operations.AbstractKeyValueOperation.sendPutOperation(AbstractKeyValueOperation.java:72)
at org.infinispan.client.hotrod.impl.operations.PutOperation.executeOperation(PutOperation.java:52)
at org.infinispan.client.hotrod.impl.operations.PutOperation.executeOperation(PutOperation.java:41)
at org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation.execute(RetryOnFailureOperation.java:68)
at org.infinispan.client.hotrod.impl.RemoteCacheImpl.put(RemoteCacheImpl.java:231)
at org.infinispan.CacheSupport.put(CacheSupport.java:53)
at org.jboss.qa.jdg.adapter.HotRodAdapter$HotRodRemoteCacheAdapter.put(HotRodAdapter.java:247)
at org.jboss.qa.jdg.adapter.HotRodAdapter$HotRodRemoteCacheAdapter.put(HotRodAdapter.java:232)
at org.jboss.smartfrog.jdg.loaddriver.DriverThreadImpl.makeRequest(DriverThreadImpl.java:236)
at org.jboss.smartfrog.jdg.loaddriver.DriverThreadImpl.run(DriverThreadImpl.java:331)
{code}
> Silence SuspectExceptions
> -------------------------
>
> Key: ISPN-2577
> URL: https://issues.jboss.org/browse/ISPN-2577
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 5.2.0.Beta4
> Reporter: Michal Linhard
> Assignee: Dan Berindei
> Fix For: 5.2.0.Final
>
>
> There are lots of SuspectExceptions in resilience test run:
> https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/EDG6/view/EDG-REPOR...
> We managed to keep these under cover for 5.1.x branch.
> This is of course a cosmetic problem, but it polutes the log with unnecessary ERRORs.
> Parsed logs here:
> http://www.qa.jboss.com/~mlinhard/test_results/run54-parsed/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years