[JBoss JIRA] (ISPN-2611) Drop rhq-pluginAnnotations and rhq-pluginGen dependencies
by Galder Zamarreño (JIRA)
[ https://issues.jboss.org/browse/ISPN-2611?page=com.atlassian.jira.plugin.... ]
Galder Zamarreño updated ISPN-2611:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> Drop rhq-pluginAnnotations and rhq-pluginGen dependencies
> ---------------------------------------------------------
>
> Key: ISPN-2611
> URL: https://issues.jboss.org/browse/ISPN-2611
> Project: Infinispan
> Issue Type: Task
> Components: JMX, reporting and management
> Affects Versions: 5.2.0.Beta5
> Reporter: Tristan Tarrant
> Assignee: Tristan Tarrant
> Priority: Minor
> Fix For: 5.2.0.Final
>
>
> The rhq-pluginAnnotations and rhq-pluginGen dependencies should be dropped since we can generate the required RHQ plugin descriptor using our own ManagedOperation and ManagedAttribute annotations.
> This will also remove the requirement to carry rhq-pluginAnnotations around to workaround a Java compiler bug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (ISPN-2697) HotRodServer startup fails when its record cannot be inserted into topology cache
by Dan Berindei (JIRA)
[ https://issues.jboss.org/browse/ISPN-2697?page=com.atlassian.jira.plugin.... ]
Dan Berindei commented on ISPN-2697:
------------------------------------
Bela, it's hacky because we don't have access to the message when we invoke the put command, we have to sneak around in CommandAwareRpcDispatcher, sniff for the particular command we want to RSVP, and add the flag there.
The way we added the RSVP flag for state transfer commands was hacky as well, but at least there it was a simple hack: CommandAwareRpcDispatcher checks if the command is an instance of a certain class (3 classes now, but originally it was a single class) and then sets the flag.
For the HotRod server, the command is a PutKeyValueCommand, but we don't want to add the RSVP flag to all the PutKeyValueCommands. So we would need additional checks (perhaps the cache name).
Actually this is another problem with RSVP: we can't use it on all the commands. So we still have to set a reasonable STABLE timeout for the regular traffic, otherwise the server will start but clients will still get TimeoutExceptions while doing their stuff.
IMO we should strive to detect missing messages and retransmit them in < 1 second. It's true that messages aren't lost very often, unless something is misconfigured, but it's something that does happen and 1s is already 1000x the time it takes to send a message normally.
> HotRodServer startup fails when its record cannot be inserted into topology cache
> ---------------------------------------------------------------------------------
>
> Key: ISPN-2697
> URL: https://issues.jboss.org/browse/ISPN-2697
> Project: Infinispan
> Issue Type: Bug
> Components: Remote protocols
> Affects Versions: 5.2.0.Beta6
> Reporter: Radim Vansa
> Assignee: Galder Zamarreño
> Priority: Critical
> Fix For: 5.2.0.Final
>
>
> When the HotRodServer starts it inserts its record to __hotRodTopologyCache ({{HotRodServer.addSelfToTopologyView(...)}}).
> However, this put may very easily fail - as the command is broadcasted using NAKACK2 protocol, if the message gets lost and there's no following broadcasted message, the message will be not retransmitted and the put operation times out (Replication timeout), which fails the whole HotRodServer startup, all because of one lost UDP message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (ISPN-2581) StateTransferManagerImpl.waitForInitialStateTransferToComplete() returns too soon
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2581?page=com.atlassian.jira.plugin.... ]
Adrian Nistor reopened ISPN-2581:
---------------------------------
Assignee: Adrian Nistor (was: Dan Berindei)
This was closed without a unit test. I did create one some time ago, so will reopen this.
> StateTransferManagerImpl.waitForInitialStateTransferToComplete() returns too soon
> ---------------------------------------------------------------------------------
>
> Key: ISPN-2581
> URL: https://issues.jboss.org/browse/ISPN-2581
> Project: Infinispan
> Issue Type: Bug
> Components: State transfer
> Affects Versions: 5.2.0.Beta5
> Reporter: Dan Berindei
> Assignee: Adrian Nistor
> Fix For: 5.2.0.Final
>
>
> StateTransferManagerImpl.waitForInitialStateTransferToComplete() returns as soon as a joining node confirmed to the coordinator that it received all the data it needed (see STMI.notifyEndOfTopologyUpdate()).
> It should return only after the coordinator has confirmed the end of the rebalance with a new topology update (see STMI.doTopologyUpdate()).
> This should make it more likely for the tests suite clusters to be in a stable state by the time the test starts, and should help with the random state transfer-related failures in non-state transfer tests.
> Instead we should make sure that we do have tests that check forwarding behaviour explicitly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months
[JBoss JIRA] (ISPN-2748) ExternalizerTable should look for annotations when not finding an externalizer in its writers
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-2748?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-2748:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated. Thanks!
> ExternalizerTable should look for annotations when not finding an externalizer in its writers
> ---------------------------------------------------------------------------------------------
>
> Key: ISPN-2748
> URL: https://issues.jboss.org/browse/ISPN-2748
> Project: Infinispan
> Issue Type: Bug
> Components: Marshalling
> Affects Versions: 5.1.2.FINAL, 5.2.0.CR2
> Reporter: Randall Hauch
> Assignee: Galder Zamarreño
> Fix For: 5.2.0.Final
>
>
> The {{ExternalizerTable.isMarshallableCandidate(Object)}} method currently looks in its writers to see if there is an externalizer for the supplied class. However, under certain circumstances, a user-friendly externalizer is not registered. So this method should also look for annotations to see if the class has a user-friendly externalizer.
> See MODE-1769 for background.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 11 months