[JBoss JIRA] (ISPN-4716) Race condition in index initialization prevents nodes to start successfully on empty indexes
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/ISPN-4716?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on ISPN-4716:
-----------------------------------------------
Martin Gencur <mgencur(a)redhat.com> changed the Status of [bug 1140518|https://bugzilla.redhat.com/show_bug.cgi?id=1140518] from ON_QA to VERIFIED
> Race condition in index initialization prevents nodes to start successfully on empty indexes
> --------------------------------------------------------------------------------------------
>
> Key: ISPN-4716
> URL: https://issues.jboss.org/browse/ISPN-4716
> Project: Infinispan
> Issue Type: Bug
> Components: Embedded Querying
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Fix For: 7.0.0.CR1
>
>
> The following stack is possible because a different engine could be initializing the same index after the check for a valid index to exist:
> {noformat}Caused by: org.hibernate.search.exception.SearchException: Could not initialize index
> at org.hibernate.search.store.impl.DirectoryProviderHelper.initializeIndexIfNeeded(DirectoryProviderHelper.java:146)
> at org.hibernate.search.infinispan.impl.InfinispanDirectoryProvider.start(InfinispanDirectoryProvider.java:73)
> at org.hibernate.search.indexes.impl.DirectoryBasedIndexManager.initialize(DirectoryBasedIndexManager.java:90)
> at org.hibernate.search.indexes.impl.IndexManagerHolder.createIndexManager(IndexManagerHolder.java:256)
> ... 49 more
> Caused by: org.apache.lucene.store.LockObtainFailedException: Lock obtain timed out: org.infinispan.lucene.locking.BaseLuceneLock@1329a963
> at org.apache.lucene.store.Lock.obtain(Lock.java:89)
> at org.apache.lucene.index.IndexWriter.<init>(IndexWriter.java:710)
> at org.hibernate.search.store.impl.DirectoryProviderHelper.initializeIndexIfNeeded(DirectoryProviderHelper.java:141){noformat}
> Fixed by https://hibernate.atlassian.net/browse/HSEARCH-1665, Infinispan needs to upgrade.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (ISPN-4804) DeltaReplicationTest.testDeltasAreSent random failure
by Adrian Nistor (JIRA)
[ https://issues.jboss.org/browse/ISPN-4804?page=com.atlassian.jira.plugin.... ]
Adrian Nistor updated ISPN-4804:
--------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Integrated. Thanks [~gustavonalle]!
> DeltaReplicationTest.testDeltasAreSent random failure
> -----------------------------------------------------
>
> Key: ISPN-4804
> URL: https://issues.jboss.org/browse/ISPN-4804
> Project: Infinispan
> Issue Type: Bug
> Components: Lucene Directory, Test Suite - Query
> Affects Versions: 7.0.0.Beta2
> Reporter: Dan Berindei
> Assignee: Gustavo Fernandes
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 7.0.0.CR1
>
>
> {noformat}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
> at java.util.HashMap$KeyIterator.next(HashMap.java:956)
> at org.infinispan.lucene.impl.DeltaReplicationTest.assertOnlyDeltasWereSent(DeltaReplicationTest.java:71)
> at org.infinispan.lucene.impl.DeltaReplicationTest.testDeltasAreSent(DeltaReplicationTest.java:66)
> {noformat}
> Could be because the `InboundInvocationHandlerDecorator.writeCommands` set is accessed from multiple threads without synchronization.
> http://ci.infinispan.org/viewLog.html?buildId=12730&buildTypeId=bt9
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (ISPN-4710) DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-4710?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-4710:
------------------------------------
Status: Open (was: New)
> DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
> -------------------------------------------------------------------------------
>
> Key: ISPN-4710
> URL: https://issues.jboss.org/browse/ISPN-4710
> Project: Infinispan
> Issue Type: Enhancement
> Components: Lucene Directory
> Reporter: Sanne Grinovero
> Assignee: Gustavo Fernandes
> Fix For: 7.0.0.CR1
>
>
> Both of these methods:
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
> Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
> The determining factor between the two styles is defined in:
> {{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
> {code} @Override
> public IndexInput openInput(final String name, final IOContext context) throws IOException {
> final IndexInputContext indexInputContext = impl.openInput(name);
> if ( indexInputContext.readLocks == null ) {
> return new SingleChunkIndexInput(indexInputContext);
> }
> else {
> return new InfinispanIndexInput(indexInputContext);
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (ISPN-4710) DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-4710?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-4710:
------------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/2929
> DistributedSegmentReadLocker should be allowed to skip ReadLocks on small files
> -------------------------------------------------------------------------------
>
> Key: ISPN-4710
> URL: https://issues.jboss.org/browse/ISPN-4710
> Project: Infinispan
> Issue Type: Enhancement
> Components: Lucene Directory
> Reporter: Sanne Grinovero
> Assignee: Gustavo Fernandes
> Fix For: 7.0.0.CR1
>
>
> Both of these methods:
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.deleteOrReleaseReadLock(String)}}
> - {{org.infinispan.lucene.readlocks.DistributedSegmentReadLocker.realFileDelete(FileReadLockKey, AdvancedCache<Object, Integer>, AdvancedCache<?, ?>, AdvancedCache<?, ?>, boolean)}}
> Are performing a lot of unnecessary operations - potentially on synchronous clustered caches - as we know in advance that files which are not being chunked don't need a read lock, and are not being chunked in smaller pieces (which affects how we delete things).
> The determining factor between the two styles is defined in:
> {{org.infinispan.lucene.impl.DirectoryLuceneV4.openInput(String, IOContext)}}
> {code} @Override
> public IndexInput openInput(final String name, final IOContext context) throws IOException {
> final IndexInputContext indexInputContext = impl.openInput(name);
> if ( indexInputContext.readLocks == null ) {
> return new SingleChunkIndexInput(indexInputContext);
> }
> else {
> return new InfinispanIndexInput(indexInputContext);
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months
[JBoss JIRA] (ISPN-4804) DeltaReplicationTest.testDeltasAreSent random failure
by Gustavo Fernandes (JIRA)
[ https://issues.jboss.org/browse/ISPN-4804?page=com.atlassian.jira.plugin.... ]
Gustavo Fernandes updated ISPN-4804:
------------------------------------
Status: Open (was: New)
> DeltaReplicationTest.testDeltasAreSent random failure
> -----------------------------------------------------
>
> Key: ISPN-4804
> URL: https://issues.jboss.org/browse/ISPN-4804
> Project: Infinispan
> Issue Type: Bug
> Components: Lucene Directory, Test Suite - Query
> Affects Versions: 7.0.0.Beta2
> Reporter: Dan Berindei
> Assignee: Gustavo Fernandes
> Priority: Critical
> Labels: testsuite_stability
> Fix For: 7.0.0.CR1
>
>
> {noformat}
> java.util.ConcurrentModificationException
> at java.util.HashMap$HashIterator.nextEntry(HashMap.java:922)
> at java.util.HashMap$KeyIterator.next(HashMap.java:956)
> at org.infinispan.lucene.impl.DeltaReplicationTest.assertOnlyDeltasWereSent(DeltaReplicationTest.java:71)
> at org.infinispan.lucene.impl.DeltaReplicationTest.testDeltasAreSent(DeltaReplicationTest.java:66)
> {noformat}
> Could be because the `InboundInvocationHandlerDecorator.writeCommands` set is accessed from multiple threads without synchronization.
> http://ci.infinispan.org/viewLog.html?buildId=12730&buildTypeId=bt9
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 6 months