[JBoss JIRA] (ISPN-7081) Console Typescript Refactoring
by Ryan Emerson (JIRA)
Ryan Emerson created ISPN-7081:
----------------------------------
Summary: Console Typescript Refactoring
Key: ISPN-7081
URL: https://issues.jboss.org/browse/ISPN-7081
Project: Infinispan
Issue Type: Enhancement
Components: Console
Affects Versions: 9.0.0.Alpha4
Reporter: Ryan Emerson
Assignee: Ryan Emerson
In order to improve the extensibility of the existing console code (vanilla javascript), it is necessary for the angular services which drive the console to be refactored. Consequently, this means that the majority of the angular controllers and directives also need to be refactored to incorporate the aforementioned service changes. Therefore, as extensive changes to the code are already required, this is an ideal opportunity for the console code to be rewritten in Typescript.
The advantages of porting to Typescript are as follows:
* Statically typed - errors can be discovered at compile time and improved IDE support.
* Utilises ES6 modules, which allows for better adherence to DRY principles
* Typescript is the basis of Angular 2.x, which we hope to migrate to eventually
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-7080) NPE in CacheNotifierImpl by LIRS eviction listener
by ted won (JIRA)
[ https://issues.jboss.org/browse/ISPN-7080?page=com.atlassian.jira.plugin.... ]
ted won updated ISPN-7080:
--------------------------
Description:
The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method in core module fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
https://github.com/infinispan/infinispan/blob/master/core/src/test/java/o...
It reproduces only with LIRS eviction strategy and eviction listener.
However, LRU and UNORDERED eviction strategies are working properly.
It makes impossible the use of eviction listeners with LIRS eviction strategy.
It's able to reproduce by:
- inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
- and then reinsert the first 10 keys (key-1 to key-10)
was:
The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method in core module fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
It reproduces only with LIRS eviction strategy and eviction listener.
However, LRU and UNORDERED eviction strategies are working properly.
It makes impossible the use of eviction listeners with LIRS eviction strategy.
It's able to reproduce by:
- inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
- and then reinsert the first 10 keys (key-1 to key-10)
> NPE in CacheNotifierImpl by LIRS eviction listener
> ---------------------------------------------------
>
> Key: ISPN-7080
> URL: https://issues.jboss.org/browse/ISPN-7080
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.0.0.Alpha4
> Environment: * Infinispan branch: Upstream master
> Reporter: ted won
> Assignee: ted won
> Labels: core, eviction, lirs
>
> The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method in core module fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
> https://github.com/infinispan/infinispan/blob/master/core/src/test/java/o...
> It reproduces only with LIRS eviction strategy and eviction listener.
> However, LRU and UNORDERED eviction strategies are working properly.
> It makes impossible the use of eviction listeners with LIRS eviction strategy.
> It's able to reproduce by:
> - inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
> - and then reinsert the first 10 keys (key-1 to key-10)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-7080) NPE in CacheNotifierImpl by LIRS eviction listener
by ted won (JIRA)
[ https://issues.jboss.org/browse/ISPN-7080?page=com.atlassian.jira.plugin.... ]
ted won updated ISPN-7080:
--------------------------
Description:
The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method in core module fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
It reproduces only with LIRS eviction strategy and eviction listener.
However, LRU and UNORDERED eviction strategies are working properly.
It makes impossible the use of eviction listeners with LIRS eviction strategy.
It's able to reproduce by:
- inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
- and then reinsert the first 10 keys (key-1 to key-10)
was:
The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
It reproduces only with LIRS eviction strategy and eviction listener.
However, LRU and UNORDERED eviction strategies are working properly.
It makes impossible the use of eviction listeners with LIRS eviction strategy.
It's able to reproduce by:
- inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
- and then reinsert the first 10 keys (key-1 to key-10)
> NPE in CacheNotifierImpl by LIRS eviction listener
> ---------------------------------------------------
>
> Key: ISPN-7080
> URL: https://issues.jboss.org/browse/ISPN-7080
> Project: Infinispan
> Issue Type: Bug
> Components: Test Suite - Core
> Affects Versions: 9.0.0.Alpha4
> Environment: * Infinispan branch: Upstream master
> Reporter: ted won
> Assignee: ted won
> Labels: core, eviction, lirs
>
> The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method in core module fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
> It reproduces only with LIRS eviction strategy and eviction listener.
> However, LRU and UNORDERED eviction strategies are working properly.
> It makes impossible the use of eviction listeners with LIRS eviction strategy.
> It's able to reproduce by:
> - inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
> - and then reinsert the first 10 keys (key-1 to key-10)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-7080) NPE in CacheNotifierImpl by LIRS eviction listener
by ted won (JIRA)
ted won created ISPN-7080:
-----------------------------
Summary: NPE in CacheNotifierImpl by LIRS eviction listener
Key: ISPN-7080
URL: https://issues.jboss.org/browse/ISPN-7080
Project: Infinispan
Issue Type: Bug
Components: Test Suite - Core
Affects Versions: 9.0.0.Alpha4
Environment: * Infinispan branch: Upstream master
Reporter: ted won
Assignee: ted won
The LIRSEvictionFunctionalTest.testSimpleEvictionMaxEntries unit test method fails and throws NPE in CacheNotifierImpl.notifyCacheEntriesEvicted method when trying to reinsert the first keys again.
It reproduces only with LIRS eviction strategy and eviction listener.
However, LRU and UNORDERED eviction strategies are working properly.
It makes impossible the use of eviction listeners with LIRS eviction strategy.
It's able to reproduce by:
- inserting 20 keys - values in a 10 sized cache ( keys from key-1 to key-20),
- and then reinsert the first 10 keys (key-1 to key-10)
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-7079) TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
by William Burns (JIRA)
William Burns created ISPN-7079:
-----------------------------------
Summary: TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
Key: ISPN-7079
URL: https://issues.jboss.org/browse/ISPN-7079
Project: Infinispan
Issue Type: Bug
Affects Versions: 8.1.0.Final
Reporter: Patrick Ruckstuhl
Assignee: William Burns
Fix For: 9.0.0.Beta1, 8.2.5.Final, 8.1.6.Final
TransactionAwareKeyCloseableIterator.remove is implemented as
{code:java}
cache.remove(previousValue);
{code}
But looking at the previousValue it never gets set. This results then in
{code}
java.lang.NullPointerException: Null keys are not supported!
at org.infinispan.cache.impl.CacheImpl.assertKeyNotNull(CacheImpl.java:224)
at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:547)
at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:543)
at org.infinispan.interceptors.TxInterceptor$TransactionAwareKeyCloseableIterator.remove(TxInterceptor.java:568)
{code}
I encountered this when trying to switch infinispan from 7.2 to 8.1 in conjunction with hibernate-infinispan 4.3 which does the following code to clear the cache:
{code:java}
public static void removeAll(AdvancedCache cache) {
try {
Iterator it = cache.keySet().iterator();
while (it.hasNext()) {
it.next(); // Necessary to get next element
it.remove();
}
} catch (UnsupportedOperationException e) {
// Fallback on using clear for older version
cache.clear();
}
}
{code}
from https://github.com/hibernate/hibernate-orm/blob/4.3/hibernate-infinispan/...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-6045) TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-6045?page=com.atlassian.jira.plugin.... ]
William Burns updated ISPN-6045:
--------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/4595
> TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
> ---------------------------------------------------------------------------------
>
> Key: ISPN-6045
> URL: https://issues.jboss.org/browse/ISPN-6045
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.1.0.Final
> Reporter: Patrick Ruckstuhl
> Assignee: William Burns
> Fix For: 9.0.0.Beta1, 8.2.5.Final, 8.1.6.Final
>
>
> TransactionAwareKeyCloseableIterator.remove is implemented as
> {code:java}
> cache.remove(previousValue);
> {code}
> But looking at the previousValue it never gets set. This results then in
> {code}
> java.lang.NullPointerException: Null keys are not supported!
> at org.infinispan.cache.impl.CacheImpl.assertKeyNotNull(CacheImpl.java:224)
> at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:547)
> at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:543)
> at org.infinispan.interceptors.TxInterceptor$TransactionAwareKeyCloseableIterator.remove(TxInterceptor.java:568)
> {code}
> I encountered this when trying to switch infinispan from 7.2 to 8.1 in conjunction with hibernate-infinispan 4.3 which does the following code to clear the cache:
> {code:java}
> public static void removeAll(AdvancedCache cache) {
> try {
> Iterator it = cache.keySet().iterator();
> while (it.hasNext()) {
> it.next(); // Necessary to get next element
> it.remove();
> }
> } catch (UnsupportedOperationException e) {
> // Fallback on using clear for older version
> cache.clear();
> }
> }
> {code}
> from https://github.com/hibernate/hibernate-orm/blob/4.3/hibernate-infinispan/...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-6045) TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
by William Burns (JIRA)
[ https://issues.jboss.org/browse/ISPN-6045?page=com.atlassian.jira.plugin.... ]
William Burns resolved ISPN-6045.
---------------------------------
Fix Version/s: 9.0.0.Beta1
8.2.5.Final
8.1.6.Final
Assignee: William Burns
Resolution: Done
> TransactionAwareKeyCloseableIterator.remove uses previousValue which is never set
> ---------------------------------------------------------------------------------
>
> Key: ISPN-6045
> URL: https://issues.jboss.org/browse/ISPN-6045
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.1.0.Final
> Reporter: Patrick Ruckstuhl
> Assignee: William Burns
> Fix For: 9.0.0.Beta1, 8.2.5.Final, 8.1.6.Final
>
>
> TransactionAwareKeyCloseableIterator.remove is implemented as
> {code:java}
> cache.remove(previousValue);
> {code}
> But looking at the previousValue it never gets set. This results then in
> {code}
> java.lang.NullPointerException: Null keys are not supported!
> at org.infinispan.cache.impl.CacheImpl.assertKeyNotNull(CacheImpl.java:224)
> at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:547)
> at org.infinispan.cache.impl.CacheImpl.remove(CacheImpl.java:543)
> at org.infinispan.interceptors.TxInterceptor$TransactionAwareKeyCloseableIterator.remove(TxInterceptor.java:568)
> {code}
> I encountered this when trying to switch infinispan from 7.2 to 8.1 in conjunction with hibernate-infinispan 4.3 which does the following code to clear the cache:
> {code:java}
> public static void removeAll(AdvancedCache cache) {
> try {
> Iterator it = cache.keySet().iterator();
> while (it.hasNext()) {
> it.next(); // Necessary to get next element
> it.remove();
> }
> } catch (UnsupportedOperationException e) {
> // Fallback on using clear for older version
> cache.clear();
> }
> }
> {code}
> from https://github.com/hibernate/hibernate-orm/blob/4.3/hibernate-infinispan/...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-6857) OutdatedTopologyException in clustered invalidation cache because StateTransferInterceptor not in the chain
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6857?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6857:
----------------------------------
Status: Pull Request Sent (was: Reopened)
> OutdatedTopologyException in clustered invalidation cache because StateTransferInterceptor not in the chain
> -----------------------------------------------------------------------------------------------------------
>
> Key: ISPN-6857
> URL: https://issues.jboss.org/browse/ISPN-6857
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.1.0.Final, 9.0.0.Alpha4, 8.2.4.Final
> Reporter: Marek Posolda
> Assignee: Dan Berindei
> Fix For: 9.0.0.Final, 8.2.5.Final, 8.1.6.Final
>
> Attachments: OutdatedTopologyExceptionReproducerTest.java
>
>
> I have the following setup:
> - 2 nodes in cluster with mode INVALIDATION_SYNC. No-transaction cache.
> - Node1 is started
> - Called "cache.remove" on some key on node1. At the same time, node2 is starting, which is causing topology change.
> - The "cache.remove" call on node1 is throwing OutdatedTopologyException.
> I found the cause is that StateTransferInterceptor is not added in InterceptorChain during INVALIDATION mode. It's just available during REPLICATION or DISTRIBUTED modes - https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
> Indeed when I manually added StateTransferInterceptor to my invalidation cache:
> {code}
> invalidationConfigBuilder.customInterceptors()
> .addInterceptor()
> .before(NonTransactionalLockingInterceptor.class)
> .interceptorClass(StateTransferInterceptor.class);
> {code}
>
> I can see that issue is gone as OutdatedTopologyException is catched and command is retried with new topology.
> I am attaching the Java unit test for reproducing issue. On my laptop when I run it, I can almost always simulate the issue.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months
[JBoss JIRA] (ISPN-6857) OutdatedTopologyException in clustered invalidation cache because StateTransferInterceptor not in the chain
by Tristan Tarrant (JIRA)
[ https://issues.jboss.org/browse/ISPN-6857?page=com.atlassian.jira.plugin.... ]
Tristan Tarrant updated ISPN-6857:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 8.1.6.Final
Resolution: Done
> OutdatedTopologyException in clustered invalidation cache because StateTransferInterceptor not in the chain
> -----------------------------------------------------------------------------------------------------------
>
> Key: ISPN-6857
> URL: https://issues.jboss.org/browse/ISPN-6857
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 8.1.0.Final, 9.0.0.Alpha4, 8.2.4.Final
> Reporter: Marek Posolda
> Assignee: Dan Berindei
> Fix For: 9.0.0.Final, 8.2.5.Final, 8.1.6.Final
>
> Attachments: OutdatedTopologyExceptionReproducerTest.java
>
>
> I have the following setup:
> - 2 nodes in cluster with mode INVALIDATION_SYNC. No-transaction cache.
> - Node1 is started
> - Called "cache.remove" on some key on node1. At the same time, node2 is starting, which is causing topology change.
> - The "cache.remove" call on node1 is throwing OutdatedTopologyException.
> I found the cause is that StateTransferInterceptor is not added in InterceptorChain during INVALIDATION mode. It's just available during REPLICATION or DISTRIBUTED modes - https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
> Indeed when I manually added StateTransferInterceptor to my invalidation cache:
> {code}
> invalidationConfigBuilder.customInterceptors()
> .addInterceptor()
> .before(NonTransactionalLockingInterceptor.class)
> .interceptorClass(StateTransferInterceptor.class);
> {code}
>
> I can see that issue is gone as OutdatedTopologyException is catched and command is retried with new topology.
> I am attaching the Java unit test for reproducing issue. On my laptop when I run it, I can almost always simulate the issue.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
7 years, 6 months