[JBoss JIRA] (ISPN-6647) DecoratedCache.putForExternalRead method with Metadata ignores Metadata
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6647?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6647:
--------------------------------------
Fix Version/s: 9.0.0.Alpha4
(was: 9.0.0.Alpha3)
> DecoratedCache.putForExternalRead method with Metadata ignores Metadata
> -----------------------------------------------------------------------
>
> Key: ISPN-6647
> URL: https://issues.jboss.org/browse/ISPN-6647
> Project: Infinispan
> Issue Type: Feature Request
> Components: Core
> Affects Versions: 8.2.2.Final
> Reporter: Karl von Randow
> Assignee: Karl von Randow
> Priority: Minor
> Fix For: 9.0.0.Alpha4, 8.2.4.Final
>
>
> The implementation of the {{putForExternalRead}} method ignores the {{Metadata}} parameter, instead of passing it on to the {{putForExternalRead}} method in the cache implementation. This is no doubt because the cache implementation previously didn't support {{Metadata}} for {{putForExternalRead}}.
> I will prepare a PR and attach it to this ticket shortly. It was a gargantuan effort to patch this up, as you'll see!
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6711) Shared stores should only be purged from coordinator
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6711?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6711:
--------------------------------------
Fix Version/s: 9.0.0.Alpha4
(was: 9.0.0.Alpha3)
> Shared stores should only be purged from coordinator
> ----------------------------------------------------
>
> Key: ISPN-6711
> URL: https://issues.jboss.org/browse/ISPN-6711
> Project: Infinispan
> Issue Type: Enhancement
> Reporter: William Burns
> Assignee: Ryan Emerson
> Fix For: 9.0.0.Alpha4
>
>
> A shared store's data is accessible from all nodes. Therefore we should only have to purge from 1 node instead of all. Thus we should only purge shared stores if the node is the coordinator. This will reduce possible load on the stores by an amount equal to the number of nodes in worst case, which could be huge.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6688) PreferAvailabilityStrategy: Improve selection of segment owners after merge
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6688?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6688:
--------------------------------------
Fix Version/s: 9.0.0.Alpha4
(was: 9.0.0.Alpha3)
> PreferAvailabilityStrategy: Improve selection of segment owners after merge
> ---------------------------------------------------------------------------
>
> Key: ISPN-6688
> URL: https://issues.jboss.org/browse/ISPN-6688
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 8.2.2.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 9.0.0.Alpha4, 9.0.0.Final
>
>
> {{PreferAvailabilityStrategy}} picks a winning CH after merge, but that CH is very likely to be the wrong one. We should improve our odds at preserving cache data by mixing CHs, and keeping from each node's response only the information about the segments it owns itself.
> The downside is that {{PreferAvailabilityStrategy}} becomes tightly coupled with {{DefaultConsistentHash}}/{{ReplicatedConsistentHash}}, and users that want to add custom {{ConsistentHash}} implementations will have to re-implement {{PreferAvailabilityStrategy}}.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6802) Micro-optimizations for read operations
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6802?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6802:
--------------------------------------
Fix Version/s: 9.0.0.Alpha4
(was: 9.0.0.Alpha3)
> Micro-optimizations for read operations
> ---------------------------------------
>
> Key: ISPN-6802
> URL: https://issues.jboss.org/browse/ISPN-6802
> Project: Infinispan
> Issue Type: Task
> Components: Core
> Affects Versions: 9.0.0.Alpha2
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Fix For: 9.0.0.Alpha4
>
>
> * L1 entries are written to the data container by L1TxInterceptor/L1NonTxInterceptor directly, so there is no reason to commit the context entries in EntryWrappingInterceptor or to clear the locks in the locking interceptors.
> * ClearCommands can no longer be wrapped in PrepareCommands, so we can stop the state transfer in {{EntryWrappingInterceptor.visitClearCommand()}} instead of checking the type for each command.
> * In transactional caches, a read operation without an explicit transaction triggers two queries for the current transaction to the transaction manager, which usually means 2 thread-local lookups.
> * IsMarshallerInterceptor shouldn't do anything unless there is an asynchronous store
> * Transactional remote get commands use NonTxInvocationInterceptor instead of SingleKeyNonTxInterceptor.
> * Configuration attributes should be cached, as reading them requires accessing multiple instances + a cast in Attribute.get()
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months
[JBoss JIRA] (ISPN-6745) Locks are lost in pessimistic cache
by Vladimir Blagojevic (JIRA)
[ https://issues.jboss.org/browse/ISPN-6745?page=com.atlassian.jira.plugin.... ]
Vladimir Blagojevic updated ISPN-6745:
--------------------------------------
Fix Version/s: 9.0.0.Alpha4
(was: 9.0.0.Alpha3)
> Locks are lost in pessimistic cache
> -----------------------------------
>
> Key: ISPN-6745
> URL: https://issues.jboss.org/browse/ISPN-6745
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 7.2.3.Final
> Environment: JBoss DataGrid 6.5.0 (6.3.1.Final-redhat-1)
> 3 nodes in REPL_SYNC mode
> pessimistic locking
> read committed isolation
> Reporter: Eugene Scripnik
> Assignee: Pedro Ruivo
> Fix For: 9.0.0.Alpha4
>
> Attachments: InfinispanNodeFailureTest.java
>
>
> When you perform multiple TX write operations in one transaction (put, replace, lock, etc) and one of the nodes goes down, there is a slight chance that some locks will be lost and acquired by another transaction before current transaction ends.
> So client ends up with two transactions holding the same lock on pessimistic cache at the same time. Both transactions commit at the end successfully.
> I spent some time debugging infinispan code and found that PessimisticLockingInterceptor#releaseLocksOnFailureBeforePrepare releases all locks when OutdatedTopologyException occurs on remote node. But then StateTransferInterceptor#handleTxWriteCommand retries last command. This behavior produces inconsistent state - all locks before last command are released and any other transaction can acquire them.
> I am attaching Test which reproduces this problem
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 6 months