July 2016 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (IPROTO-10) Default value is not used when reading a required field from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Default value is not used when reading a required field from a stream which does not contain the field > ------------------------------------------------------------------------------------------------------ > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading a required field from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Status: Pull Request Sent (was: Coding In Progress) Git Pull Request: https://github.com/infinispan/protostream/pull/26 > Default value is not used when reading a required field from a stream which does not contain the field > ------------------------------------------------------------------------------------------------------ > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading a required field from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Summary: Default value is not used when reading a required field from a stream which does not contain the field (was: Default value is not used when reading from a stream which does not contain the field) > Default value is not used when reading a required field from a stream which does not contain the field > ------------------------------------------------------------------------------------------------------ > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Status: Open (was: New) > Default value is not used when reading from a stream which does not contain the field > ------------------------------------------------------------------------------------- > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Affects Version/s: 3.0.5.Final > Default value is not used when reading from a stream which does not contain the field > ------------------------------------------------------------------------------------- > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated IPROTO-10: -------------------------------- Fix Version/s: 3.0.6.Final > Default value is not used when reading from a stream which does not contain the field > ------------------------------------------------------------------------------------- > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading from a stream which does not contain the field

by Adrian Nistor (JIRA)

[ https://issues.jboss.org/browse/IPROTO-10?page=com.atlassian.jira.plugin.... ] Work on IPROTO-10 started by Adrian Nistor. ------------------------------------------- > Default value is not used when reading from a stream which does not contain the field > ------------------------------------------------------------------------------------- > > Key: IPROTO-10 > URL: https://issues.jboss.org/browse/IPROTO-10 > Project: Infinispan ProtoStream > Issue Type: Bug > Affects Versions: 3.0.5.Final > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Fix For: 3.0.6.Final > > > This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (IPROTO-10) Default value is not used when reading from a stream which does not contain the field

by Adrian Nistor (JIRA)

Adrian Nistor created IPROTO-10: ----------------------------------- Summary: Default value is not used when reading from a stream which does not contain the field Key: IPROTO-10 URL: https://issues.jboss.org/browse/IPROTO-10 Project: Infinispan ProtoStream Issue Type: Bug Reporter: Adrian Nistor This issue can appear if a field is first optional and later is marked required in the schema and a default value is assigned. When reading from a stream encoded with the first version of the schema we might not see the field and would expect the missing value to be replaced with the default. Default values do not work in this particular case. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6773) Metadata updates get dropped with Functional API

by Sebastian Łaskawiec (JIRA)

[ https://issues.jboss.org/browse/ISPN-6773?page=com.atlassian.jira.plugin.... ] Sebastian Łaskawiec updated ISPN-6773: -------------------------------------- Fix Version/s: 8.2.3.Final > Metadata updates get dropped with Functional API > ------------------------------------------------ > > Key: ISPN-6773 > URL: https://issues.jboss.org/browse/ISPN-6773 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 9.0.0.Alpha2, 8.2.2.Final > Reporter: Krzysztof Sobolewski > Assignee: Krzysztof Sobolewski > Fix For: 9.0.0.Alpha3, 8.2.3.Final > > > I have a CacheLoader that injects EmbeddedMetadata so that I can specify the lifetime of the newly loaded entry. EmbeddedMetadata is supposed to be used when only lifespan or maxIdle are required (I only need lifespan); this works because the lifespan (and maxIdle) information is copied into the internal node itself - no extra Metadata object is allocated. > The InternalNode has several implementations, each used for the different combination of lifespan and maxIdle. Let's proceed with MortalCacheEntry (lifespan only). Its metadata-aware sibling is MetadataMortalCacheEntry. Each of those has a special code path in EntryWrappingInterceptor for updates of metadata. This path is chosen not based on the type of the InternalEntry (so that it can also work for new entries, where there's no internal entry object yet) but instead the decision is made in InternalEntryFactoryImpl.isStoreMetadata() based on the type of the Metadata object - if it returns true, then the path for MetadataMortalCacheEntry is used. This path then inspects the actual type of the internal entry object so that can update it accordingly. > Enter Functional API. > After I return EmbeddedMetadata from the CacheLoader, the expiration parameters are updated just fine - the EmbeddedMetadata is recognized and a MortalCacheEntry is created with the expected lifespan. Then, when we use {code:java}EntryView.WriteEntryView.set(value, params...){code} to update the metadata (which is the only way to do that in Functional API), the Metadata object in the entry gets replaced with an instance of MetaParamsInternalMetadata. This makes isStoreMetadata() return true (because the Metadata object is no longer EmbeddedMetadata). EntryWrappingInterceptor then goes into the metadata-aware code path where MortalCacheEntry is not handled (MetadataMortalCacheEntry is instead) and the metadata update is not performed at all. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

[JBoss JIRA] (ISPN-6773) Metadata updates get dropped with Functional API

by Sebastian Łaskawiec (JIRA)

[ https://issues.jboss.org/browse/ISPN-6773?page=com.atlassian.jira.plugin.... ] Sebastian Łaskawiec resolved ISPN-6773. --------------------------------------- Resolution: Done > Metadata updates get dropped with Functional API > ------------------------------------------------ > > Key: ISPN-6773 > URL: https://issues.jboss.org/browse/ISPN-6773 > Project: Infinispan > Issue Type: Bug > Components: Core > Affects Versions: 9.0.0.Alpha2, 8.2.2.Final > Reporter: Krzysztof Sobolewski > Assignee: Krzysztof Sobolewski > Fix For: 9.0.0.Alpha3, 8.2.3.Final > > > I have a CacheLoader that injects EmbeddedMetadata so that I can specify the lifetime of the newly loaded entry. EmbeddedMetadata is supposed to be used when only lifespan or maxIdle are required (I only need lifespan); this works because the lifespan (and maxIdle) information is copied into the internal node itself - no extra Metadata object is allocated. > The InternalNode has several implementations, each used for the different combination of lifespan and maxIdle. Let's proceed with MortalCacheEntry (lifespan only). Its metadata-aware sibling is MetadataMortalCacheEntry. Each of those has a special code path in EntryWrappingInterceptor for updates of metadata. This path is chosen not based on the type of the InternalEntry (so that it can also work for new entries, where there's no internal entry object yet) but instead the decision is made in InternalEntryFactoryImpl.isStoreMetadata() based on the type of the Metadata object - if it returns true, then the path for MetadataMortalCacheEntry is used. This path then inspects the actual type of the internal entry object so that can update it accordingly. > Enter Functional API. > After I return EmbeddedMetadata from the CacheLoader, the expiration parameters are updated just fine - the EmbeddedMetadata is recognized and a MortalCacheEntry is created with the expected lifespan. Then, when we use {code:java}EntryView.WriteEntryView.set(value, params...){code} to update the metadata (which is the only way to do that in Functional API), the Metadata object in the entry gets replaced with an instance of MetaParamsInternalMetadata. This makes isStoreMetadata() return true (because the Metadata object is no longer EmbeddedMetadata). EntryWrappingInterceptor then goes into the metadata-aware code path where MortalCacheEntry is not handled (MetadataMortalCacheEntry is instead) and the metadata update is not performed at all. -- This message was sent by Atlassian JIRA (v6.4.11#64026)

7 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues July 2016