[JBoss JIRA] (ISPN-8090) Functional commands don't support Data convertions In Transactional Caches
by Radim Vansa (JIRA)
[ https://issues.jboss.org/browse/ISPN-8090?page=com.atlassian.jira.plugin.... ]
Radim Vansa commented on ISPN-8090:
-----------------------------------
1) The encoding classes are stored in each command, so I guess that {{FunctionalCommand.toMutation}} has to pass the encoding classes when creating the mutation.
2) Mutations are a "simplification":
a) Mutations don't have to marshall whole command (including key, command id, flags...), just the function itself. In your case, you may have to add the encoding classes, too.
b) There are no multi-key mutations; therefore if you have two multi-key functional commands modifying an entry and then a functional (single-key) read, you send only the data relevant to the one key. The logic of applying mutations can be simpler, too.
> Functional commands don't support Data convertions In Transactional Caches
> --------------------------------------------------------------------------
>
> Key: ISPN-8090
> URL: https://issues.jboss.org/browse/ISPN-8090
> Project: Infinispan
> Issue Type: Feature Request
> Reporter: Katia Aresti
> Assignee: Katia Aresti
>
> Functional Maps in Tx mode do not support encoding caches.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ISPN-8090) Functional commands don't support Data convertions In Transactional Caches
by Katia Aresti (JIRA)
[ https://issues.jboss.org/browse/ISPN-8090?page=com.atlassian.jira.plugin.... ]
Katia Aresti commented on ISPN-8090:
------------------------------------
[~rvansa]There is an issue with the TxDistributionInterceptor that I don't know how to resolve for this case in the actual Infinispan Architecture. I might be missing something and this might be simple, but I don't see it.
In this class the method
{code:java}
protected <C extends FlagAffectedCommand & TopologyAffectedCommand> CompletableFuture<Void> remoteGet(InvocationContext ctx, C command, Object key, boolean isWrite) {
CompletableFuture<Void> cf = super.remoteGet(ctx, command, key, isWrite);
// If the remoteGet is executed on non-origin node, the mutations list already contains all modifications
// and we are just trying to execute all of them from EntryWrappingIntercepot$EntryWrappingVisitor
if (!ctx.isOriginLocal() || !ctx.isInTxScope()) {
return cf;
}
List<Mutation> mutationsOnKey = getMutationsOnKey((TxInvocationContext) ctx, key);
if (mutationsOnKey.isEmpty()) {
return cf;
}
return cf.thenRun(() -> {
entryFactory.wrapEntryForWriting(ctx, key, false, true);
MVCCEntry cacheEntry = (MVCCEntry) ctx.lookupEntry(key);
* EntryView.ReadWriteEntryView readWriteEntryView = EntryViews.readWrite(cacheEntry, cacheEncoders);*
for (Mutation mutation : mutationsOnKey) {
mutation.apply(readWriteEntryView);
cacheEntry.updatePreviousValue();
}
});
}{code}
For this to work today, the EntryViews need to be aware of encoding/decoding as the lambdas modify the cache entry. The problem in this method is, how can I retrieve the encoding classes ? They are today configured - as I see in the code, but I might be missing something- through advancedCache and not the cache configuration. So how retrieve the encoders from there ?
Appart from that, I find hard to understand why is this method using functional command specific code (Mutations seem related just to Functional Commands), I guess this is related to the complexity of Tx and Functional Commands changing the entry values inside the lambdas ?
I decided to open a new issue to handle TX + Encoding specifically here. I managed to make most of the tests work but there is a big issue on this matter and it deserves it's own ticket.
> Functional commands don't support Data convertions In Transactional Caches
> --------------------------------------------------------------------------
>
> Key: ISPN-8090
> URL: https://issues.jboss.org/browse/ISPN-8090
> Project: Infinispan
> Issue Type: Feature Request
> Reporter: Katia Aresti
> Assignee: Katia Aresti
>
> Functional Maps in Tx mode do not support encoding caches.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ISPN-6951) SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave fails
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-6951?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo closed ISPN-6951.
-----------------------------
Resolution: Duplicate Issue
> SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave fails
> ------------------------------------------------------------
>
> Key: ISPN-6951
> URL: https://issues.jboss.org/browse/ISPN-6951
> Project: Infinispan
> Issue Type: Bug
> Components: Cross-Site Replication
> Reporter: Sebastian Łaskawiec
> Assignee: Pedro Ruivo
> Priority: Critical
>
> http://ci.infinispan.org/project.html?projectId=Infinispan&testNameId=289...
> {noformat}
> java.lang.AssertionError: expected:<ok> but was:<Unable to pushState to 'NYC'. org.infinispan.commons.CacheException: Problems invoking command.>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:101)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:108)
> at org.infinispan.xsite.statetransfer.failures.AbstractTopologyChangeTest.startStateTransfer(AbstractTopologyChangeTest.java:144)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.doXSiteStateTransferDuringTopologyChange(SiteConsumerTopologyChangeTest.java:174)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave(SiteConsumerTopologyChangeTest.java:59)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> ------- Stdout: -------
> [TestSuiteProgress] Test starting: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> 22:43:18,511 ERROR (testng-SiteConsumerTopologyChangeTest) [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> java.lang.AssertionError: expected:<ok> but was:<Unable to pushState to 'NYC'. org.infinispan.commons.CacheException: Problems invoking command.>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:101)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:108)
> at org.infinispan.xsite.statetransfer.failures.AbstractTopologyChangeTest.startStateTransfer(AbstractTopologyChangeTest.java:144)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.doXSiteStateTransferDuringTopologyChange(SiteConsumerTopologyChangeTest.java:174)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave(SiteConsumerTopologyChangeTest.java:59)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)[TestSuiteProgress] Tests succeeded: 63, failed: 1, skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ISPN-6872) SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave fails
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-6872?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-6872:
------------------------------
Component/s: Cross-Site Replication
> SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave fails
> -----------------------------------------------------------
>
> Key: ISPN-6872
> URL: https://issues.jboss.org/browse/ISPN-6872
> Project: Infinispan
> Issue Type: Bug
> Components: Cross-Site Replication
> Reporter: Sebastian Łaskawiec
> Assignee: Pedro Ruivo
>
> http://ci.infinispan.org/viewLog.html?buildId=41169&tab=buildResultsDiv&b...
> {code}
> java.lang.AssertionError: expected:<ok> but was:<Unable to pushState to 'NYC'. org.infinispan.commons.CacheException: Problems invoking command.>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:101)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:108)
> at org.infinispan.xsite.statetransfer.failures.AbstractTopologyChangeTest.startStateTransfer(AbstractTopologyChangeTest.java:144)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.doXSiteStateTransferDuringTopologyChange(SiteConsumerTopologyChangeTest.java:174)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave(SiteConsumerTopologyChangeTest.java:59)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> ------- Stdout: -------
> [TestSuiteProgress] Test starting: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> 13:00:25,879 ERROR (testng-SiteConsumerTopologyChangeTest) [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave
> java.lang.AssertionError: expected:<ok> but was:<Unable to pushState to 'NYC'. org.infinispan.commons.CacheException: Problems invoking command.>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:101)
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:108)
> at org.infinispan.xsite.statetransfer.failures.AbstractTopologyChangeTest.startStateTransfer(AbstractTopologyChangeTest.java:144)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.doXSiteStateTransferDuringTopologyChange(SiteConsumerTopologyChangeTest.java:174)
> at org.infinispan.xsite.statetransfer.failures.SiteConsumerTopologyChangeTest.testXSiteSTDuringLeave(SiteConsumerTopologyChangeTest.java:59)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)[TestSuiteProgress] Tests succeeded: 63, failed: 1, skipped: 0
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months
[JBoss JIRA] (ISPN-7021) SiteProviderTopologyChangeTest.testJoinDuringXSiteST fails
by Pedro Ruivo (JIRA)
[ https://issues.jboss.org/browse/ISPN-7021?page=com.atlassian.jira.plugin.... ]
Pedro Ruivo updated ISPN-7021:
------------------------------
Component/s: Cross-Site Replication
> SiteProviderTopologyChangeTest.testJoinDuringXSiteST fails
> ----------------------------------------------------------
>
> Key: ISPN-7021
> URL: https://issues.jboss.org/browse/ISPN-7021
> Project: Infinispan
> Issue Type: Bug
> Components: Cross-Site Replication
> Reporter: Sebastian Łaskawiec
> Assignee: Pedro Ruivo
>
> http://ci.infinispan.org/viewLog.html?buildId=42202&tab=buildResultsDiv&b...
> {noformat}
> java.util.concurrent.TimeoutException: Timed out waiting for event before-second-chunk
> at org.infinispan.test.fwk.CheckPoint.awaitStrict(CheckPoint.java:43)
> at org.infinispan.test.fwk.CheckPoint.awaitStrict(CheckPoint.java:33)
> at org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.doTopologyChangeDuringXSiteStateTransfer(SiteProviderTopologyChangeTest.java:197)
> at org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.testJoinDuringXSiteST(SiteProviderTopologyChangeTest.java:61)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
> at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
> at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
> at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
> at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
> at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
> at org.testng.TestRunner.privateRun(TestRunner.java:767)
> at org.testng.TestRunner.run(TestRunner.java:617)
> at org.testng.SuiteRunner.runTest(SuiteRunner.java:348)
> at org.testng.SuiteRunner.access$000(SuiteRunner.java:38)
> at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:382)
> at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> ------- Stdout: -------
> [TestSuiteProgress] Test starting: org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.testJoinDuringXSiteST
> 14:25:39,327 ERROR (testng-SiteProviderTopologyChangeTest) [CheckPoint] Timed out waiting for event before-second-chunk * 1 (available = 0, total = 0
> [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.testJoinDuringXSiteST
> 14:25:39,327 ERROR (testng-SiteProviderTopologyChangeTest) [TestSuiteProgress] Test failed: org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.testJoinDuringXSiteST
> java.util.concurrent.TimeoutException: Timed out waiting for event before-second-chunk
> at org.infinispan.test.fwk.CheckPoint.awaitStrict(CheckPoint.java:43)
> at org.infinispan.test.fwk.CheckPoint.awaitStrict(CheckPoint.java:33)
> at org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.doTopologyChangeDuringXSiteStateTransfer(SiteProviderTopologyChangeTest.java:197)
> at org.infinispan.xsite.statetransfer.failures.SiteProviderTopologyChangeTest.testJoinDuringXSiteST(SiteProviderTopologyChangeTest.java:61)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)[TestSuiteProgress] Tests succeeded: 53, failed: 1, skipped: 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 8 months