January 2019 - infinispan-issues - Jboss List Archives

[JBoss JIRA] (ISPN-9864) Move non-API classes from org.infinispan.query.remote.client to org.infinispan.query.remote.client.impl package

by Adrian Nistor (Jira)

[ https://issues.jboss.org/browse/ISPN-9864?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-9864: -------------------------------- Status: Open (was: New) > Move non-API classes from org.infinispan.query.remote.client to org.infinispan.query.remote.client.impl package > --------------------------------------------------------------------------------------------------------------- > > Key: ISPN-9864 > URL: https://issues.jboss.org/browse/ISPN-9864 > Project: Infinispan > Issue Type: Task > Components: Remote Querying > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Priority: Major > Fix For: 10.0.0.Beta1 > > -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9864) Move non-API classes from org.infinispan.query.remote.client to org.infinispan.query.remote.client.impl package

by Adrian Nistor (Jira)

Adrian Nistor created ISPN-9864: ----------------------------------- Summary: Move non-API classes from org.infinispan.query.remote.client to org.infinispan.query.remote.client.impl package Key: ISPN-9864 URL: https://issues.jboss.org/browse/ISPN-9864 Project: Infinispan Issue Type: Task Components: Remote Querying Reporter: Adrian Nistor Assignee: Adrian Nistor Fix For: 10.0.0.Beta1 -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9863) Client testsuite leaks threads

by Dan Berindei (Jira)

Dan Berindei created ISPN-9863: ---------------------------------- Summary: Client testsuite leaks threads Key: ISPN-9863 URL: https://issues.jboss.org/browse/ISPN-9863 Project: Infinispan Issue Type: Bug Components: Test Suite - Server Affects Versions: 9.4.5.Final, 10.0.0.Alpha2 Reporter: Dan Berindei Assignee: Dan Berindei Fix For: 10.0.0.Beta1 Some hotrod-client tests do not stop their {{RemoteCacheManager}} instances. This was fine before ISPN-8619, but the Netty-based client starts event loop threads and we need to stop them. -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9862) Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers

by Adrian Nistor (Jira)

[ https://issues.jboss.org/browse/ISPN-9862?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-9862: -------------------------------- Status: Pull Request Sent (was: Open) Git Pull Request: https://github.com/infinispan/infinispan/pull/6588 > Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers > ----------------------------------------------------------------------------------- > > Key: ISPN-9862 > URL: https://issues.jboss.org/browse/ISPN-9862 > Project: Infinispan > Issue Type: Enhancement > Components: Remote Querying > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Priority: Major > Fix For: 10.0.0.Beta1 > > > This method should be split into 2 parts, one that registers the proto resources and one that registers the marshallers. This will help provide a private SPI for advanced usages that need to registers these marshallers but do not need to register the proto schemas as they are already registered. ;-) -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9861) Marshallers for remote querying should be public

by Adrian Nistor (Jira)

[ https://issues.jboss.org/browse/ISPN-9861?page=com.atlassian.jira.plugin.... ] Adrian Nistor closed ISPN-9861. ------------------------------- Resolution: Rejected Replaced by https://issues.jboss.org/browse/ISPN-9862 > Marshallers for remote querying should be public > ------------------------------------------------ > > Key: ISPN-9861 > URL: https://issues.jboss.org/browse/ISPN-9861 > Project: Infinispan > Issue Type: Task > Components: Remote Querying > Reporter: William Burns > Assignee: William Burns > Priority: Major > Fix For: 10.0.0.Beta1 > > > There are a number of marshallers that are registered to enable remote querying. These classes are currently only enabled via {code}MarshallerRegistration#registerMarshallers{code} method. These classes should be public to allow other methods if needed. > The marshallers used are currently: > {code} > ctx.registerMarshaller(new QueryRequest.NamedParameter.Marshaller()); > ctx.registerMarshaller(new QueryRequest.Marshaller()); > ctx.registerMarshaller(new QueryResponse.Marshaller()); > ctx.registerMarshaller(new FilterResult.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.ResultType.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.Marshaller()); > {code} > Note that the classes that are marshalled by these are all public, so there shouldn't be any harm in changing the visibility. -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9862) Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers

by Adrian Nistor (Jira)

Adrian Nistor created ISPN-9862: ----------------------------------- Summary: Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers Key: ISPN-9862 URL: https://issues.jboss.org/browse/ISPN-9862 Project: Infinispan Issue Type: Enhancement Components: Remote Querying Reporter: Adrian Nistor Assignee: Adrian Nistor Fix For: 10.0.0.Beta1 This method should be split into 2 parts, one that registers the proto resources and one that registers the marshallers. This will help provide a private SPI for advanced usages that need to registers these marshallers but do not need to register the proto schemas as they are already registered. ;-) -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9862) Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers

by Adrian Nistor (Jira)

[ https://issues.jboss.org/browse/ISPN-9862?page=com.atlassian.jira.plugin.... ] Adrian Nistor updated ISPN-9862: -------------------------------- Status: Open (was: New) > Split org.infinispan.query.remote.client.MarshallerRegistration.registerMarshallers > ----------------------------------------------------------------------------------- > > Key: ISPN-9862 > URL: https://issues.jboss.org/browse/ISPN-9862 > Project: Infinispan > Issue Type: Enhancement > Components: Remote Querying > Reporter: Adrian Nistor > Assignee: Adrian Nistor > Priority: Major > Fix For: 10.0.0.Beta1 > > > This method should be split into 2 parts, one that registers the proto resources and one that registers the marshallers. This will help provide a private SPI for advanced usages that need to registers these marshallers but do not need to register the proto schemas as they are already registered. ;-) -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9861) Marshallers for remote querying should be public

by William Burns (Jira)

[ https://issues.jboss.org/browse/ISPN-9861?page=com.atlassian.jira.plugin.... ] William Burns commented on ISPN-9861: ------------------------------------- If we can break up the two groups of MarshallerRegistration to two different methods that would work as a replacement instead of this. [~anistor] might be best if you did that, since you wanted more control about what was exposed where. > Marshallers for remote querying should be public > ------------------------------------------------ > > Key: ISPN-9861 > URL: https://issues.jboss.org/browse/ISPN-9861 > Project: Infinispan > Issue Type: Task > Components: Remote Querying > Reporter: William Burns > Assignee: William Burns > Priority: Major > Fix For: 10.0.0.Beta1 > > > There are a number of marshallers that are registered to enable remote querying. These classes are currently only enabled via {code}MarshallerRegistration#registerMarshallers{code} method. These classes should be public to allow other methods if needed. > The marshallers used are currently: > {code} > ctx.registerMarshaller(new QueryRequest.NamedParameter.Marshaller()); > ctx.registerMarshaller(new QueryRequest.Marshaller()); > ctx.registerMarshaller(new QueryResponse.Marshaller()); > ctx.registerMarshaller(new FilterResult.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.ResultType.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.Marshaller()); > {code} > Note that the classes that are marshalled by these are all public, so there shouldn't be any harm in changing the visibility. -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9861) Marshallers for remote querying should be public

by Adrian Nistor (Jira)

[ https://issues.jboss.org/browse/ISPN-9861?page=com.atlassian.jira.plugin.... ] Adrian Nistor commented on ISPN-9861: ------------------------------------- Many classes in org.infinispan.query.remote.client package should have been placed in org.infinispan.query.remote.client.impl to be hidden away from the user. They are public for other reasons than being a public API. So I'm not very keen to make even more things public here. Only BaseProtoStreamMarshaller and relatives should be public. Can't MarshallerRegistration be used for the purpose you intend [~william.burns]? > Marshallers for remote querying should be public > ------------------------------------------------ > > Key: ISPN-9861 > URL: https://issues.jboss.org/browse/ISPN-9861 > Project: Infinispan > Issue Type: Task > Components: Remote Querying > Reporter: William Burns > Assignee: William Burns > Priority: Major > Fix For: 10.0.0.Beta1 > > > There are a number of marshallers that are registered to enable remote querying. These classes are currently only enabled via {code}MarshallerRegistration#registerMarshallers{code} method. These classes should be public to allow other methods if needed. > The marshallers used are currently: > {code} > ctx.registerMarshaller(new QueryRequest.NamedParameter.Marshaller()); > ctx.registerMarshaller(new QueryRequest.Marshaller()); > ctx.registerMarshaller(new QueryResponse.Marshaller()); > ctx.registerMarshaller(new FilterResult.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.ResultType.Marshaller()); > ctx.registerMarshaller(new ContinuousQueryResult.Marshaller()); > {code} > Note that the classes that are marshalled by these are all public, so there shouldn't be any harm in changing the visibility. -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ISPN-9861) Marshallers for remote querying should be public

by William Burns (Jira)

William Burns created ISPN-9861: ----------------------------------- Summary: Marshallers for remote querying should be public Key: ISPN-9861 URL: https://issues.jboss.org/browse/ISPN-9861 Project: Infinispan Issue Type: Task Components: Remote Querying Reporter: William Burns Assignee: William Burns Fix For: 10.0.0.Beta1 There are a number of marshallers that are registered to enable remote querying. These classes are currently only enabled via {code}MarshallerRegistration#registerMarshallers{code} method. These classes should be public to allow other methods if needed. The marshallers used are currently: {code} ctx.registerMarshaller(new QueryRequest.NamedParameter.Marshaller()); ctx.registerMarshaller(new QueryRequest.Marshaller()); ctx.registerMarshaller(new QueryResponse.Marshaller()); ctx.registerMarshaller(new FilterResult.Marshaller()); ctx.registerMarshaller(new ContinuousQueryResult.ResultType.Marshaller()); ctx.registerMarshaller(new ContinuousQueryResult.Marshaller()); {code} Note that the classes that are marshalled by these are all public, so there shouldn't be any harm in changing the visibility. -- This message was sent by Atlassian Jira (v7.12.1#712002)

4 years, 4 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

infinispan-issues January 2019