[JBoss JIRA] (ISPN-11006) Remove REST v1 API
by Gustavo Fernandes (Jira)
Gustavo Fernandes created ISPN-11006:
----------------------------------------
Summary: Remove REST v1 API
Key: ISPN-11006
URL: https://issues.jboss.org/browse/ISPN-11006
Project: Infinispan
Issue Type: Bug
Components: REST
Affects Versions: 10.0.1.Final
Reporter: Gustavo Fernandes
Assignee: Gustavo Fernandes
Fix For: 11.0.0.Final
The legacy API was deprecated on 10.0
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11005) HotRod decoder small performance improvements
by Dan Berindei (Jira)
[ https://issues.jboss.org/browse/ISPN-11005?page=com.atlassian.jira.plugin... ]
Dan Berindei updated ISPN-11005:
--------------------------------
Priority: Minor (was: Major)
> HotRod decoder small performance improvements
> ---------------------------------------------
>
> Key: ISPN-11005
> URL: https://issues.jboss.org/browse/ISPN-11005
> Project: Infinispan
> Issue Type: Enhancement
> Components: Server
> Affects Versions: 10.1.0.Beta1
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Labels: performace
> Fix For: 10.1.0.CR1
>
>
> I noticed some small inefficiencies in the flight recordings from the client-server dist read benchmarks:
> * {{Intrinsics.string()}} allocates a temporary {{byte[]}}, we could use {{ByteBuf.toString(start, length, Charset)}} instead (which reuses a thread-local buffer).
> * For reading the cache name it would be even better to use {{ByteString}} and avoid the UTF8 decoding.
> * {{MediaType.hashCode()}} allocates an iterator for the params map even though it's empty.
> * {{JBossMarshallingTranscoder.transcode()}} is called twice for each requests, and even when there is no transcoding to perform it does a lot of {{String.equals()}} checks.
> * {{CacheImpl.getCacheEntryAsync()}} allocates a new {{CompletableFuture}} via {{applyThen()}} just to change the return type, could do the same thing by casting to the erased type.
> * {{EncoderCache.getCacheEntryAsync()}} could also avoid allocating a {{CompletableFuture}} when the read was synchronous.
> * {{Encoder2x}} is stateless, and yet a new instance is created for each request.
> * {{Encoder2x.writeHeader()}} looks up the cache info a second time, as most requests needed that info to execute the operation, plus one useless (I think) {{String.equals()}} check for the counter cache.
> There are also a few issues with the benchmark itself:
> * The load stage took less than 3 mins according to the logs, but flight recordings show {{PutKeyValueCommand}}s being executed at least 1 minute after the end of the load phase.
> * Either RadarGun or FlightRecorder itself is doing lots of JMX calls that throw exceptions constantly through the benchmark, allocating lots of {{StackTraceElement}} instances.
> * Finally, the cluster is unstable, and some nodes are excluded even though the network seems to be fine and GC pauses are quite small.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11005) HotRod decoder small performance improvements
by Dan Berindei (Jira)
Dan Berindei created ISPN-11005:
-----------------------------------
Summary: HotRod decoder small performance improvements
Key: ISPN-11005
URL: https://issues.jboss.org/browse/ISPN-11005
Project: Infinispan
Issue Type: Enhancement
Components: Server
Affects Versions: 10.1.0.Beta1
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 10.1.0.CR1
I noticed some small inefficiencies in the flight recordings from the client-server dist read benchmarks:
* {{Intrinsics.string()}} allocates a temporary {{byte[]}}, we could use {{ByteBuf.toString(start, length, Charset)}} instead (which reuses a thread-local buffer).
* For reading the cache name it would be even better to use {{ByteString}} and avoid the UTF8 decoding.
* {{MediaType.hashCode()}} allocates an iterator for the params map even though it's empty.
* {{JBossMarshallingTranscoder.transcode()}} is called twice for each requests, and even when there is no transcoding to perform it does a lot of {{String.equals()}} checks.
* {{CacheImpl.getCacheEntryAsync()}} allocates a new {{CompletableFuture}} via {{applyThen()}} just to change the return type, could do the same thing by casting to the erased type.
* {{EncoderCache.getCacheEntryAsync()}} could also avoid allocating a {{CompletableFuture}} when the read was synchronous.
* {{Encoder2x}} is stateless, and yet a new instance is created for each request.
* {{Encoder2x.writeHeader()}} looks up the cache info a second time, as most requests needed that info to execute the operation, plus one useless (I think) {{String.equals()}} check for the counter cache.
There are also a few issues with the benchmark itself:
* The load stage took less than 3 mins according to the logs, but flight recordings show {{PutKeyValueCommand}}s being executed at least 1 minute after the end of the load phase.
* Either RadarGun or FlightRecorder itself is doing lots of JMX calls that throw exceptions constantly through the benchmark, allocating lots of {{StackTraceElement}} instances.
* Finally, the cluster is unstable, and some nodes are excluded even though the network seems to be fine and GC pauses are quite small.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11004) SQL server exception purging data
by Megan van de Valk (Jira)
Megan van de Valk created ISPN-11004:
----------------------------------------
Summary: SQL server exception purging data
Key: ISPN-11004
URL: https://issues.jboss.org/browse/ISPN-11004
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Affects Versions: 10.0.1.Final
Reporter: Megan van de Valk
When using string keyed jdbc store with dialect="SQL_SERVER" a SQL exception of 'FOR UPDATE clause allowed only for DECLARE CURSOR' is thrown.
{code:java}
14:57:39,444 WARN [org.infinispan.PERSISTENCE] (expiration-thread--p7-t1) ISPN000026: Caught exception purging data container!: org.infinispan.persistence.spi.PersistenceException: Failed clearing string based JDBC store
at org.infinispan.persistence.jdbc.stringbased.JdbcStringBasedStore.purge(JdbcStringBasedStore.java:502)
at org.infinispan.persistence.spi.SegmentedAdvancedLoadWriteStore.purge(SegmentedAdvancedLoadWriteStore.java:291)
at org.infinispan.persistence.manager.PersistenceManagerImpl.lambda$purgeExpired$8(PersistenceManagerImpl.java:522)
at java.util.ArrayList.forEach(ArrayList.java:1257)
at org.infinispan.persistence.manager.PersistenceManagerImpl.purgeExpired(PersistenceManagerImpl.java:528)
at org.infinispan.persistence.support.DelegatingPersistenceManager.purgeExpired(DelegatingPersistenceManager.java:90)
at org.infinispan.expiration.impl.ExpirationManagerImpl.processExpiration(ExpirationManagerImpl.java:120)
at org.infinispan.expiration.impl.ExpirationManagerImpl$ScheduledTask.run(ExpirationManagerImpl.java:282)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Line 1: FOR UPDATE clause allowed only for DECLARE CURSOR.
at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:216)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.getNextResult(SQLServerStatement.java:1515)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.doExecutePreparedStatement(SQLServerPreparedStatement.java:404)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement$PrepStmtExecCmd.doExecute(SQLServerPreparedStatement.java:350)
at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:5696)
at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:1715)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeCommand(SQLServerStatement.java:180)
at com.microsoft.sqlserver.jdbc.SQLServerStatement.executeStatement(SQLServerStatement.java:155)
at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeQuery(SQLServerPreparedStatement.java:285)
at org.infinispan.persistence.jdbc.stringbased.JdbcStringBasedStore.purge(JdbcStringBasedStore.java:467)
... 14 more
{code}
The method initSelectOnlyExpiredRowsSql in [AbstractTableManager|https://github.com/infinispan/infinispan/blob/master...] includes a FOR UPDATE:
{code:java}
return String.format("%1$s WHERE %2$s < ? AND %2$s > 0 FOR UPDATE", getLoadAllRowsSql(), config.timestampColumnName());
{code}
It should probably be overwritten in [SQLServerTableManger|https://github.com/infinispan/infinispan/blob/master...] with
{code:java}
return String.format("%1$s WITH(UPDLOCK) WHERE %2$s < ? AND %2$s > 0", getLoadAllRowsSql(), config.timestampColumnName());
{code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11002) RocksDB XML examples missing xmlns attribute
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-11002?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-11002:
--------------------------------
Summary: RocksDB XML examples missing xmlns attribute (was: Store XML examples missing xmlns attribute)
> RocksDB XML examples missing xmlns attribute
> --------------------------------------------
>
> Key: ISPN-11002
> URL: https://issues.jboss.org/browse/ISPN-11002
> Project: Infinispan
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 10.1.0.Beta1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.CR1
>
>
> Some of the store xml configuraiton examples are missing the {{xmlns}} attribute, which means that the xml cannot be parsed and the following error is thrown:
> {code:java}
> 15:14:47,853 FATAL [org.infinispan.SERVER] (main) ISPN080028: Infinispan Server failed to start: org.infinispan.commons.CacheConfigurationException: ISPN000327: Cannot find a parser for element 'rocksdb-store' in namespace 'urn:infinispan:config:10.0'. Check that your configuration is up-to date for this version of Infinispan.
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11002) RocksDB XML examples missing xmlns attribute
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-11002?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-11002:
--------------------------------
Status: Open (was: New)
> RocksDB XML examples missing xmlns attribute
> --------------------------------------------
>
> Key: ISPN-11002
> URL: https://issues.jboss.org/browse/ISPN-11002
> Project: Infinispan
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 10.1.0.Beta1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.CR1
>
>
> Some of the store xml configuraiton examples are missing the {{xmlns}} attribute, which means that the xml cannot be parsed and the following error is thrown:
> {code:java}
> 15:14:47,853 FATAL [org.infinispan.SERVER] (main) ISPN080028: Infinispan Server failed to start: org.infinispan.commons.CacheConfigurationException: ISPN000327: Cannot find a parser for element 'rocksdb-store' in namespace 'urn:infinispan:config:10.0'. Check that your configuration is up-to date for this version of Infinispan.
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months
[JBoss JIRA] (ISPN-11002) RocksDB XML examples missing xmlns attribute
by Ryan Emerson (Jira)
[ https://issues.jboss.org/browse/ISPN-11002?page=com.atlassian.jira.plugin... ]
Ryan Emerson updated ISPN-11002:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/7628
> RocksDB XML examples missing xmlns attribute
> --------------------------------------------
>
> Key: ISPN-11002
> URL: https://issues.jboss.org/browse/ISPN-11002
> Project: Infinispan
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 10.1.0.Beta1
> Reporter: Ryan Emerson
> Assignee: Ryan Emerson
> Priority: Major
> Fix For: 10.1.0.CR1
>
>
> Some of the store xml configuraiton examples are missing the {{xmlns}} attribute, which means that the xml cannot be parsed and the following error is thrown:
> {code:java}
> 15:14:47,853 FATAL [org.infinispan.SERVER] (main) ISPN080028: Infinispan Server failed to start: org.infinispan.commons.CacheConfigurationException: ISPN000327: Cannot find a parser for element 'rocksdb-store' in namespace 'urn:infinispan:config:10.0'. Check that your configuration is up-to date for this version of Infinispan.
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 4 months