[JBoss JIRA] (ISPN-11249) Unexpected functionality added by Java8 default interface methods
by Wolf-Dieter Fink (Jira)
Wolf-Dieter Fink created ISPN-11249:
---------------------------------------
Summary: Unexpected functionality added by Java8 default interface methods
Key: ISPN-11249
URL: https://issues.redhat.com/browse/ISPN-11249
Project: Infinispan
Issue Type: Bug
Reporter: Wolf-Dieter Fink
With Java8 there are interfaces which implement default methods.
Those defaults are available if not overridden, but the function behind might not be correct because the method was not meant to be implemented.
There are issues with the transaction and locking because of the remote invocation, so the conditional operation will not work consistent.
Such methods need to be checked and throw a UnsupportedOperation.
This appears for the compute(...) methods
compute(key, BiFunct) -> default to java.util.concurrent.ConcurrentMap interface
compute() methods with expiration will throw an UnsupportedOperationException as expected.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11248) Add test for ServerTask that utilizes protostream stored entries
by Will Burns (Jira)
Will Burns created ISPN-11248:
---------------------------------
Summary: Add test for ServerTask that utilizes protostream stored entries
Key: ISPN-11248
URL: https://issues.redhat.com/browse/ISPN-11248
Project: Infinispan
Issue Type: Task
Reporter: Will Burns
Fix For: 11.0.0.Alpha1
We currently have a single ServerTask that just prints out "Hello <name>". We should add a new test that actually tests a very likely use case of storing entries in protostream and using a task that deserializes them properly (this could be done automatically by the encoding layer of the cache, if it is working).
We may also want to look into sharing this with a custom loader, as we have users doing this today. And it is quite clunky, so we can see how the usability is in 11.0.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11247) "create cache MyCache --template=org.infinispan.DIST_SYNC --volatile=false" is not working
by Wolf-Dieter Fink (Jira)
[ https://issues.redhat.com/browse/ISPN-11247?page=com.atlassian.jira.plugi... ]
Wolf-Dieter Fink updated ISPN-11247:
------------------------------------
Description:
If a cache is created with CLI the default (volatile=true) is working as expected and the cache is created clusterwide but not persistent as expected
Adding a cache via CLI which should be persistent will return a "null" within the CLI shell.
Adding with the Console will work as expected and add the cache persistent
Output from console:
[quote]
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=false
null
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=true
[node1@cluster//containers/default]> cache
___protobuf_metadata ___script_cache wolf1
[quote]
was:
If a cache is created with CLI the default (volatile=true) is working as expected and the cache is created clusterwide but not persistent as expected
Adding a cache via CLI which should be persistent will return a "null" within the CLI shell.
Adding with the Console will work as expected and add the cache persistent
Output from console:
~~~
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=false
null
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=true
[node1@cluster//containers/default]> cache
___protobuf_metadata ___script_cache wolf1
~~~
> "create cache MyCache --template=org.infinispan.DIST_SYNC --volatile=false" is not working
> ------------------------------------------------------------------------------------------
>
> Key: ISPN-11247
> URL: https://issues.redhat.com/browse/ISPN-11247
> Project: Infinispan
> Issue Type: Bug
> Components: CLI
> Affects Versions: 10.1.0.Final, 10.1.1.Final
> Reporter: Wolf-Dieter Fink
> Priority: Major
>
> If a cache is created with CLI the default (volatile=true) is working as expected and the cache is created clusterwide but not persistent as expected
> Adding a cache via CLI which should be persistent will return a "null" within the CLI shell.
> Adding with the Console will work as expected and add the cache persistent
> Output from console:
> [quote]
> [node1@cluster//containers/default]> cache ___
> ___protobuf_metadata ___script_cache
> [node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=false
> null
> [node1@cluster//containers/default]> cache ___
> ___protobuf_metadata ___script_cache
> [node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=true
> [node1@cluster//containers/default]> cache
> ___protobuf_metadata ___script_cache wolf1
> [quote]
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11247) "create cache MyCache --template=org.infinispan.DIST_SYNC --volatile=false" is not working
by Wolf-Dieter Fink (Jira)
Wolf-Dieter Fink created ISPN-11247:
---------------------------------------
Summary: "create cache MyCache --template=org.infinispan.DIST_SYNC --volatile=false" is not working
Key: ISPN-11247
URL: https://issues.redhat.com/browse/ISPN-11247
Project: Infinispan
Issue Type: Bug
Components: CLI
Affects Versions: 10.1.1.Final, 10.1.0.Final
Reporter: Wolf-Dieter Fink
If a cache is created with CLI the default (volatile=true) is working as expected and the cache is created clusterwide but not persistent as expected
Adding a cache via CLI which should be persistent will return a "null" within the CLI shell.
Adding with the Console will work as expected and add the cache persistent
Output from console:
~~~
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=false
null
[node1@cluster//containers/default]> cache ___
___protobuf_metadata ___script_cache
[node1@cluster//containers/default]> create cache wolf1 --template=org.infinispan.DIST_SYNC --volatile=true
[node1@cluster//containers/default]> cache
___protobuf_metadata ___script_cache wolf1
~~~
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11244) HotRodIteratorReapTest random failures
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11244?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11244:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> HotRodIteratorReapTest random failures
> --------------------------------------
>
> Key: ISPN-11244
> URL: https://issues.redhat.com/browse/ISPN-11244
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1
>
>
> {noformat}
> 10:39:16,244 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections
> java.lang.AssertionError: expected:<0> but was:<9>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) ~[testng-6.14.3.jar:?]
> at org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections(HotRodIteratorReapTest.java:34) ~[test-classes/:?]
> {noformat}
> I think it fails because Netty closes the socket asynchronously, doesn't wait for the orderly shutdown. Plus the server reacts and reaps the iteration after the close, it doesn't block the client's close while doing that.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11242) HotRod server test client sends invalid iteration start request
by Will Burns (Jira)
[ https://issues.redhat.com/browse/ISPN-11242?page=com.atlassian.jira.plugi... ]
Will Burns updated ISPN-11242:
------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
> HotRod server test client sends invalid iteration start request
> ---------------------------------------------------------------
>
> Key: ISPN-11242
> URL: https://issues.redhat.com/browse/ISPN-11242
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> {{HotRodIteratorReapTest}} logs a protocol error:
> {noformat}
> 10:39:15,062 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsed header: HotRodHeader{op=ITERATION_START, version=21, messageId=2115, cacheName='Test', flag=0, clientIntel=1, topologyId=0, keyType=null, valueType=null}
> 10:39:15,071 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsing error
> org.infinispan.server.hotrod.InvalidMagicIdException: Error reading magic byte or message id: 0
> at org.infinispan.server.hotrod.HotRodDecoder.switch0(HotRodDecoder.java:208) ~[classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.switch1_0(HotRodDecoder.java:153) [classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.java:143) [classes/:?]
> at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:503) [netty-codec-4.1.43.Final.jar:4.1.43.Final]
> {noformat}
> This happens because the test client in the server testsuite always sends the {{includeMetadata}} parameter, but the server only expects it when the version number is >= 24.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11231) Transcoder lookup is inefficient
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11231?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11231:
--------------------------------
Fix Version/s: 9.4.18.Final
> Transcoder lookup is inefficient
> --------------------------------
>
> Key: ISPN-11231
> URL: https://issues.redhat.com/browse/ISPN-11231
> Project: Infinispan
> Issue Type: Bug
> Components: Core
> Affects Versions: 9.4.17.Final, 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Fix For: 9.4.18.Final, 11.0.0.Alpha1
>
>
> {{EncoderRegistryImpl}} stores transcoders in a set, without any lookup optimization because it assumes the number of transcoders is small.
> However, {{InternalCacheFactory.bootstrap()}} registers a "different" {{TranscoderMarshallerAdapter}} for each cache, even though they all delegate to the same global marshaller.
> I believe the global marshaller transcoder adapter should be registered only once in {{EncoderRegistryFactory}}, and ideally we should have a way of looking up transcoders by media types.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months
[JBoss JIRA] (ISPN-11246) Invoking a write operation with a loader should not retrieve value
by Will Burns (Jira)
Will Burns created ISPN-11246:
---------------------------------
Summary: Invoking a write operation with a loader should not retrieve value
Key: ISPN-11246
URL: https://issues.redhat.com/browse/ISPN-11246
Project: Infinispan
Issue Type: Bug
Components: Loaders and Stores
Reporter: Will Burns
We have the notion of a Loader and a Store. If the user has configured a Loader and not a store, we should not retrieve the previous value when doing a write operation.
This is normally used with a remove method to remove some in memory contents (as you can't write to a Loader). But in this case there is no reason to return the previous value from the Loader.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
4 years, 10 months