[JBoss JIRA] (ISPN-11210) Classloading issues when using annotation generated marshallers in deployed server tasks
by Pedro Ruivo (Jira)
[ https://issues.redhat.com/browse/ISPN-11210?page=com.atlassian.jira.plugi... ]
Pedro Ruivo updated ISPN-11210:
-------------------------------
Fix Version/s: 9.4.18.Final
> Classloading issues when using annotation generated marshallers in deployed server tasks
> ----------------------------------------------------------------------------------------
>
> Key: ISPN-11210
> URL: https://issues.redhat.com/browse/ISPN-11210
> Project: Infinispan
> Issue Type: Bug
> Affects Versions: 9.4.0.Final, 10.0.0.Final
> Reporter: Nistor Adrian
> Assignee: Nistor Adrian
> Priority: Major
> Fix For: 9.4.18.Final, 10.1.2.Final, 11.0.0.Alpha1
>
>
> A server task is deployed and the task generates annotation based protostream marshallers during context init.
> A NullPointerException is thrown as seen in this stacktrace, but this is another issue in javassist which obscures the real reason, a java.lang.NoClassDefFoundError: org/infinispan/protostream/ImmutableSerializationContext.
> The NoClassDefFoundError is caused by the use of the thread context classloader in the ClassPool of javassist. The TCL is not always suitable. At least it never is for deployed server tasks. There is no workaround for this, and the only option is to modify ProtoSchemaBuilder.build signature, or add an overloaded method that also accepts a ClassLoader so the user can take control.
> {code}
> 18:40:18,528 WARN [org.infinispan.remoting.inboundhandler.NonTotalOrderPerCacheInboundInvocationHandler] (remote-thread--p2-t1) ISPN000071: Caught exception when handling command DistributedExecuteCommand [cache=Cache 'addressbook'@manapakam, keys=[], callable=org.infinispan.server.infinispan.task.DistributedServerTask@5403bdfd]: org.infinispan.protostream.annotations.ProtoSchemaBuilderException: Failed to generate marshaller implementation class
> at org.infinispan.protostream.annotations.impl.ProtoSchemaGenerator.generateAndRegister(ProtoSchemaGenerator.java:144)
> at org.infinispan.protostream.annotations.ProtoSchemaBuilder.build(ProtoSchemaBuilder.java:235)
> at test.cacheloader.impl.RemoveObjectsTask.setTaskContext(RemoveObjectsTask.java:57)
> at org.infinispan.server.infinispan.task.ServerTaskWrapper.inject(ServerTaskWrapper.java:43)
> at org.infinispan.server.infinispan.task.DistributedServerTask.call(DistributedServerTask.java:46)
> at org.infinispan.commands.read.DistributedExecuteCommand.invokeAsync(DistributedExecuteCommand.java:99)
> at org.infinispan.remoting.inboundhandler.BasePerCacheInboundInvocationHandler.invokeCommand(BasePerCacheInboundInvocationHandler.java:117)
> at org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.invoke(BaseBlockingRunnable.java:99)
> at org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.runAsync(BaseBlockingRunnable.java:71)
> at org.infinispan.remoting.inboundhandler.BaseBlockingRunnable.run(BaseBlockingRunnable.java:40)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.NullPointerException
> at protostream.javassist.CannotCompileException.<init>(CannotCompileException.java:77)
> at protostream.javassist.util.proxy.DefineClassHelper.toClass(DefineClassHelper.java:249)
> at protostream.javassist.ClassPool.toClass(ClassPool.java:1120)
> at protostream.javassist.ClassPool.toClass(ClassPool.java:1083)
> at protostream.javassist.ClassPool.toClass(ClassPool.java:1041)
> at protostream.javassist.CtClass.toClass(CtClass.java:1278)
> at org.infinispan.protostream.annotations.impl.MarshallerCodeGenerator.generateMessageMarshaller(MarshallerCodeGenerator.java:230)
> at org.infinispan.protostream.annotations.impl.ProtoSchemaGenerator.generateMarshallers(ProtoSchemaGenerator.java:172)
> at org.infinispan.protostream.annotations.impl.ProtoSchemaGenerator.generateAndRegister(ProtoSchemaGenerator.java:142)
> ... 12 more
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11244) HotRodIteratorReapTest random failures
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11244?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11244:
--------------------------------
Status: Open (was: New)
> HotRodIteratorReapTest random failures
> --------------------------------------
>
> Key: ISPN-11244
> URL: https://issues.redhat.com/browse/ISPN-11244
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1
>
>
> {noformat}
> 10:39:16,244 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections
> java.lang.AssertionError: expected:<0> but was:<9>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) ~[testng-6.14.3.jar:?]
> at org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections(HotRodIteratorReapTest.java:34) ~[test-classes/:?]
> {noformat}
> I think it fails because Netty closes the socket asynchronously, doesn't wait for the orderly shutdown. Plus the server reacts and reaps the iteration after the close, it doesn't block the client's close while doing that.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11244) HotRodIteratorReapTest random failures
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11244?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11244:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/7799
> HotRodIteratorReapTest random failures
> --------------------------------------
>
> Key: ISPN-11244
> URL: https://issues.redhat.com/browse/ISPN-11244
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Major
> Labels: testsuite_stability
> Fix For: 11.0.0.Alpha1
>
>
> {noformat}
> 10:39:16,244 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections
> java.lang.AssertionError: expected:<0> but was:<9>
> at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) ~[testng-6.14.3.jar:?]
> at org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections(HotRodIteratorReapTest.java:34) ~[test-classes/:?]
> {noformat}
> I think it fails because Netty closes the socket asynchronously, doesn't wait for the orderly shutdown. Plus the server reacts and reaps the iteration after the close, it doesn't block the client's close while doing that.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11244) HotRodIteratorReapTest random failures
by Dan Berindei (Jira)
Dan Berindei created ISPN-11244:
-----------------------------------
Summary: HotRodIteratorReapTest random failures
Key: ISPN-11244
URL: https://issues.redhat.com/browse/ISPN-11244
Project: Infinispan
Issue Type: Bug
Components: Server, Test Suite
Affects Versions: 10.1.1.Final
Reporter: Dan Berindei
Assignee: Dan Berindei
Fix For: 11.0.0.Alpha1
{noformat}
10:39:16,244 ERROR (testng-Test:[]) [TestSuiteProgress] Test failed: org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections
java.lang.AssertionError: expected:<0> but was:<9>
at org.testng.AssertJUnit.assertEquals(AssertJUnit.java:252) ~[testng-6.14.3.jar:?]
at org.infinispan.server.hotrod.HotRodIteratorReapTest.testIterationStateReaperOnClosedConnections(HotRodIteratorReapTest.java:34) ~[test-classes/:?]
{noformat}
I think it fails because Netty closes the socket asynchronously, doesn't wait for the orderly shutdown. Plus the server reacts and reaps the iteration after the close, it doesn't block the client's close while doing that.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11242) HotRod server test client sends invalid iteration start request
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11242?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11242:
--------------------------------
Priority: Minor (was: Major)
> HotRod server test client sends invalid iteration start request
> ---------------------------------------------------------------
>
> Key: ISPN-11242
> URL: https://issues.redhat.com/browse/ISPN-11242
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> {{HotRodIteratorReapTest}} logs a protocol error:
> {noformat}
> 10:39:15,062 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsed header: HotRodHeader{op=ITERATION_START, version=21, messageId=2115, cacheName='Test', flag=0, clientIntel=1, topologyId=0, keyType=null, valueType=null}
> 10:39:15,071 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsing error
> org.infinispan.server.hotrod.InvalidMagicIdException: Error reading magic byte or message id: 0
> at org.infinispan.server.hotrod.HotRodDecoder.switch0(HotRodDecoder.java:208) ~[classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.switch1_0(HotRodDecoder.java:153) [classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.java:143) [classes/:?]
> at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:503) [netty-codec-4.1.43.Final.jar:4.1.43.Final]
> {noformat}
> This happens because the test client in the server testsuite always sends the {{includeMetadata}} parameter, but the server only expects it when the version number is >= 24.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11242) HotRod server test client sends invalid iteration start request
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11242?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11242:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/7798
> HotRod server test client sends invalid iteration start request
> ---------------------------------------------------------------
>
> Key: ISPN-11242
> URL: https://issues.redhat.com/browse/ISPN-11242
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> {{HotRodIteratorReapTest}} logs a protocol error:
> {noformat}
> 10:39:15,062 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsed header: HotRodHeader{op=ITERATION_START, version=21, messageId=2115, cacheName='Test', flag=0, clientIntel=1, topologyId=0, keyType=null, valueType=null}
> 10:39:15,071 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsing error
> org.infinispan.server.hotrod.InvalidMagicIdException: Error reading magic byte or message id: 0
> at org.infinispan.server.hotrod.HotRodDecoder.switch0(HotRodDecoder.java:208) ~[classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.switch1_0(HotRodDecoder.java:153) [classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.java:143) [classes/:?]
> at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:503) [netty-codec-4.1.43.Final.jar:4.1.43.Final]
> {noformat}
> This happens because the test client in the server testsuite always sends the {{includeMetadata}} parameter, but the server only expects it when the version number is >= 24.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (ISPN-11242) HotRod server test client sends invalid iteration start request
by Dan Berindei (Jira)
[ https://issues.redhat.com/browse/ISPN-11242?page=com.atlassian.jira.plugi... ]
Dan Berindei updated ISPN-11242:
--------------------------------
Status: Open (was: New)
> HotRod server test client sends invalid iteration start request
> ---------------------------------------------------------------
>
> Key: ISPN-11242
> URL: https://issues.redhat.com/browse/ISPN-11242
> Project: Infinispan
> Issue Type: Bug
> Components: Server, Test Suite
> Affects Versions: 10.1.1.Final
> Reporter: Dan Berindei
> Assignee: Dan Berindei
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> {{HotRodIteratorReapTest}} logs a protocol error:
> {noformat}
> 10:39:15,062 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsed header: HotRodHeader{op=ITERATION_START, version=21, messageId=2115, cacheName='Test', flag=0, clientIntel=1, topologyId=0, keyType=null, valueType=null}
> 10:39:15,071 TRACE (HotRod-Test-ServerIO-406-1:[]) [BaseDecoder] Parsing error
> org.infinispan.server.hotrod.InvalidMagicIdException: Error reading magic byte or message id: 0
> at org.infinispan.server.hotrod.HotRodDecoder.switch0(HotRodDecoder.java:208) ~[classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.switch1_0(HotRodDecoder.java:153) [classes/:?]
> at org.infinispan.server.hotrod.HotRodDecoder.decode(HotRodDecoder.java:143) [classes/:?]
> at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:503) [netty-codec-4.1.43.Final.jar:4.1.43.Final]
> {noformat}
> This happens because the test client in the server testsuite always sends the {{includeMetadata}} parameter, but the server only expects it when the version number is >= 24.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months