[infinispan-issues] [JBoss JIRA] (ISPN-3795) QueryInterceptor incorrectly relies on the return value of a RemoveCommand
[
https://issues.jboss.org/browse/ISPN-3795?page=com.atlassian.jira.plugin....
]
Gustavo Fernandes commented on ISPN-3795:
-----------------------------------------
[~sannegrinovero] Could it be that when IGNORE_RETURN_VALUE was introduced, the overhead
of indexing was orders of magnitude higher than today, given that previously it was doing
1 commit per entry? After that we add transparent batching to Hibernate Search SYNC
backend, plus the async indexing backend, I reckon performance is vastly superior to do
batch loading nowadays.
We could allso introduce a way to temporarily enable async indexing to do batch loading,
which will always beat the sync option.
QueryInterceptor incorrectly relies on the return value of a
RemoveCommand
--------------------------------------------------------------------------
Key: ISPN-3795
URL: https://issues.jboss.org/browse/ISPN-3795
Project: Infinispan
Issue Type: Bug
Components: Embedded Querying
Affects Versions: 6.0.0.Final
Reporter: Dan Berindei
Assignee: Gustavo Fernandes
QueryInterceptor uses the return value from RemoveCommand/ReplaceCommand to remove the
value from the index.
But both RemoveCommand and ReplaceCommand have a variant with an expected value
parameter, and this variant return a boolean value instead of the removed/replaced value.
In that case, the previous value won't be removed from the index.
QueryInterceptor should probably use the previous value from the context entries to
update the index instead.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)