[infinispan-issues] [JBoss JIRA] (ISPN-3603) Conditional command is committed on originator when it fails on primary owner

Conditional command is committed on originator when it fails on primary owner ----------------------------------------------------------------------------- Key: ISPN-3603 URL: https://issues.jboss.org/browse/ISPN-3603 Project: Infinispan Issue Type: Bug Components: Distributed Cache Affects Versions: 6.0.0.CR1 Reporter: Radim Vansa Assignee: Pedro Ruivo Priority: Critical Labels: jdg62blocker Fix For: 6.0.0.CR2, 6.0.0.Final In non-tx cache, when conditional command (e.g. ReplaceCommand) fails on primary owner because the old value is not equal to current value, the NonTxDistributionInterceptor.visitReplaceCommand returns false but the entry is committed in EntryWrappingInterceptor anyway. Speaking about EntryWrappingInterceptor.invokeNextAndApplyChanges: NonTxDistributionInterceptor does not mark the command as unsuccessful if it fails on the primary owner, therefore, checking for command.isSuccessful() in order to retry the command upon topology change may seem insufficient.