[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Sanne Grinovero commented on ISPN-883: -------------------------------------- Well that would complicate things quite a bit, I need to configure this, and it seems a bit silly as I have a reference already. I opened the issue as Mircea mentioned that it should work, and also some comments in org.infinispan.factories.TransactionManagerFactory seem to agree in expecting this. Testcase: https://github.com/Sanne/infinispan/tree/ISPN-883 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Mircea Markus updated ISPN-883: ------------------------------- Summary: Configuration.setTransactionManagerLookup() is ignored (was: Being able to pass a TransactionManager instance to a new Cache definition) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Sanne Grinovero updated ISPN-883: --------------------------------- Fix Version/s: 5.0.0.ALPHA3 (was: 5.0.0.BETA1) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Sanne Grinovero updated ISPN-883: --------------------------------- Affects Version/s: 4.2.0.Final 4.1.0.Final 4.0.0.Final -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Galder Zamarreño edited comment on ISPN-883 at 2/3/11 4:47 AM: --------------------------------------------------------------- Sanne/Mircea, something odd is happening here. I have a Hibernate 2LC example here that uses Infinispan 4.2.0.BETA1. In the 2LC integration code, I do the following: {code} Configuration regionOverrides... // Where transactionManagerlookup is org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup@74ae8af4 regionOverrides.setTransactionManagerLookup(transactionManagerlookup); {code} And when Infinispan's TransactionManagerFactory calls: {code} TransactionManagerLookup lookup = configuration.getTransactionManagerLookup(); // lookup is pointing to org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup@74ae8af4 {code} And this is before this jira was fixed. FYI org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup implements org.infinispan.transaction.lookup.TransactionManagerLookup. It's a TM lookup that takes Hibernate's TM and puts it into Infinispan. So, what exactly have you guys fixed to be precise? was (Author: galder.zamarreno(a)jboss.com): Sanne/Mircea, something odd is happening here. I have a Hibernate 2LC example here that uses Infinispan 4.2.0.BETA1. In the 2LC integration code, I do the following: Configuration regionOverrides... // Where transactionManagerlookup is org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup@74ae8af4 regionOverrides.setTransactionManagerLookup(transactionManagerlookup); And when Infinispan's TransactionManagerFactory calls: TransactionManagerLookup lookup = configuration.getTransactionManagerLookup(); // lookup is pointing to org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup@74ae8af4 And this is before this jira was fixed. FYI org.hibernate.cache.infinispan.tm.HibernateTransactionManagerLookup implements org.infinispan.transaction.lookup.TransactionManagerLookup. It's a TM lookup that takes Hibernate's TM and puts it into Infinispan. So, what exactly have you guys fixed to be precise? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Galder Zamarreño commented on ISPN-883: --------------------------------------- Btw, I've just tried with 4.2.0.FINAL and it still behaves correctly... -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Galder Zamarreño edited comment on ISPN-883 at 2/3/11 5:57 AM: --------------------------------------------------------------- Indeed very suttle, the reason 2LC code worked was cos the TransactionManagerLookup was set on top of an already defined configuration: {code} Configuration customConfiguration = cacheManager.defineConfiguration("aCache", new Configuration()); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); {code} That works, whereas what you guys did in the test didn't: {code} Configuration customConfiguration = new Configuration(); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); {code} The reason the first option works is cos I'm manually setting the TML instance and when the next config is created, it clones this initial config in which case it does pass over the TML. The issue you guys fixed is still correct, the difference was in the way I generate configurations. was (Author: galder.zamarreno(a)jboss.com): Indeed very suttle, the reason 2LC code worked was cos the TransactionManagerLookup was set on top of an already defined configuration: Configuration customConfiguration = cacheManager.defineConfiguration("aCache", new Configuration()); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); That works, whereas what you guys did in the test didn't: Configuration customConfiguration = new Configuration(); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); The reason the first option works is cos I'm manually setting the TML instance and when the next config is created, it clones this initial config in which case it does pass over the TML. The issue you guys fixed is still correct, the difference was in the way I generate configurations. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Galder Zamarreño commented on ISPN-883: --------------------------------------- Indeed very suttle, the reason 2LC code worked was cos the TransactionManagerLookup was set on top of an already defined configuration: Configuration customConfiguration = cacheManager.defineConfiguration("aCache", new Configuration()); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); That works, whereas what you guys did in the test didn't: Configuration customConfiguration = new Configuration(); customConfiguration.setTransactionManagerLookup(new TxManagerLookupA()); Configuration definedConfiguration = cacheManager.defineConfiguration("aCache", customConfiguration); The reason the first option works is cos I'm manually setting the TML instance and when the next config is created, it clones this initial config in which case it does pass over the TML. The issue you guys fixed is still correct, the difference was in the way I generate configurations. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Sanne Grinovero commented on ISPN-883: -------------------------------------- Hi Galder, I'm glad you found out. I've been looking into your tests trying to figure out how it was possible for them to succeed; indeed a subtle difference. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-883?page=com.atlassian.jira.plugin.s... ] Galder Zamarreño updated ISPN-883: ---------------------------------- Fix Version/s: 4.2.1.CR2 Affects Version/s: (was: 4.0.0.Final) (was: 4.1.0.Final) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira