[JBoss JIRA] Created: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
6:17 p.m.
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 5.0.0.CR3, 4.2.1.FINAL
Reporter: Steven Newson
Assignee: Manik Surtani
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code has
no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:12 a.m.
New subject: [JBoss JIRA] Assigned: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño reassigned ISPN-1140:
--------------------------------------
Assignee: Galder Zamarreño (was: Manik Surtani)
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:12 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1140:
-----------------------------------
Fix Version/s: 5.0.0.CR4
5.0.0.FINAL
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Steven Newson commented on ISPN-1140:
-------------------------------------
It's probably worth noting that this bug breaks Non Transactional use of Infinispan in
Hibernate.
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Steven Newson edited comment on ISPN-1140 at 5/27/11 5:15 AM:
--------------------------------------------------------------
It's probably worth noting that this bug breaks Non Transactional (i.e. non JTA) use
of Infinispan in Hibernate.
was (Author: stevennewson):
It's probably worth noting that this bug breaks Non Transactional use of
Infinispan in Hibernate.
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:19 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Steven Newson updated ISPN-1140:
--------------------------------
Description:
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code has
no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
was:
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code has
no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that the following steps via Hibernate don't work:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:36 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1140:
----------------------------------------
Well, non transactional use of Infinispan in Hibernate is not supported. You can only use
READ_ONLY or TRANSACTIONAL modes with Infinispan for the moment.
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:37 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Steven Newson commented on ISPN-1140:
-------------------------------------
Sorry, I wasn't clear. I'm using the TRANSACTIONAL mode but I'm not in a JTA
container. That means that all of my cache operations go via the NonTxInvocationContext.
When the code gets to the InvocationContextContainerImpl it recognises that there is not a
running transaction and forces the code down the "Non-transactional" route.
This is totally the behaviour I want. I will ultimately be deploying this application into
a server with a JTA container (we deploy to multiple containers as our clients use
different ones). However, my development team want to be able to run the application
locally (from within Eclipse) and deploy to Tomcat without having to have a JTA container
present. In development, we just don't care about JTA. Also, when I'm creating
JUnit tests, I don't want to have to start a JTA container in order to run the test.
If the commit fails then the test has failed - I'm not worried about the cache
becoming stale / corrupted in that environment.
For reference, my test looks a bit like this:
{code:java}
public void testLoadSaveLoadCaching() {
MyDomainClass first = new MyDomainClass("ABC", "ABC123");
save(first);
long id = first.id;
MyDomainClass second = load(id);
assertEquals("Should have same code", "ABC", second.code);
assertEquals("Should have correct description", "ABC123",
second.description);
second.description = "DEF123";
update(second);
MyDomainClass third = load(id);
assertEquals("Should have same code", "ABC", third.code);
assertEquals("Should have correct description", "DEF123",
third.description);
}
@Entity(name = "MyDomainClass")
@Cache(usage = CacheConcurrencyStrategy.TRANSACTIONAL)
public static class MyDomainClass {
@Id
@Basic
@Column(name = "id")
public long id;
@Basic
@Column(length = 4)
public String code;
@Basic
@Column(length = 10)
public String description;
}
{code}
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:11 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1140:
-----------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/350
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Dan Berindei updated ISPN-1140:
-------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
Pushed to master.
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 a.m.
New subject: [JBoss JIRA] Reopened: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Manik Surtani reopened ISPN-1140:
---------------------------------
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:18 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Manik Surtani commented on ISPN-1140:
-------------------------------------
@Galder didn't fix the javadoc? ;)
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1140:
----------------------------------------
@Manik, what javadoc?
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Manik Surtani commented on ISPN-1140:
-------------------------------------
@Galder
As pointed out by Steven -
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/o...
(s/returing/returning)
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.CR4, 5.0.0.FINAL
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:01 a.m.
New subject: [JBoss JIRA] Resolved: (ISPN-1140) TransientMortalCacheEntry has incorrect implementation of setValue()
[
https://issues.jboss.org/browse/ISPN-1140?page=com.atlassian.jira.plugin....
]
Galder Zamarreño resolved ISPN-1140.
------------------------------------
Resolution: Done
Fixed now - I need some glasses...
TransientMortalCacheEntry has incorrect implementation of setValue()
--------------------------------------------------------------------
Key: ISPN-1140
URL: https://issues.jboss.org/browse/ISPN-1140
Project: Infinispan
Issue Type: Bug
Components: Core API
Affects Versions: 4.2.1.FINAL, 5.0.0.CR3
Reporter: Steven Newson
Assignee: Galder Zamarreño
Fix For: 5.0.0.FINAL, 5.0.0.CR4
The implementation of {{setValue()}} in {{TransientMortalCacheEntry}} is as follows
{code:java}
public Object setValue(Object value) {
return cacheValue.maxIdle;
}
{code}
This leads to problems in the {{DefaultDataContainer}} as the following {{put()}} code
has no effect:
{code:java}
public void put(Object k, Object v, long lifespan, long maxIdle) {
InternalCacheEntry e = entries.get(k);
if (e != null) {
e.setValue(v);
InternalCacheEntry original = e;
e = entryFactory.update(e, lifespan, maxIdle);
// we have the same instance. So we need to reincarnate.
if(original == e) {
e.reincarnate();
}
} else {
// this is a brand-new entry
e = entryFactory.createNewEntry(k, v, lifespan, maxIdle);
}
entries.put(k, e);
}
{code}
The effect of this for me is that when I am not in a JTA enviroment and I take the
following steps via Hibernate the result is not cached correctly:
- Insert record into table via Hibernate
- Reload record by its ID
- Change non-ID field on the record
- Update the record via Hibernate
- Reload the record by its ID
- Check that the value reloaded matches the updated value
The 2nd level cache always returns the first inserted record rather than the updated one.
Each Hibernate access is inside its own transaction.
I fixed this locally by overriding the class in the classpath, replacing the
{{setValue()}} method with the following implementation:
{code:java}
public Object setValue(Object value) {
Object original = cacheValue.value;
cacheValue.value = value;
return original;
}
{code}
Which also corresponds to the (misspelled :)) Javadoc:
{noformat}Sets the value of the entry, returing the previous value{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4953
days inactive
4966
days old
infinispan-issues@lists.jboss.org
14 comments
4 participants
participants (4)
-
Dan Berindei (JIRA) -
Galder Zamarreño (JIRA)
-
Manik Surtani (JIRA)
-
Steven Newson (JIRA)