[ https://issues.jboss.org/browse/ISPN-9306?page=com.atlassian.jira.plugin.... ] Sanne Grinovero commented on ISPN-9306: --------------------------------------- Example, taking some code from {{AbstractTableManager}}: {code:java} protected String deleteRowSql; public String getDeleteRowSql() { if (deleteRowSql == null) { deleteRowSql = String.format("DELETE FROM %s WHERE %s = ?", getTableName(), config.idColumnName()); } return deleteRowSql; } {code} It's not strictly wrong - especially it might seem to work fine in single threaded tests or servers with a limited amount of cores, but it becomes a huge red flag for the kind of situations Infinispan is used for. Assuming I understand correctly, the method {{getDeleteRowSql()}} is invoked by multiple independent threads sharing the same instance of the table manager, which makes it troublesome. The simplest solution is to either mark the method as {{synchronized}} or the field as {{volatile}} yet both could have other annoying effects on performance optimisations; best would be to initialize all such things into a final field, but that requires a bit of refactoring to ensure you have the table names, column names, etc.. during the contractor invocation. -- This message was sent by Atlassian JIRA (v7.5.0#75005)